Staging: iio: adc: align multi-line function argument with open parenthesis
Subsystems (4)
PATCH 1/1 Staging: iio: adc: align multi-line function argument with open parenthesis
Eliminate WARNING found with checkpatch.pl for argument split in two lines not matching coding conventions identation.
--- drivers/staging/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/adc/ad7192.c +1 -1
@@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev, }static void ad7192_get_available_filter_freq (struct ad7192_state *st, -int *freq) +int *freq) {unsigned int fadc;
Signature · 1 line
2.17.1
Quoted 2 lines · Enrique Vargas
Eliminate WARNING found with checkpatch.pl for argument split in two lines not matching coding conventions identation.
The message seems a bit obscure. There is no argument that is split in two lines, although it is the case that the argument list is split in two lines.
For the subject line, maybe "reduce parameter indentation"
And then for the log message:
"Align function parameter with the right side of the open parenthesis starting the parameter list, to follow kernel coding style. Problem found using checkpatch."
julia
Quoted 27 lines
Signed-off-by Enrique Vargas <[email protected]>--- drivers/staging/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/iio/adc/ad7192.c +1
-2@@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev, }static void ad7192_get_available_filter_freq (struct ad7192_state *st, -int *freq) +int *freq) {unsigned int fadc; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312142721.GA2748%40evX1.
Thanks for the feedback Julia, will include your comments and resend.
Quoted 55 lines · Julia Lawall
Quoted 2 lines · Enrique Vargas
Eliminate WARNING found with checkpatch.pl for argument split in two lines not matching coding conventions identation.
The message seems a bit obscure. There is no argument that is split in two lines, although it is the case that the argument list is split in two lines.
For the subject line, maybe "reduce parameter indentation"
And then for the log message:
"Align function parameter with the right side of the open parenthesis starting the parameter list, to follow kernel coding style. Problem found using checkpatch."
julia
Review
Quoted 7 lines
Signed-off-by Enrique Vargas <[email protected]>--- drivers/staging/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/iio/adc/ad7192.cQuoted 15 lines
index
51b1cd3ad1de..5f65d084e320100644drivers/staging/iio/adc/ad7192.c +1
-2@@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev, }static void ad7192_get_available_filter_freq (struct ad7192_state *st, -int *freq) +int *freq) {unsigned int fadc; --2.17.1
Quoted 2 lines
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20200312142721.GA2748%40evX1
.Quoted 1 line
Signature · 1 line
J Enrique