Skip to contentSkip to conversation

staging: greybus: i2c: remove unused pointers

PATCH In review Lourdes Pedrajas 2 participants 2 messages Mar 12, 2020 – Mar 13, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: greybus: i2c: remove unused pointers

Remove unused pointers in gb_i2c_algorithm structure and gb_i2c_probe() function, as they are not touched since 2014.

---
Changes since v1:
- Corrections in log message

 drivers/staging/greybus/i2c.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/greybus/i2c.c +0 -2
index c48fa1de89b0..de2f6516da09 100644
@@ -224,7 +224,6 @@ static u32 gb_i2c_functionality(struct i2c_adapter *adap)
 
 static const struct i2c_algorithm gb_i2c_algorithm = {
 	.master_xfer	= gb_i2c_master_xfer,
-	/* .smbus_xfer	= gb_i2c_smbus_xfer, */
 	.functionality	= gb_i2c_functionality,
 };
 
@@ -267,7 +266,6 @@ static int gb_i2c_probe(struct gbphy_device *gbphy_dev,
 	adapter->owner = THIS_MODULE;
 	adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
 	adapter->algo = &gb_i2c_algorithm;
-	/* adapter->algo_data = what? */
 
 	adapter->dev.parent = &gbphy_dev->dev;
 	snprintf(adapter->name, sizeof(adapter->name), "Greybus i2c adapter");
Signature · 1 line
2.17.1
Acked-by on v2 1/1
#1 lore raw
Quoted 25 lines · Lourdes Pedrajas

Remove unused pointers in gb_i2c_algorithm structure and gb_i2c_probe() function, as they are not touched since 2014.

---
Changes since v1:
- Corrections in log message

 drivers/staging/greybus/i2c.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/greybus/i2c.c +0 -1
index c48fa1de89b0..de2f6516da09 100644
@@ -224,7 +224,6 @@ static u32 gb_i2c_functionality(struct i2c_adapter *adap)
 
 static const struct i2c_algorithm gb_i2c_algorithm = {
 	.master_xfer	= gb_i2c_master_xfer,
-	/* .smbus_xfer	= gb_i2c_smbus_xfer, */
 	.functionality	= gb_i2c_functionality,
 };
 

drivers/staging/greybus/i2c.c static int gb_i2c_probe(struct gbphy_device *gbphy_dev, · line 271

Quoted 7 lines
drivers/staging/greybus/i2c.c +0 -1
@@ -267,7 +266,6 @@ static int gb_i2c_probe(struct gbphy_device *gbphy_dev,
 	adapter->owner = THIS_MODULE;
 	adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
 	adapter->algo = &gb_i2c_algorithm;
-	/* adapter->algo_data = what? */
 
 	adapter->dev.parent = &gbphy_dev->dev;
 	snprintf(adapter->name, sizeof(adapter->name), "Greybus i2c adapter");
Signature · 1 line
viresh