Skip to contentSkip to conversation

configure: Fix configure error.

PATCH In review Zhang Chen 3 participants 4 messages Mar 13, 2020

lore
Share & tools
lore

Zhang Chen

author
#0 lore raw

PATCH 1/1 configure: Fix configure error.

From: Zhang Chen <[email protected]>

When run the ./configure will always get this error:
Unknown option --exist

It caused by this patch:
commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d

Author: Juan Quintela <[email protected]>
Date:   Tue Dec 17 21:15:24 2019 +0100

configure: Enable test and libs for zstd

Add it to several build systems to make testing good.

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index 3c7470096f..305591f7e0 100755
@@ -2475,7 +2475,7 @@ fi
 # zstd check
 
 if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
         zstd_cflags="$($pkg_config --cflags libzstd)"
         zstd_libs="$($pkg_config --libs libzstd)"
         LIBS="$zstd_libs $LIBS"
Signature · 1 line
2.17.1
#1 lore raw

Le 13/03/2020 à 07:55, Zhang Chen a écrit :

Quoted 25 lines

From: Zhang Chen <[email protected]>

When run the ./configure will always get this error:
Unknown option --exist

It caused by this patch:
commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d

Author: Juan Quintela <[email protected]>
Date:   Tue Dec 17 21:15:24 2019 +0100

configure: Enable test and libs for zstd

Add it to several build systems to make testing good.

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 3c7470096f..305591f7e0 100755

configure fi · line 2481

Quoted 8 lines
configure +1 -1
@@ -2475,7 +2475,7 @@ fi
 # zstd check
 
 if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
         zstd_cflags="$($pkg_config --cflags libzstd)"
         zstd_libs="$($pkg_config --libs libzstd)"
         LIBS="$zstd_libs $LIBS"

Juan already sent a patch to fix that:

[PATCH v2] configure: Improve zstd test
https://patchew.org/QEMU/[email protected]/

Thanks,
Laurent

#2 lore raw
Quoted 48 lines

-----Original Message-----
From: Laurent Vivier <[email protected]>
Sent: Friday, March 13, 2020 4:18 PM
To: Zhang, Chen <[email protected]>; qemu-dev <qemu- [email protected]>
Cc: Zhang Chen <[email protected]>; Dr . David Alan Gilbert <[email protected]>; Juan Quintela <[email protected]>
Subject: Re: [PATCH] configure: Fix configure error.

Le 13/03/2020 à 07:55, Zhang Chen a écrit :

Quoted 25 lines

From: Zhang Chen <[email protected]>

When run the ./configure will always get this error:
Unknown option --exist

It caused by this patch:
commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d

Author: Juan Quintela <[email protected]>
Date:   Tue Dec 17 21:15:24 2019 +0100

configure: Enable test and libs for zstd

Add it to several build systems to make testing good.

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 3c7470096f..305591f7e0 100755

configure fi · line 2481

Quoted 8 lines
configure +1 -1
@@ -2475,7 +2475,7 @@ fi
 # zstd check
 
 if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
         zstd_cflags="$($pkg_config --cflags libzstd)"
         zstd_libs="$($pkg_config --libs libzstd)"
         LIBS="$zstd_libs $LIBS"

Juan already sent a patch to fix that:

Quoted 3 lines

[PATCH v2] configure: Improve zstd test
https://patchew.org/QEMU/20200310111431.173151-1-
[email protected]/

OK, Looks haven't merged to upstream.

Thanks
Zhang Chen

Quoted 3 lines

Thanks,
Laurent

#3 lore raw
Quoted 48 lines · * Zhang, Chen ([email protected]) wrote:
Quoted 48 lines

-----Original Message-----
From: Laurent Vivier <[email protected]>
Sent: Friday, March 13, 2020 4:18 PM
To: Zhang, Chen <[email protected]>; qemu-dev <qemu- [email protected]>
Cc: Zhang Chen <[email protected]>; Dr . David Alan Gilbert <[email protected]>; Juan Quintela <[email protected]>
Subject: Re: [PATCH] configure: Fix configure error.

Le 13/03/2020 à 07:55, Zhang Chen a écrit :

Quoted 25 lines

From: Zhang Chen <[email protected]>

When run the ./configure will always get this error:
Unknown option --exist

It caused by this patch:
commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d

Author: Juan Quintela <[email protected]>
Date:   Tue Dec 17 21:15:24 2019 +0100

configure: Enable test and libs for zstd

Add it to several build systems to make testing good.

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index 3c7470096f..305591f7e0 100755

configure fi · line 2481

Quoted 8 lines
configure +1 -1
@@ -2475,7 +2475,7 @@ fi
 # zstd check
 
 if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
         zstd_cflags="$($pkg_config --cflags libzstd)"
         zstd_libs="$($pkg_config --libs libzstd)"
         LIBS="$zstd_libs $LIBS"

Juan already sent a patch to fix that:

Quoted 5 lines
Quoted 3 lines

[PATCH v2] configure: Improve zstd test
https://patchew.org/QEMU/20200310111431.173151-1-
[email protected]/

OK, Looks haven't merged to upstream.

I've built a pull with it in, testing it now.

Dave

Quoted 6 lines

Thanks
Zhang Chen

Quoted 3 lines

Thanks,
Laurent

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK