staging: rtl8712: Better Fix for long lines in Kconfig help
PATCH v2 1/1 staging: rtl8712: Better Fix for long lines in Kconfig help
Fixes two long line in Kconfig help.
Found using checkpatch.pl
---
Changes in v2:
-Match Kconfig help style
--- drivers/staging/rtl8712/Kconfig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/Kconfig +5 -2
@@ -6,13 +6,16 @@ config R8712U select WEXT_PRIV select FW_LOADER help - This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130. + This option adds the Realtek RTL8712 USB device such as the + D-Link DWA-130. + If built as a module, it will be called r8712u. config R8712_TX_AGGR bool "Realtek RTL8712U Transmit Aggregation code" depends on R8712U && BROKEN help - This option provides transmit aggregation for the Realtek RTL8712 USB device. + This option provides transmit aggregation for the Realtek + RTL8712 USB device.
Signature · 1 line
2.20.1
Hi Veera,
Note that who reads the commit title won't know in which way this is "better" than v1, because v1 isn't tracked by git. I think the "Better" part should be omitted in the title. Looks good to me otherwise, just one minor comment:
Quoted 1 line · On Fri, 13 Mar 2020 21:46:45 +0530 R Veera Kumar <[email protected]> wrote:
Fixes two long line in
Kconfighelp.
^^^^ lines
Signature · 1 line
Stefano
Quoted 7 lines · Stefano Brivio
Hi Veera,
Note that who reads the commit title won't know in which way this is "better" than v1, because v1 isn't tracked by git. I think the "Better" part should be omitted in the title. Looks good to me otherwise, just one minor comment:
Okay.
The "better" thing is coming from "Outreachyfirstpatch - Linux Kernel Newbies.html" page.
Should I make a new patch revision and send again?
Veera
Quoted 9 lines
Quoted 1 line · On Fri, 13 Mar 2020 21:46:45 +0530 R Veera Kumar <[email protected]> wrote:
Fixes two long line in
Kconfighelp.^^^^ linesSignature · 1 line
Stefano
Quoted 9 lines · On Tue, 17 Mar 2020 07:27:30 +0530 Veera <[email protected]> wrote:
Quoted 7 lines · Stefano Brivio
Hi Veera,
Note that who reads the commit title won't know in which way this is "better" than v1, because v1 isn't tracked by git. I think the "Better" part should be omitted in the title. Looks good to me otherwise, just one minor comment:
Quoted 4 lines
Okay.
The "better" thing is coming from "Outreachyfirstpatch - Linux Kernel Newbies.html" page.
I've seen that, I guess that was just a quick example to show a v2 with a different subject. Maybe it's actually misleading and it should be fixed...
Quoted 1 line
Should I make a new patch revision and send again?
Yes, thanks.
Signature · 1 line
Stefano