Skip to contentSkip to conversation

staging: sm750fb: Better Fix of long line in makefile variable

PATCH Superseded R Veera Kumar 2 participants 4 messages Mar 13, 2020 – Mar 17, 2020

Subsystems (2)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: sm750fb: Better Fix of long line in makefile variable

A simple fix of long line in makefile variable assignment. Found using checkpatch.pl.

---
Changes in v3:
- change make variable definition using a clean style
Changes in v2:
- Make the subject line imperative one

---
 drivers/staging/sm750fb/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/Makefile +4 -2
index 1cf3849cef23..b89aa4c12e9d 100644
@@ -1,5 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_FB_SM750)	+= sm750fb.o
 
-sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
-sm750fb-objs		+= ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
+sm750fb-objs		:= sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o \
+			   ddk750_chip.o ddk750_power.o ddk750_mode.o \
+			   ddk750_display.o ddk750_swi2c.o ddk750_sii164.o \
+			   ddk750_dvi.o ddk750_hwi2c.o
Signature · 1 line
2.20.1
#1 lore raw
Quoted 2 lines · On Fri, 13 Mar 2020 22:20:30 +0530 R Veera Kumar <[email protected]> wrote:

A simple fix of long line in makefile variable assignment. Found using checkpatch.pl.

Same comment as v2 for your rtl8172 patch: I think "Better" should be omitted in the commit title. It looks good to me otherwise.

Signature · 1 line
Stefano
author
#2 lore raw
Quoted 9 lines · Stefano Brivio
Quoted 2 lines · On Fri, 13 Mar 2020 22:20:30 +0530 R Veera Kumar <[email protected]> wrote:

A simple fix of long line in makefile variable assignment. Found using checkpatch.pl.

Same comment as v2 for your rtl8172 patch: I think "Better" should be omitted in the commit title. It looks good to me otherwise.

Please see my reply for rtl8712 patch comment.

Also should I make a new patch revision and send again?

Veera

Quoted 7 lines
Signature · 6 lines
Stefano

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200317015030.0de5ef50%40elisabeth.
#3 lore raw
Quoted 1 line · On Tue, 17 Mar 2020 07:29:38 +0530 Veera <[email protected]> wrote:

Also should I make a new patch revision and send again?

Yes.

Signature · 1 line
Stefano