Skip to contentSkip to conversation

ipq806x: gcc: Added the enable regs and mask for PRNG

PATCH Superseded Ansuel Smith 2 participants 6 messages Mar 13, 2020 – Mar 16, 2020

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipq806x: gcc: Added the enable regs and mask for PRNG

kernel got hanged while reading from /dev/hwrng at the time of PRNG clock enable

---
 drivers/clk/qcom/gcc-ipq806x.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/qcom/gcc-ipq806x.c +2 -0
index b0eee0903807..a8456e09c44d 100644
@@ -1224,6 +1224,8 @@ static struct clk_rcg prng_src = {
 		.parent_map = gcc_pxo_pll8_map,
 	},
 	.clkr = {
+		.enable_reg = 0x2e80,
+		.enable_mask = BIT(11),
 		.hw.init = &(struct clk_init_data){
 			.name = "prng_src",
 			.parent_names = gcc_pxo_pll8,
Signature · 1 line
2.25.0
maintainer
#1 lore raw

Quoting Ansuel Smith (2020-03-13 11:54:06)

Quoted 4 lines

kernel got hanged while reading from /dev/hwrng at the time of PRNG clock enable

Is Abhishek the author? Otherwise the tag chain here looks wrong.

Quoted 1 line

Is there some Fixes: tag we can get here too?

Quoted 4 lines
---
 drivers/clk/qcom/gcc-ipq806x.c | 2 ++
 1 file changed, 2 insertions(+)
#2 lore raw

R: [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG

Quoted 14 lines

-----Messaggio originale-----
Da: Stephen Boyd <[email protected]>
Inviato: venerdì 13 marzo 2020 21:30
A: Ansuel Smith <[email protected]>; [email protected]
Cc: Ansuel Smith <[email protected]>; Abhishek Sahu <[email protected]>; Bjorn Andersson <[email protected]>; Michael Turquette <[email protected]>; [email protected]; linux- [email protected]; [email protected]
Oggetto: Re: [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG

Quoted 8 lines

Quoting Ansuel Smith (2020-03-13 11:54:06)

Quoted 4 lines

kernel got hanged while reading from /dev/hwrng at the time of PRNG clock enable

Is Abhishek the author? Otherwise the tag chain here looks wrong.

Yes Abhishek is the author.

Quoted 4 lines
Quoted 1 line

Is there some Fixes: tag we can get here too?

Think I should put the commit that added the gcc. Right?

Quoted 4 lines
Quoted 4 lines
---
 drivers/clk/qcom/gcc-ipq806x.c | 2 ++
 1 file changed, 2 insertions(+)
maintainer
#3 lore raw

Re: R: [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG

Quoting [email protected] (2020-03-13 14:20:36)

Quoted 23 lines
Quoted 14 lines

-----Messaggio originale-----
Da: Stephen Boyd <[email protected]>
Inviato: venerdì 13 marzo 2020 21:30
A: Ansuel Smith <[email protected]>; [email protected]
Cc: Ansuel Smith <[email protected]>; Abhishek Sahu <[email protected]>; Bjorn Andersson <[email protected]>; Michael Turquette <[email protected]>; [email protected]; linux- [email protected]; [email protected]
Oggetto: Re: [PATCH] ipq806x: gcc: Added the enable regs and mask for PRNG

Quoted 8 lines

Quoting Ansuel Smith (2020-03-13 11:54:06)

Quoted 4 lines

kernel got hanged while reading from /dev/hwrng at the time of PRNG clock enable

Is Abhishek the author? Otherwise the tag chain here looks wrong.

Quoted 9 lines

Yes Abhishek is the author.

Quoted 4 lines
Quoted 1 line

Is there some Fixes: tag we can get here too?

Think I should put the commit that added the gcc. Right?

Yes.

#4 lore raw

PATCH RESEND 1/1 ipq806x: gcc: Added the enable regs and mask for PRNG

In reply to Stephen Boyd

Kernel got hanged while reading from /dev/hwrng at the time of PRNG clock enable

Fixes 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global

clock controller (GCC)"

---
 drivers/clk/qcom/gcc-ipq806x.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/clk/qcom/gcc-ipq806x.c +2 -0
index b0eee0903807..a8456e09c44d 100644
@@ -1224,6 +1224,8 @@ static struct clk_rcg prng_src = {
 		.parent_map = gcc_pxo_pll8_map,
 	},
 	.clkr = {
+		.enable_reg = 0x2e80,
+		.enable_mask = BIT(11),
 		.hw.init = &(struct clk_init_data){
 			.name = "prng_src",
 			.parent_names = gcc_pxo_pll8,
Signature · 1 line
2.25.0
maintainer
#5 lore raw

Quoting Ansuel Smith (2020-03-14 06:36:00)

Quoted 2 lines

Kernel got hanged while reading from /dev/hwrng at the time of PRNG clock enable

Authorship is still wrong. There should be a From: Abhishek Sahu <[email protected]> line above this line.

Quoted 7 lines
Fixes 24d8fba44af3 "clk: qcom: Add support for IPQ8064's global

clock controller (GCC)"

---

Also, please don't send as a reply to the older versions of this patch. It makes it harder to keep track of what is new and what isn't new and buries it deep in a thread for me.