staging: vt6655: rearrange line exceeding 80 characters
PATCH 1/1 staging: vt6655: rearrange line exceeding 80 characters
Fix line over 80 character for function.
--- drivers/staging/vt6655/rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vt6655/rxtx.c +2 -2
@@ -1176,8 +1176,8 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,s_vGenerateTxParameter (pDevice, byPktType, tx_buffer_head, pvRrvTime, pvRTS, pvCTS, cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate);/* Fill DataHead */ - uDuration =s_uFillDataHead (pDevice, byPktType, pvTxDataHd, cbFrameSize, uDMAIdx, bNeedACK, -0 ,0 , uMACfragNum, byFBOption, pDevice->wCurrentRate, is_pspoll); + uDuration =s_uFillDataHead (pDevice, byPktType, pvTxDataHd, cbFrameSize, uDMAIdx, + bNeedACK,0 ,0 , uMACfragNum, byFBOption, pDevice->wCurrentRate, is_pspoll); hdr->duration_id = uDuration;
Signature · 1 line
2.7.4
Quoted 1 line · Gokce Kuler
Fix line over 80 character for function.
Try toexplain what you did and why without using "fix". Fix is not very informative.
Quoted 10 lines
Signed-off-by Gokce Kuler <[email protected]>--- drivers/staging/vt6655/rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/vt6655/rxtx.c +0
-0
drivers/staging/vt6655/rxtx.c s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType, · line 1180
Quoted 7 lines
drivers/staging/vt6655/rxtx.c +2
-2@@ -1176,8 +1176,8 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,s_vGenerateTxParameter (pDevice, byPktType, tx_buffer_head, pvRrvTime, pvRTS, pvCTS, cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate);/* Fill DataHead */ - uDuration =s_uFillDataHead (pDevice, byPktType, pvTxDataHd, cbFrameSize, uDMAIdx, bNeedACK, -0 ,0 , uMACfragNum, byFBOption, pDevice->wCurrentRate, is_pspoll); + uDuration =s_uFillDataHead (pDevice, byPktType, pvTxDataHd, cbFrameSize, uDMAIdx, + bNeedACK,0 ,0 , uMACfragNum, byFBOption, pDevice->wCurrentRate, is_pspoll);
It looks like you have made the first line shorter but the second line longer. It would be better to fix the problem completely.
julia
Quoted 11 lines
drivers/staging/vt6655/rxtx.c +0
-1hdr->duration_id = uDuration; --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200314203710.GA14591%40siyah2.