staging: speakup: main: switch multiple assignment for one assignment per line
PATCH v2 1/1 staging: speakup: main: switch multiple assignment for one assignment per line
One assignment per line is preferred, instead of multiple assignments. To make it more readable.
Issue found with checkpatch.
Signed-off-by Lourdes Pedrajas <[email protected]>
---
Changes since v1:
- log and code corections
drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/speakup/main.c +2 -1
@@ -2117,7 +2117,8 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym, spk_keydown =0 ; goto out; } - value = spk_lastkey = pad_chars[value]; + value = pad_chars[value]; + spk_lastkey = value; spk_keydown++; spk_parked &=0xfe ; goto no_map;
Signature · 1 line
2.17.1
Lourdes Pedrajas, le dim. 15 mars 2020 23:12:47 +0100, a ecrit:
Quoted 5 lines
One assignment per line is preferred, instead of multiple assignments. To make it more readable.
Issue found with checkpatch.Signed-off-by Lourdes Pedrajas <[email protected]>
Reviewed-by Samuel Thibautl <[email protected]>
Thanks!
Quoted 24 lines
---
Changes since v1:
- log and code corectionsdrivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/speakup/main.c +2
-1@@ -2117,7 +2117,8 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym, spk_keydown =0 ; goto out; } - value = spk_lastkey = pad_chars[value]; + value = pad_chars[value]; + spk_lastkey = value; spk_keydown++; spk_parked &=0xfe ; goto no_map;Signature · 1 line
2.17.1
Signature · 4 lines
Samuel "...Unix, MS-DOS, and Windows NT (also known as the Good, the Bad, and the Ugly)." (By Matt Welsh)