pci: fix missing off_t define on FreeBSD
PATCH 1/1 pci: fix missing off_t define on FreeBSD
When removing the extra headers from rte_pci.h stdlib should have been removed instead of stdio, since off_t is missing for BSD builds when just including stdlib.h
Fixes 0dcba5256287 ("pci: remove unneeded includes in public header file")
Signed-off-by Bruce Richardson <[email protected]>
--- lib/librte_pci/rte_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_pci/rte_pci.h +1 -1
@@ -16,7 +16,7 @@extern "C" {#endif -#include <stdlib.h> +#include <stdio.h> #include <limits.h> #include <sys/queue.h> #include <inttypes.h>
Signature · 1 line
2.20.1
Thomas Monjalon
Applied16/03/2020 17:37, Bruce Richardson:
Quoted 8 lines
When removing the extra headers from
rte_pci.hstdlib should have been removed instead of stdio, sinceoff_tis missing for BSD builds when just includingstdlib.hFixes 0dcba5256287 ("pci: remove unneeded includes in public header file")Signed-off-by Bruce Richardson <[email protected]>
Sorry, I missed the failure seen in the community lab:
http://mails.dpdk.org/archives/test-report/2020-March/120862.html
Note: we should always wait for tests to be run.
Thank you for the quick fix.
Applied, thanks