Staging: drm_gem: Fix a misaligned comment block
Subsystems (2)
PATCH 1/1 Staging: drm_gem: Fix a misaligned comment block
Fix a checkpatch warning caused by a misaligned comment block.
--- drivers/gpu/drm/drm_gem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_gem.c +4 -4
@@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)return ;/* -* Must bump handle count first as this may be the last -* ref, in which case the object would disappear before we -* checked for a name -*/ +* Must bump handle count first as this may be the last +* ref, in which case the object would disappear before we +* checked for a name +*/ mutex_lock (&dev->object_name_lock);if (--obj->handle_count ==0 ) {
Signature · 1 line
2.20.1
Hi Igor,
First of all, thanks for your patch.
Just a few suggestions:
* Avoid using "Fix" in this sort of patch. Usually, we use "Fix" for indicating a bug fix or similar. You can read more about it here:
https://kernelnewbies.org/PatchPhilosophy
* Patch subject format may vary between subsystem, however, I recommend you to follow the instructions from this page:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
In summary, I just recommend you to improve the commit subject for your V2.
Thanks
Quoted 29 lines · Igor Matheus Andrade Torrente
Fix a checkpatch warning caused by a misaligned comment block.
Signed-off-by Igor Matheus Andrade Torrente <[email protected]>--- drivers/gpu/drm/drm_gem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_gem.c +4
-4@@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)return ;/* -* Must bump handle count first as this may be the last -* ref, in which case the object would disappear before we -* checked for a name -*/ +* Must bump handle count first as this may be the last +* ref, in which case the object would disappear before we +* checked for a name +*/ mutex_lock (&dev->object_name_lock);if (--obj->handle_count ==0 ) {Signature · 1 line
2.20.1
Signature · 2 lines
Rodrigo Siqueira https://siqueira.tech
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 1/1 drm: Alligne a comment block
Fix a checkpatch warning caused by a misaligned comment block.
--- drivers/gpu/drm/drm_gem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_gem.c +4 -4
@@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)return ;/* -* Must bump handle count first as this may be the last -* ref, in which case the object would disappear before we -* checked for a name -*/ +* Must bump handle count first as this may be the last +* ref, in which case the object would disappear before we +* checked for a name +*/ mutex_lock (&dev->object_name_lock);if (--obj->handle_count ==0 ) {
Signature · 1 line
2.20.1