Skip to contentSkip to conversation

PCI: endpoint: functions/pci-epf-test: Fix compiler error

PATCH In review Kishon Vijay Abraham I 2 participants 2 messages Mar 17, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: endpoint: functions/pci-epf-test: Fix compiler error

Commit 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments") was created before adding deferred core initialization support in commit 5e50ee27d4a5 ("PCI: pci-epf-test:
Add support to defer core initialization").
However since deferred core initialization was merged before re-designing MSI-X support, it caused the following compiler error.

drivers/pci/endpoint/functions/pci-epf-test.c:697:12: error: ‘epf_test’ undeclared (first use in this function);

Fix the compilation error here.

Fixes 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments")

---
Lorenzo,

This patch can be squashed with
"PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments"

Thanks
Kishon

 drivers/pci/endpoint/functions/pci-epf-test.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/endpoint/functions/pci-epf-test.c +1 -0
index eaf192be02bb..3b4cf7e2bc60 100644
@@ -660,6 +660,7 @@ static int pci_epf_test_set_bar(struct pci_epf *epf)
 
 static int pci_epf_test_core_init(struct pci_epf *epf)
 {
+	struct pci_epf_test *epf_test = epf_get_drvdata(epf);
 	struct pci_epf_header *header = epf->header;
 	const struct pci_epc_features *epc_features;
 	struct pci_epc *epc = epf->epc;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 11 lines · Kishon Vijay Abraham I

Commit 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments") was created before adding deferred core initialization support in commit 5e50ee27d4a5 ("PCI: pci-epf-test:
Add support to defer core initialization").
However since deferred core initialization was merged before re-designing MSI-X support, it caused the following compiler error.

drivers/pci/endpoint/functions/pci-epf-test.c:697:12: error: ‘epf_test’ undeclared (first use in this function);

Fix the compilation error here.

Quoted 8 lines
Fixes 812828eb5072 ("PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments")

---
Lorenzo,

This patch can be squashed with
"PCI: endpoint: Fix ->set_msix() to take BIR and offset as arguments"

Done, thank you very much.

Lorenzo

Quoted 21 lines

Thanks
Kishon

 drivers/pci/endpoint/functions/pci-epf-test.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/endpoint/functions/pci-epf-test.c +1 -0
index eaf192be02bb..3b4cf7e2bc60 100644
@@ -660,6 +660,7 @@ static int pci_epf_test_set_bar(struct pci_epf *epf)
 
 static int pci_epf_test_core_init(struct pci_epf *epf)
 {
+	struct pci_epf_test *epf_test = epf_get_drvdata(epf);
 	struct pci_epf_header *header = epf->header;
 	const struct pci_epc_features *epc_features;
 	struct pci_epc *epc = epf->epc;
Signature · 1 line
2.17.1