hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy
PATCH 1/1 hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy
ring->name is defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated strncpy with QEMU function.
This case prevented QEMU from compiling with --enable-sanitizers.
--- hw/rdma/vmw/pvrdma_dev_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
hw/rdma/vmw/pvrdma_dev_ring.c +2 -2
@@ -16,6 +16,7 @@#include "qemu/osdep.h" #include "hw/pci/pci.h" #include "cpu.h" +#include "qemu/cutils.h" #include "trace.h"
@@ -30,8 +31,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name, PCIDevice *dev,int i;int rc =0 ; -strncpy (ring->name, name,MAX_RING_NAME_SZ ); - ring->name[MAX_RING_NAME_SZ -1 ] =0 ; +pstrcpy (ring->name,MAX_RING_NAME_SZ , name); ring->dev = dev; ring->ring_state = ring_state; ring->max_elems = max_elems;
Signature · 1 line
2.24.1
Thanks,
Reviewed-by: Yuval Shaia <yuval.shaia.ml.gmail.com>
Quoted 36 lines · Julia Suvorova
ring->nameis defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated strncpy with QEMU function.
This case prevented QEMU from compiling with --enable-sanitizers.Signed-off-by Julia Suvorova <[email protected]>--- hw/rdma/vmw/pvrdma_dev_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/rdma/vmw/pvrdma_dev_ring.c +2
-2@@ -16,6 +16,7 @@#include "qemu/osdep.h" #include "hw/pci/pci.h" #include "cpu.h" +#include "qemu/cutils.h" #include "trace.h" @@ -30,8 +31,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name,PCIDevice *dev, int i;int rc =0 ; -strncpy (ring->name, name,MAX_RING_NAME_SZ ); - ring->name[MAX_RING_NAME_SZ -1 ] =0 ; +pstrcpy (ring->name,MAX_RING_NAME_SZ , name); ring->dev = dev; ring->ring_state = ring_state;ring->max_elems = max_elems;--
2.24.1
Quoted 8 lines · Julia Suvorova
ring->nameis defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated strncpy with QEMU function.
This case prevented QEMU from compiling with --enable-sanitizers.Signed-off-by Julia Suvorova <[email protected]>--- hw/rdma/vmw/pvrdma_dev_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Here is my equivalent patch <[email protected]> but feel free to merge this.
Quoted 6 lines · Stefan Hajnoczi
Quoted 4 lines · Julia Suvorova
ring->nameis defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated strncpy with QEMU function.
This case prevented QEMU from compiling with --enable-sanitizers.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Julia Suvorova <[email protected]>--- hw/rdma/vmw/pvrdma_dev_ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Here is my equivalent patch <[email protected]> but feel free to merge this.
Oops, sorry, I guess I didn't search carefully enough for the solution.
Quoted 1 line
Reviewed-by Stefan Hajnoczi <[email protected]>