Staging: qlge: Add a blank line after variable declarations.
PATCH v3 1/1 Staging: qlge: Add a blank line after variable declarations.
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
---
Changes in v3:
- Add a version change log.
Changes in v2:
- Applying only one logical change since this patch contained two different logical changes.
drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/staging/qlge/qlge_dbg.c +5 -1
@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)
@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );
@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;
@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);
@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" ); ---
2.20.1
Quoted 1 line · Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
I wasn't able to apply this patch. I have the impression that it lost its last line. Theer are only two lines after the + in the last hunk, and there should be three.
julia
Quoted 64 lines
Signed-off-by Sam Muhammed <[email protected]>---
Changes in v3:
- Add a version change log.Changes in v2:
- Applying only one logical change since this patch contained two different logical changes.drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/staging/qlge/qlge_dbg.c +5
-1@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" ); ---2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200319073721.3203-1-jane.pnx9%40gmail.com.
Quoted 11 lines · Julia Lawall
Quoted 1 line · Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
I wasn't able to apply this patch. I have the impression that it lost its last line. Theer are only two lines after the + in the last hunk, and there should be three.
julia
Oh, Iam afraid it's a blank line i removed as it was flagged as a trailing white-space by checkpatch.pl .
Okay sending a v4
Sam
Quoted 65 lines
Quoted 65 lines
Signed-off-by Sam Muhammed <[email protected]>---
Changes in v3:
- Add a version change log.Changes in v2:
- Applying only one logical change since this patch contained two different logical changes.drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/staging/qlge/qlge_dbg.c +5
-1@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" ); ---2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200319073721.3203-1-jane.pnx9%40gmail.com.
Quoted 10 lines · Sam Muhammed
Quoted 9 lines · Julia Lawall
Quoted 1 line · Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
I wasn't able to apply this patch. I have the impression that it lost its last line. Theer are only two lines after the + in the last hunk, and there should be three.
Quoted 6 lines
Quoted 2 lines
julia
Oh, Iam afraid it's a blank line i removed as it was flagged as a trailing white-space by checkpatch.pl .
Okay sending a v4
If you can reproduce the problem, you could inform the maintainer of checkpatch:
Joe Perches <[email protected]>
But I don't recall seeing such a problem, so be sure that it was not just something strange on your side.
julia
Quoted 71 lines
Sam
Quoted 65 lines
Quoted 65 lines
Signed-off-by Sam Muhammed <[email protected]>---
Changes in v3:
- Add a version change log.Changes in v2:
- Applying only one logical change since this patch contained two different logical changes.drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/staging/qlge/qlge_dbg.c +5
-1@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" ); ---2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200319073721.3203-1-jane.pnx9%40gmail.com.
Quoted 20 lines · Julia Lawall
Quoted 10 lines · Sam Muhammed
Quoted 9 lines · Julia Lawall
Quoted 1 line · Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
I wasn't able to apply this patch. I have the impression that it lost its last line. Theer are only two lines after the + in the last hunk, and there should be three.
Quoted 6 lines
Quoted 2 lines
julia
Oh, Iam afraid it's a blank line i removed as it was flagged as a trailing white-space by checkpatch.pl .
Okay sending a v4
Quoted 8 lines
If you can reproduce the problem, you could inform the maintainer of checkpatch:
Joe Perches <[email protected]>
But I don't recall seeing such a problem, so be sure that it was not just something strange on your side.
No, its also a coding style, the developer separates certain print messages from the rest of the code, e.g.:
```
int i;
pr_err("===================== Dumping ricb ===============\n");
pr_err("Dumping ricb stuff...\n");
pr_err("ricb->base_cq = %d\n", ricb->base_cq & 0x1f);
pr_err("ricb->flags = %s%s%s%s%s%s%s%s%s\n",
```it was there i should have left it, but i thought it was mistakenly added by me while adding "---" at the end.
Sam
Quoted 73 lines
julia
Quoted 71 lines
Sam
Quoted 65 lines
Quoted 65 lines
Signed-off-by Sam Muhammed <[email protected]>---
Changes in v3:
- Add a version change log.Changes in v2:
- Applying only one logical change since this patch contained two different logical changes.drivers/staging/qlge/qlge_dbg.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/staging/qlge/qlge_dbg.c +5
-1@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf, u32 offset, u32 count) { int i, status = 0; +for (i =0 ; i < count; i++, buf++) { status =ql_read_mpi_reg (qdev, offset + i, buf);if (status)@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev) {int i;u32 value; +for (i =0 ; i < qdev->intr_count; i++) {ql_write32 (qdev,INTR_EN , qdev->intr_context[i].intr_read_mask); value =ql_read32 (qdev,INTR_EN );@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev) {int i;u32 value; + i =ql_sem_spinlock (qdev,SEM_RT_IDX_MASK );if (i)return ;@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)void ql_dump_qdev (struct ql_adapter *qdev) {int i; +DUMP_QDEV_FIELD (qdev,"%lx" , flags);DUMP_QDEV_FIELD (qdev,"%p" , vlgrp);DUMP_QDEV_FIELD (qdev,"%p" , pdev);@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)void ql_dump_ricb (struct ricb *ricb) {int i; +pr_err ("===================== Dumping ricb ===============\n" );pr_err ("Dumping ricb stuff...\n" ); ---2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200319073721.3203-1-jane.pnx9%40gmail.com.