Skip to contentSkip to conversation

drm/i915/display: Increase the DDI idle timeout to 500us

PATCH In review Arkadiusz Hiler 2 participants 3 messages Mar 19, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/display: Increase the DDI idle timeout to 500us

Bspec says that we should timeout after 500us. Let's match this in the code. It may help with few of the timeouts we see here and there.

Bspec: 22243, 49190
Issue: https://gitlab.freedesktop.org/drm/intel/issues/1069

---
 drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_ddi.c +1 -1
index 73d0f4648c06..28650797fc2f 100644
@@ -1097,7 +1097,7 @@ static void intel_wait_ddi_buf_idle(struct drm_i915_private *dev_priv,
 	i915_reg_t reg = DDI_BUF_CTL(port);
 	int i;
 
-	for (i = 0; i < 16; i++) {
+	for (i = 0; i < 500; i++) {
 		udelay(1);
 		if (intel_de_read(dev_priv, reg) & DDI_BUF_IS_IDLE)
 			return;
Signature · 6 lines
2.24.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 2 lines · Arkadiusz Hiler

Bspec says that we should timeout after 500us. Let's match this in the code. It may help with few of the timeouts we see here and there.

Plese disregard. it's 500us when waiting on non-idle and only 8 (16 for BXT) for back to idle.

Signature · 6 lines
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 6 lines · Arkadiusz Hiler
Quoted 2 lines · Arkadiusz Hiler

Bspec says that we should timeout after 500us. Let's match this in the code. It may help with few of the timeouts we see here and there.

Plese disregard. it's 500us when waiting on non-idle and only 8 (16 for BXT) for back to idle.

Could probably convert to intel_de_wait_for...() regardless. 1ms vs. 16us isn't going to kill us in modeset code. The exact bspec value can be kept as a comment.

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx