Skip to contentSkip to conversation

staging: exfat: Fix checkpatch.pl camelcase issues

PATCH In review Aravind Ceyardass 3 participants 5 messages Mar 19, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: exfat: Fix checkpatch.pl camelcase issues

Fix ffsCamelCase function names and mixed case enums

---
 drivers/staging/exfat/TODO          |   1 -
 drivers/staging/exfat/exfat.h       |  12 +-
 drivers/staging/exfat/exfat_super.c | 222 ++++++++++++++--------------
 3 files changed, 117 insertions(+), 118 deletions(-)
drivers/staging/exfat/TODO +0 -1
index a283ce534cf4..51019e4431d8 100644
@@ -4,7 +4,6 @@ require more work than the average checkpatch cleanup...
 Note that some of these entries may not be bugs - they're things
 that need to be looked at, and *possibly* fixed.
 
-Clean up the ffsCamelCase function names.
 
 Fix (thing)->flags to not use magic numbers - multiple offenders
 
drivers/staging/exfat/exfat.h +6 -6
index 4a0a481fe010..92aac0d86249 100644
@@ -227,11 +227,11 @@ struct date_time_t {
 };
 
 struct vol_info_t {
-	u32      FatType;
-	u32      ClusterSize;
-	u32      NumClusters;
-	u32      FreeClusters;
-	u32      UsedClusters;
+	u32      fat_type;
+	u32      cluster_size;
+	u32      num_clusters;
+	u32      free_clusters;
+	u32      used_clusters;
 };
 
 /* directory structure */
@@ -257,7 +257,7 @@ struct file_id_t {
 struct dir_entry_t {
 	char name[MAX_NAME_LENGTH * MAX_CHARSET_SIZE];
 	u32 attr;
-	u64 Size;
+	u64 size;
 	u32 num_subdirs;
 	struct date_time_t create_timestamp;
 	struct date_time_t modify_timestamp;
drivers/staging/exfat/exfat_super.c +111 -111

572 lines not on this page · raw message

Signature · 1 line
2.21.1
maintainer
#1 lore raw
Quoted 8 lines · Aravind Ceyardass

Fix ffsCamelCase function names and mixed case enums

---
 drivers/staging/exfat/TODO          |   1 -
 drivers/staging/exfat/exfat.h       |  12 +-
 drivers/staging/exfat/exfat_super.c | 222 ++++++++++++++--------------
 3 files changed, 117 insertions(+), 118 deletions(-)

These files are not in linux-next, or in my tree, anymore.

Please always work against the latest development tree so you do not waste duplicated effort.

thanks,

greg k-h

#2 lore raw
In reply to Greg KH
Quoted 10 lines · Greg KH
Quoted 8 lines · Aravind Ceyardass

Fix ffsCamelCase function names and mixed case enums

---
 drivers/staging/exfat/TODO          |   1 -
 drivers/staging/exfat/exfat.h       |  12 +-
 drivers/staging/exfat/exfat_super.c | 222 ++++++++++++++--------------
 3 files changed, 117 insertions(+), 118 deletions(-)
Quoted 9 lines

These files are not in linux-next, or in my tree, anymore.

Please always work against the latest development tree so you do not waste duplicated effort.

thanks,

greg k-h

As a very beginner, I used the staging(git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git) tree based on what I read on kernelnewbies.org

What tree or branch should I use instead?

Thanks

Aravind

maintainer
#3 lore raw
Quoted 18 lines · Aravind Ceyardass
Quoted 15 lines · Greg KH
Quoted 8 lines · Aravind Ceyardass

Fix ffsCamelCase function names and mixed case enums

---
 drivers/staging/exfat/TODO          |   1 -
 drivers/staging/exfat/exfat.h       |  12 +-
 drivers/staging/exfat/exfat_super.c | 222 ++++++++++++++--------------
 3 files changed, 117 insertions(+), 118 deletions(-)

These files are not in linux-next, or in my tree, anymore.

Please always work against the latest development tree so you do not waste duplicated effort.

Quoted 8 lines
Quoted 4 lines

thanks,

greg k-h

As a very beginner, I used the staging(git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git) tree based on what I read on kernelnewbies.org

What tree or branch should I use instead?

That's the correct tree, but you probably forgot to use the staging-next branch, right?

hope this helps,

greg k-h