virtio-iommu: depend on PCI
PATCH 1/1 virtio-iommu: depend on PCI
The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change.
--- hw/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/virtio/Kconfig +1 -1
@@ -12,7 +12,7 @@ config VIRTIO_RNG config VIRTIO_IOMMU bool default y - depends on VIRTIO + depends on PCI && VIRTIO config VIRTIO_PCI bool
Signature · 1 line
2.24.1
Hi Paolo
Quoted 3 lines · Paolo Bonzini
The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change.
with the --- cleanup (?)
Thanks
Eric
Quoted 21 lines
Reported-by Gerd Hoffmann <[email protected]>Signed-off-by Paolo Bonzini <[email protected]>--- hw/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/virtio/Kconfig +1
-1@@ -12,7 +12,7 @@ config VIRTIO_RNG config VIRTIO_IOMMU bool default y - depends on VIRTIO + depends on PCI && VIRTIO config VIRTIO_PCI bool
Quoted 4 lines · Auger Eric
Quoted 3 lines
The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change.
with the --- cleanup (?)
Fails if PCI is not included but virtio-iommu is.
Paolo
Quoted 3 lines
Acked-by Eric Auger <[email protected]>Thanks
Quoted 16 lines · Paolo Bonzini
The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change.
Reported-by Gerd Hoffmann <[email protected]>Signed-off-by Paolo Bonzini <[email protected]>--- hw/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/virtio/Kconfig +0
-0
hw/virtio/Kconfig config VIRTIO_RNG · line 18
Quoted 8 lines
hw/virtio/Kconfig +1
-1@@ -12,7 +12,7 @@ config VIRTIO_RNG config VIRTIO_IOMMU bool default y - depends on VIRTIO + depends on PCI && VIRTIO config VIRTIO_PCI bool
I see hw/virtio/virtio-iommu-pci.c apart, what is the difference?
Hi Philippe,
Quoted 27 lines · Philippe Mathieu-Daudé
Quoted 15 lines · Paolo Bonzini
The virtio-iommu device attaches itself to a PCI bus, so it makes no sense to include it unless PCI is supported---and in fact compilation fails without this change.
Reported-by Gerd Hoffmann <[email protected]>Signed-off-by Paolo Bonzini <[email protected]>---
hw/virtio/Kconfig | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)hw/virtio/Kconfig +0
-0@@ -12,7 +12,7 @@ config VIRTIO_RNGQuoted 8 lines
config
VIRTIO_IOMMU
bool
default y
- depends on VIRTIO
+ depends on PCI && VIRTIO
configVIRTIO_PCI
boolReviewed-by Philippe Mathieu-Daudé <[email protected]>
Quoted 1 line
I see
hw/virtio/virtio-iommu-pci.capart, what is the difference?
That's the virtio-iommu pci proxy whereas TYPE_VIRTIO_IOMMU inherits from TYPE_VIRTIO_DEVICE.
The virtio-iommu device could also be instantiated directly as a TYPE_VIRTIO_IOMMU device but that's not the choice eventually made for machvirt.
Thanks
Eric