Skip to contentSkip to conversation

x86: acpi: Add I²C timings to Intel Merrifield platform

PATCH Superseded Andy Shevchenko 4 participants 5 messages Mar 20, 2020 – Mar 25, 2020 x86

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: acpi: Add I²C timings to Intel Merrifield platform

There is established way to provide I?C timings, or actually counters, to the OS via ACPI. Fill them for Intel Merrifield platform.

---
 .../asm/arch-tangier/acpi/southcluster.asl    | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +20 -0
index 95413c1112..aa1793b383 100644
@@ -250,6 +250,16 @@ Device (PCI0)
             Return (STA_VISIBLE)
         }
 
+        Name (SSCN, Package ()
+        {
+            0x02F8, 0x037B, Zero,
+        })
+
+        Name (FMCN, Package ()
+        {
+            0x0087, 0x010A, Zero,
+        })
+
         Name (RBUF, ResourceTemplate()
         {
             FixedDMA(0x0009, 0x0000, Width32bit, )
@@ -270,6 +280,16 @@ Device (PCI0)
         {
             Return (STA_VISIBLE)
         }
+
+        Name (SSCN, Package ()
+        {
+            0x02F8, 0x037B, Zero,
+        })
+
+        Name (FMCN, Package ()
+        {
+            0x0087, 0x010A, Zero,
+        })
     }
 
     Device (GPIO)
Signature · 1 line
2.25.1
#2 lore raw
In reply to Andy Shevchenko
Quoted 9 lines · Andy Shevchenko

There is established way to provide I?C timings, or actually counters, to the OS via ACPI. Fill them for Intel Merrifield platform.

---
 .../asm/arch-tangier/acpi/southcluster.asl    | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

applied to u-boot-x86, thanks!

#3 lore raw
Quoted 7 lines · Bin Meng
Quoted 4 lines · Andy Shevchenko

There is established way to provide I?C timings, or actually counters, to the OS via ACPI. Fill them for Intel Merrifield platform.

Quoted 7 lines
Quoted 5 lines
---
 .../asm/arch-tangier/acpi/southcluster.asl    | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

applied to u-boot-x86, thanks!

There is a v2 of it. Should I send a fix up or you can replace?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

Hi Andy,

Quoted 15 lines · Andy Shevchenko
Quoted 13 lines · Bin Meng
Quoted 9 lines · Andy Shevchenko

There is established way to provide I?C timings, or actually counters, to the OS via ACPI. Fill them for Intel Merrifield platform.

---
 .../asm/arch-tangier/acpi/southcluster.asl    | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
Quoted 3 lines
Quoted 1 line

applied to u-boot-x86, thanks!

There is a v2 of it. Should I send a fix up or you can replace?

Sorry I replied the wrong email. I did apply the v2 patch, and manually added Simon's RB tag.

Regards,
Bin