Skip to contentSkip to conversation

Btrfs: fix removal of raid[56|1c34} incompat flags after removing block group

PATCH In review [email protected] 3 participants 7 messages Mar 20, 2020 – Mar 24, 2020 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Btrfs: fix removal of raid[56|1c34} incompat flags after removing block group

From: Filipe Manana <[email protected]>

We are incorrectly dropping the raid56 and raid1c34 incompat flags when there are still raid56 and raid1c34 block groups, not when we do not any of those anymore. The logic just got unintentionally broken after adding the support for the raid1c34 modes.

Fix this by clear the flags only if we do not have block groups with the respective profiles.

Fixes 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")
---
 fs/btrfs/block-group.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/btrfs/block-group.c +2 -2
index 7b003a2df79e..b8f39a679064 100644
@@ -856,9 +856,9 @@ static void clear_incompat_bg_bits(struct btrfs_fs_info *fs_info, u64 flags)
 				found_raid1c34 = true;
 			up_read(&sinfo->groups_sem);
 		}
-		if (found_raid56)
+		if (!found_raid56)
 			btrfs_clear_fs_incompat(fs_info, RAID56);
-		if (found_raid1c34)
+		if (!found_raid1c34)
 			btrfs_clear_fs_incompat(fs_info, RAID1C34);
 	}
 }
Signature · 1 line
2.25.0
#1 lore raw
Quoted 7 lines · On Fri, Mar 20, 2020 at 06:43:48PM +0000, [email protected] wrote:

From: Filipe Manana <[email protected]>

We are incorrectly dropping the raid56 and raid1c34 incompat flags when there are still raid56 and raid1c34 block groups, not when we do not any of those anymore. The logic just got unintentionally broken after adding the support for the raid1c34 modes.

Quoted 5 lines

Fix this by clear the flags only if we do not have block groups with the respective profiles.

Fixes 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")

Thanks, that was a stupid mistake. As it's a regression fix, I'll send as an rc fix.

Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]
Quoted 7 lines · On 2020/3/21 上午2:43, [email protected] wrote:

From: Filipe Manana <[email protected]>

We are incorrectly dropping the raid56 and raid1c34 incompat flags when there are still raid56 and raid1c34 block groups, not when we do not any of those anymore. The logic just got unintentionally broken after adding the support for the raid1c34 modes.

Quoted 5 lines

Fix this by clear the flags only if we do not have block groups with the respective profiles.

Fixes 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")

The fix is OK.

Just interesting do we really need to remove such flags? To me, keep the flag is completely sane.

Thanks,
Qu

Quoted 21 lines
---
 fs/btrfs/block-group.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/btrfs/block-group.c +2 -2
index 7b003a2df79e..b8f39a679064 100644
@@ -856,9 +856,9 @@ static void clear_incompat_bg_bits(struct btrfs_fs_info *fs_info, u64 flags)
 				found_raid1c34 = true;
 			up_read(&sinfo->groups_sem);
 		}
-		if (found_raid56)
+		if (!found_raid56)
 			btrfs_clear_fs_incompat(fs_info, RAID56);
-		if (found_raid1c34)
+		if (!found_raid1c34)
 			btrfs_clear_fs_incompat(fs_info, RAID1C34);
 	}
 }
#3 lore raw
Quoted 16 lines · Qu Wenruo
Quoted 7 lines · On 2020/3/21 上午2:43, [email protected] wrote:

From: Filipe Manana <[email protected]>

We are incorrectly dropping the raid56 and raid1c34 incompat flags when there are still raid56 and raid1c34 block groups, not when we do not any of those anymore. The logic just got unintentionally broken after adding the support for the raid1c34 modes.

Quoted 5 lines

Fix this by clear the flags only if we do not have block groups with the respective profiles.

Fixes 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")
Quoted 6 lines

The fix is OK.

Just interesting do we really need to remove such flags? To me, keep the flag is completely sane.

So you'd suggest to keep a flag for a feature that's not used on the filesystem so it's not possible to mount the filesystem on an older kernel?

#4 lore raw
Quoted 19 lines · David Sterba
Quoted 18 lines · Qu Wenruo
Quoted 7 lines · On 2020/3/21 上午2:43, [email protected] wrote:

From: Filipe Manana <[email protected]>

We are incorrectly dropping the raid56 and raid1c34 incompat flags when there are still raid56 and raid1c34 block groups, not when we do not any of those anymore. The logic just got unintentionally broken after adding the support for the raid1c34 modes.

Quoted 5 lines

Fix this by clear the flags only if we do not have block groups with the respective profiles.

Fixes 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")

The fix is OK.

Quoted 9 lines
Quoted 4 lines

Just interesting do we really need to remove such flags? To me, keep the flag is completely sane.

So you'd suggest to keep a flag for a feature that's not used on the filesystem so it's not possible to mount the filesystem on an older kernel?

If user is using this feature, they aren't expecting mounting it on older kernel either.

#5 lore raw
Quoted 27 lines · Qu Wenruo
Quoted 24 lines · David Sterba
Quoted 22 lines · Qu Wenruo
Quoted 7 lines · On 2020/3/21 上午2:43, [email protected] wrote:

From: Filipe Manana <[email protected]>

We are incorrectly dropping the raid56 and raid1c34 incompat flags when there are still raid56 and raid1c34 block groups, not when we do not any of those anymore. The logic just got unintentionally broken after adding the support for the raid1c34 modes.

Quoted 5 lines

Fix this by clear the flags only if we do not have block groups with the respective profiles.

Fixes 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")

The fix is OK.

Just interesting do we really need to remove such flags? To me, keep the flag is completely sane.

Quoted 6 lines
Quoted 4 lines

So you'd suggest to keep a flag for a feature that's not used on the filesystem so it's not possible to mount the filesystem on an older kernel?

If user is using this feature, they aren't expecting mounting it on older kernel either.

Before we go in a loop throwing single statements, let me take a broader look.

First thing, the removal of incompat bit was asked for by users, Hugo is as reporter in the commit 6d58a55a894e863.

https://lore.kernel.org/linux-btrfs/[email protected]/

" We've had a couple of cases in the past where people have tried out
a new feature on a new kernel, then turned it off again and not been able to go back to an earlier kernel. Particularly in this case, I can see people being surprised at the trapdoor. "I don't have any RAID13C on this filesystem: why can't I go back to 5.2?"

That itself is a strong sign to me that there's a need or usecase or a good idea. Though we have a lot of them, this one was simple to implement and made sense to me. For the raid56 it's a simple check, unlike for other features that would need to go through significant portion of metadata.

Booting older kernel might sound like, why would anybody want to do that, but if the bit is there preventing boot/mount, then it's an unnecessary complication. In rescue environmnents it's gold.

Usability improvements tend to be boring from code POV but it is something that users can observe and make use of.

#6 lore raw
Quoted 55 lines · David Sterba
Quoted 27 lines · Qu Wenruo
Quoted 24 lines · David Sterba
Quoted 22 lines · Qu Wenruo
Quoted 7 lines · On 2020/3/21 上午2:43, [email protected] wrote:

From: Filipe Manana <[email protected]>

We are incorrectly dropping the raid56 and raid1c34 incompat flags when there are still raid56 and raid1c34 block groups, not when we do not any of those anymore. The logic just got unintentionally broken after adding the support for the raid1c34 modes.

Quoted 5 lines

Fix this by clear the flags only if we do not have block groups with the respective profiles.

Fixes 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")

The fix is OK.

Just interesting do we really need to remove such flags? To me, keep the flag is completely sane.

Quoted 6 lines
Quoted 4 lines

So you'd suggest to keep a flag for a feature that's not used on the filesystem so it's not possible to mount the filesystem on an older kernel?

If user is using this feature, they aren't expecting mounting it on older kernel either.

Before we go in a loop throwing single statements, let me take a broader look.

First thing, the removal of incompat bit was asked for by users, Hugo is as reporter in the commit 6d58a55a894e863.

https://lore.kernel.org/linux-btrfs/[email protected]/

" We've had a couple of cases in the past where people have tried out
a new feature on a new kernel, then turned it off again and not been able to go back to an earlier kernel. Particularly in this case, I can see people being surprised at the trapdoor. "I don't have any RAID13C on this filesystem: why can't I go back to 5.2?"

That itself is a strong sign to me that there's a need or usecase or a good idea. Though we have a lot of them, this one was simple to implement and made sense to me. For the raid56 it's a simple check, unlike for other features that would need to go through significant portion of metadata.

Quoted 7 lines

Booting older kernel might sound like, why would anybody want to do that, but if the bit is there preventing boot/mount, then it's an unnecessary complication. In rescue environmnents it's gold.

Usability improvements tend to be boring from code POV but it is something that users can observe and make use of.

Thanks for the full picture.

That makes sense.

Thanks,
Qu