staging: greybus: tools: Fix RETURN_VOID warnings
PATCH 1/1 staging: greybus: tools: Fix RETURN_VOID warnings
Fix 'void function return statements are not generally useful' checkpatch.pl warnings.
--- drivers/staging/greybus/tools/loopback_test.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/greybus/tools/loopback_test.c +0 -3
@@ -855,11 +855,8 @@ void loopback_run(struct loopback_test *t)log_results (t); -return ; - err:printf ("Error running test\n" ); -return ; }static int sanity_check (struct loopback_test *t)
Signature · 1 line
2.17.1
Quoted 13 lines · Simran Singhal
Fix 'void function return statements are not generally useful' checkpatch.pl warnings.
Signed-off-by Simran Singhal <[email protected]>--- drivers/staging/greybus/tools/loopback_test.c | 3 --- 1 file changed, 3 deletions(-)drivers/staging/greybus/tools/loopback_test.c +0
-0
drivers/staging/greybus/tools/loopback_test.c void loopback_run(struct loopback_test *t) · line 859
Quoted 5 lines
drivers/staging/greybus/tools/loopback_test.c +0
-2@@ -855,11 +855,8 @@ void loopback_run(struct loopback_test *t)log_results (t); -return ; -
This is not correct. Please think about what you are doing.
julia
Quoted 14 lines
drivers/staging/greybus/tools/loopback_test.c +0
-2err:printf ("Error running test\n" ); -return ; }static int sanity_check (struct loopback_test *t) --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322133423.GA27425%40simran-Inspiron-5558.
Quoted 19 lines · Julia Lawall
Review
Quoted 9 lines · Simran Singhal
Fix 'void function return statements are not generally useful' checkpatch.pl warnings.
Signed-off-by Simran Singhal <[email protected]>--- drivers/staging/greybus/tools/loopback_test.c | 3 --- 1 file changed, 3 deletions(-)(quoted diff) +0
-0
b/drivers/staging/greybus/tools/loopback_test.cQuoted 5 lines
index
ba6f905f26fa..78333fb45b70100644drivers/staging/greybus/tools/loopback_test.c +0
-0@@ -855,11 +855,8 @@ void loopback_run(struct loopback_test *t)
Quoted 7 lines
drivers/staging/greybus/tools/loopback_test.c void loopback_run(struct loopback_test *t) · line 859
Quoted 4 lines
drivers/staging/greybus/tools/loopback_test.c +0
-2log_results (t); -return ; -This is not correct. Please think about what you are doing.
Yes, what I did is wrong. I should not have remove the return statement before err as it will let the statements below err to execute when they should not.
I am sorry for this patch and I request maintainers to drop this patch.
Quoted 22 lines
julia
Quoted 11 lines
drivers/staging/greybus/tools/loopback_test.c +0
-2err:printf ("Error running test\n" ); -return ; }static int sanity_check (struct loopback_test *t) --2.17.1
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20200322133423.GA27425%40simran-Inspiron-5558
.Quoted 1 line