staging: hp100: Add space around + operator and remove space around pointers
PATCH 1/1 staging: hp100: Add space around + operator and remove space around pointers
Add space around + operator and remove space after * in pointer declaration to improve code readability
Reported by checkpatch.pl
Signed-off-by Soumyajit Deb <[email protected]>
--- drivers/staging/hp/hp100.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/hp/hp100.c +6 -6
@@ -119,7 +119,7 @@#define HP100_REGION_SIZE 0x20/* for ioports */ #define HP100_SIG_LEN 8/* same as EISA_SIG_LEN */ -#define HP100_MAX_PACKET_SIZE (1536+4) +#define HP100_MAX_PACKET_SIZE (1536 + 4)#define HP100_MIN_PACKET_SIZE 60#ifndef HP100_DEFAULT_RX_RATIO
@@ -246,11 +246,11 @@ static void hp100_BM_shutdown(struct net_device *dev);static void hp100_mmuinit (struct net_device *dev);static void hp100_init_pdls (struct net_device *dev);static int hp100_init_rxpdl (struct net_device *dev, - registerhp100_ring_t * ringptr, - registeru_int * pdlptr); + registerhp100_ring_t *ringptr, + registeru_int *pdlptr);static int hp100_init_txpdl (struct net_device *dev, - registerhp100_ring_t * ringptr, - registeru_int * pdlptr); + registerhp100_ring_t *ringptr, + registeru_int *pdlptr);static void hp100_rxfill (struct net_device *dev);static void hp100_hwinit (struct net_device *dev);static void hp100_clean_txring (struct net_device *dev);
@@ -264,7 +264,7 @@ static void hp100_RegisterDump(struct net_device *dev);* because it was properly DMA allocated via pci_alloc_consistent(), * so we just need to "retrieve" the original mapping to bus/phys/dma * address - Jean II */ -static inline dma_addr_t virt_to_whatever (struct net_device *dev,u32 * ptr) +static inline dma_addr_t virt_to_whatever (struct net_device *dev,u32 *ptr) {struct hp100_private *lp =netdev_priv (dev);return ((u_long ) ptr) + lp->whatever_offset;
Signature · 1 line
2.17.1
Quoted 3 lines · Soumyajit Deb
Add space around + operator and remove space after * in pointer declaration to improve code readability
Reported by checkpatch.pl
Did you send the same thing twice?
julia
Quoted 52 lines
Signed-off-by Soumyajit Deb <[email protected]>--- drivers/staging/hp/hp100.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/staging/hp/hp100.c +6
-7@@ -119,7 +119,7 @@#define HP100_REGION_SIZE 0x20/* for ioports */ #define HP100_SIG_LEN 8/* same as EISA_SIG_LEN */ -#define HP100_MAX_PACKET_SIZE (1536+4) +#define HP100_MAX_PACKET_SIZE (1536 + 4)#define HP100_MIN_PACKET_SIZE 60#ifndef HP100_DEFAULT_RX_RATIO @@ -246,11 +246,11 @@ static void hp100_BM_shutdown(struct net_device *dev);static void hp100_mmuinit (struct net_device *dev);static void hp100_init_pdls (struct net_device *dev);static int hp100_init_rxpdl (struct net_device *dev, - registerhp100_ring_t * ringptr, - registeru_int * pdlptr); + registerhp100_ring_t *ringptr, + registeru_int *pdlptr);static int hp100_init_txpdl (struct net_device *dev, - registerhp100_ring_t * ringptr, - registeru_int * pdlptr); + registerhp100_ring_t *ringptr, + registeru_int *pdlptr);static void hp100_rxfill (struct net_device *dev);static void hp100_hwinit (struct net_device *dev);static void hp100_clean_txring (struct net_device *dev);@@ -264,7 +264,7 @@ static void hp100_RegisterDump(struct net_device *dev);* because it was properly DMA allocated via pci_alloc_consistent(), * so we just need to "retrieve" the original mapping to bus/phys/dma * address - Jean II */ -static inline dma_addr_t virt_to_whatever (struct net_device *dev,u32 * ptr) +static inline dma_addr_t virt_to_whatever (struct net_device *dev,u32 *ptr) {struct hp100_private *lp =netdev_priv (dev);return ((u_long ) ptr) + lp->whatever_offset; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322134852.GA30778%40ubuntu.