dm-integrity: fix a crash with unusually large tag size
Mikulas Patocka
maintainerPATCH 1/7 dm-integrity: fix a crash with unusually large tag size
If the user specifies tag size larger than HASH_MAX_DIGESTSIZE, there's a crash in integrity_metadata.
Signed-off-by Mikulas Patocka <[email protected]>
--- drivers/md/dm-integrity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/md/dm-integrity.c +2 -2
@@ -1519,7 +1519,7 @@ static void integrity_metadata(struct wostruct bio *bio =dm_bio_from_per_bio_data (dio,sizeof (struct dm_integrity_io ));char *checksums;unsigned extra_space =unlikely (digest_size > ic->tag_size) ? digest_size - ic->tag_size :0 ; -char checksums_onstack[HASH_MAX_DIGESTSIZE ]; +char checksums_onstack[max ((size_t )HASH_MAX_DIGESTSIZE ,MAX_TAG_SIZE )];unsigned sectors_to_process = dio->range.n_sectors;sector_t sector = dio->range.logical_sector;
@@ -1748,7 +1748,7 @@ retry_kmap: }while (++s < ic->sectors_per_block);#ifdef INTERNAL_VERIFY if (ic->internal_hash) { -char checksums_onstack[max (HASH_MAX_DIGESTSIZE ,MAX_TAG_SIZE )]; +char checksums_onstack[max ((size_t )HASH_MAX_DIGESTSIZE ,MAX_TAG_SIZE )];integrity_sector_checksum (ic, logical_sector, mem + bv.bv_offset, checksums_onstack);if (unlikely (memcmp (checksums_onstack,journal_entry_tag (ic, je), ic->tag_size))) {