Skip to contentSkip to conversation

staging: hp100: line over 80 characters

PATCH In review Gokce Kuler 3 participants 3 messages Mar 23, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: hp100: line over 80 characters

Add a spaces character before that for correct syntax.

---
 drivers/staging/hp/hp100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/hp/hp100.c +1 -1
index 32a9e29..280b5a0 100644
@@ -550,7 +550,7 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
 			local_mode = 3;
 		} else if (chip == HP100_CHIPID_LASSEN &&
 			   (lsw & (HP100_BM_WRITE | HP100_BM_READ)) ==
-			   (HP100_BM_WRITE | HP100_BM_READ)) {
+			    (HP100_BM_WRITE | HP100_BM_READ)) {
 			/* Conversion to new PCI API :
 			 * I don't have the doc, but I assume that the card
 			 * can map the full 32bit address space.
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 1 line · Gokce Kuler

Add a spaces character before that for correct syntax.

Does not match the subject line :(

#2 lore raw
In reply to Gokce Kuler
Quoted 1 line · Gokce Kuler

Add a spaces character before that for correct syntax.

I think Greg already noted that the subject line doesn't match the log message or what is done. Also, adding spaces won't affect the correctness of the syntax. It can make the code more readable.

julia

Quoted 27 lines
---
 drivers/staging/hp/hp100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/hp/hp100.c +1 -2
index 32a9e29..280b5a0 100644
@@ -550,7 +550,7 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
 			local_mode = 3;
 		} else if (chip == HP100_CHIPID_LASSEN &&
 			   (lsw & (HP100_BM_WRITE | HP100_BM_READ)) ==
-			   (HP100_BM_WRITE | HP100_BM_READ)) {
+			    (HP100_BM_WRITE | HP100_BM_READ)) {
 			/* Conversion to new PCI API :
 			 * I don't have the doc, but I assume that the card
 			 * can map the full 32bit address space.
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200323002450.GA15867%40siyah2.