Skip to contentSkip to conversation

meta-arm-bsp: a5ds: Remove WIC references

PATCH In review Jon Mason 4 participants 8 messages Mar 23, 2020

lore
Share & tools
lore

Jon Mason

author
#0 lore raw

PATCH 1/2 meta-arm-bsp: a5ds: Remove WIC references

The current WIC references in the A5DS config file are causing a build break, due to not being defined. These WIC files should be revisited once the IOTA distro is present.

Change-Id Ied2cd6f768625d18150ed60bd5fe317e06c7f48a
---
 meta-arm-bsp/conf/machine/a5ds.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/machine/a5ds.conf +1 -1
index 136105b..fa7d88e 100644
@@ -14,7 +14,7 @@ EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a u-boot"
 
 SERIAL_CONSOLES = "115200;ttyAMA0"
 
-IMAGE_FSTYPES += "tar.bz2 wic wic.nopt cpio.gz"
+IMAGE_FSTYPES += "tar.bz2 cpio.gz"
 
 EXTRA_IMAGEDEPENDS += "u-boot"
 
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/2 meta-arm-bsp: add layer dependencies

meta-arm-bsp has dependencies on other layers, which are not being represented in the layers.conf file. This causes build breaks when using tools like bitbake-layers layerindex-fetch, as it will not fetch the depencies properly. Currently, the dependencies on other layers are:
* core => u-boot, linux, etc
* openembedded-layer (meta-oe) => haveged
* meta-arm => trusted-firmware-a

Change-Id Icafc2f1c55a6138172706bb4b99e9dc59904cad4
---
 meta-arm-bsp/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/layer.conf +1 -1
index 931b54c..0632ba3 100644
@@ -9,7 +9,7 @@ BBFILE_COLLECTIONS += "meta-arm-bsp"
 BBFILE_PATTERN_meta-arm-bsp = "^${LAYERDIR}/"
 BBFILE_PRIORITY_meta-arm-bsp = "6"
 
-LAYERDEPENDS_meta-arm-bsp = "core"
+LAYERDEPENDS_meta-arm-bsp = "core openembedded-layer meta-arm"
 LAYERSERIES_COMPAT_meta-arm-bsp = "warrior zeus"
 
 # We have patches for xen but meta-virtualization might not be there so filter
Signature · 1 line
2.17.1
Acked-by on v1 1/2
#4 lore raw
In reply to Jon Mason

On 23 Mar 2020, at 14:21, Jon Mason via Lists.Yoctoproject.Org<http://Lists.Yoctoproject.Org> <[email protected]<mailto:[email protected]>> wrote:

The current WIC references in the A5DS config file are causing a build break, due to not being defined. These WIC files should be revisited once the IOTA distro is present.

---
meta-arm-bsp/conf/machine/a5ds.conf | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/machine/a5ds.conf +0 -0
index 136105b..fa7d88e 100644
@@ -14,7 +14,7 @@ EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a u-boot"
 

SERIAL_CONSOLES = "115200;ttyAMA0"

-IMAGE_FSTYPES += "tar.bz2 wic wic.nopt cpio.gz"
+IMAGE_FSTYPES += "tar.bz2 cpio.gz"

EXTRA_IMAGEDEPENDS += "u-boot"

--
2.17.1

Acked-by on v1 2/2
#2 lore raw

Re: [meta-arm] [PATCH 2/2] meta-arm-bsp: add layer dependencies

In reply to Jon Mason

On 23 Mar 2020, at 14:21, Jon Mason via Lists.Yoctoproject.Org<http://Lists.Yoctoproject.Org> <[email protected]<mailto:[email protected]>> wrote:

meta-arm-bsp has dependencies on other layers, which are not being represented in the layers.conf file. This causes build breaks when using tools like bitbake-layers layerindex-fetch, as it will not fetch the depencies properly. Currently, the dependencies on other layers are:
* core => u-boot, linux, etc
* openembedded-layer (meta-oe) => haveged
* meta-arm => trusted-firmware-a

---
meta-arm-bsp/conf/layer.conf | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/layer.conf +0 -0
index 931b54c..0632ba3 100644
@@ -9,7 +9,7 @@ BBFILE_COLLECTIONS += "meta-arm-bsp"

BBFILE_PATTERN_meta-arm-bsp = "^${LAYERDIR}/"
BBFILE_PRIORITY_meta-arm-bsp = "6"

-LAYERDEPENDS_meta-arm-bsp = "core" +LAYERDEPENDS_meta-arm-bsp = "core openembedded-layer meta-arm" LAYERSERIES_COMPAT_meta-arm-bsp = "warrior zeus"

# We have patches for xen but meta-virtualization might not be there so filter --
2.17.1

Acked-by Bertrand Marquis Acked-by
#3 lore raw

Re: [meta-arm] [PATCH 2/2] meta-arm-bsp: add layer dependencies

On 23 Mar 2020, at 14:21, Jon Mason via http://Lists.Yoctoproject.Org <mailto:[email protected]> wrote:

meta-arm-bsp has dependencies on other layers, which are not being represented in the layers.conf file.  This causes build breaks when using tools like bitbake-layers layerindex-fetch, as it will not fetch the depencies properly.  Currently, the dependencies on other layers are:
* core => u-boot, linux, etc
* openembedded-layer (meta-oe) => haveged
* meta-arm => trusted-firmware-a

Change-Id Icafc2f1c55a6138172706bb4b99e9dc59904cad4

---
meta-arm-bsp/conf/layer.conf | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/layer.conf +0 -0
index 931b54c..0632ba3 100644
@@ -9,7 +9,7 @@ BBFILE_COLLECTIONS += "meta-arm-bsp"

BBFILE_PATTERN_meta-arm-bsp = "^${LAYERDIR}/"
BBFILE_PRIORITY_meta-arm-bsp = "6"

-LAYERDEPENDS_meta-arm-bsp = "core" +LAYERDEPENDS_meta-arm-bsp = "core openembedded-layer meta-arm" LAYERSERIES_COMPAT_meta-arm-bsp = "warrior zeus"

# We have patches for xen but meta-virtualization might not be there so filter

Signature · 1 line
2.17.1
Acked-by Bertrand Marquis Acked-by
#5 lore raw
In reply to Bertrand Marquis

On 23 Mar 2020, at 14:21, Jon Mason via http://Lists.Yoctoproject.Org <mailto:[email protected]> wrote:

The current WIC references in the A5DS config file are causing a build break, due to not being defined.  These WIC files should be revisited once the IOTA distro is present.

Change-Id Ied2cd6f768625d18150ed60bd5fe317e06c7f48a

---
meta-arm-bsp/conf/machine/a5ds.conf | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/machine/a5ds.conf +0 -0
index 136105b..fa7d88e 100644
@@ -14,7 +14,7 @@ EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a u-boot"
 

SERIAL_CONSOLES = "115200;ttyAMA0"

-IMAGE_FSTYPES += "tar.bz2 wic wic.nopt cpio.gz"
+IMAGE_FSTYPES += "tar.bz2 cpio.gz"

EXTRA_IMAGEDEPENDS += "u-boot"

Signature · 1 line
2.17.1
#6 lore raw
In reply to Bertrand Marquis
Quoted 5 lines · Bertrand Marquis

On 23 Mar 2020, at 14:21, Jon Mason via Lists.Yoctoproject.Org <[email protected]> wrote:

Quoted 8 lines

The current WIC references in the A5DS config file are causing a build break, due to not being defined. These WIC files should be revisited once the IOTA distro is present.

Change-Id Ied2cd6f768625d18150ed60bd5fe317e06c7f48a

Thanks Bertrand. I think you mean Reviewed-by though. Per the Linux kernel process (which I believe Yocto/OE follows):

From Documentation/SubmittingPatches

<snip>
Acked-by: is often used by the maintainer of the affected code when that maintainer neither contributed to nor forwarded the patch. </snip>

<snip>
Reviewed-by:, instead, indicates that the patch has been reviewed and found acceptable according to the Reviewer's Statement:

Reviewer's statement of oversight

By offering my Reviewed-by: tag, I state that:

(a) I have carried out a technical review of this patch to evaluate its appropriateness and readiness for inclusion into the mainline kernel.

(b) Any problems, concerns, or questions relating to the patch have been communicated back to the submitter. I am satisfied with the submitter's response to my comments.

(c) While there may be things that could be improved with this submission, I believe that it is, at this time, (1) a worthwhile modification to the kernel, and (2) free of known issues which would argue against its inclusion.

(d) While I have reviewed the patch and believe it to be sound, I do not (unless explicitly stated elsewhere) make any warranties or guarantees that it will achieve its stated purpose or function properly in any given situation.

A Reviewed-by tag is a statement of opinion that the patch is an appropriate modification of the kernel without any remaining serious technical issues. Any interested reviewer (who has done the work) can offer a Reviewed-by tag for a patch. This tag serves to give credit to reviewers and to inform maintainers of the degree of review which has been done on the patch. Reviewed-by: tags, when supplied by reviewers known to understand the subject area and to perform thorough reviews, will normally increase the likelihood of your patch getting into the kernel. </snip>

So in this case, probably the only "Acked-by" would be the author of the original patch, Rui Silva. Everyone else should do a Reviewed-by.

Thanks,
Jon

Quoted 24 lines

---
meta-arm-bsp/conf/machine/a5ds.conf | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/machine/a5ds.conf +0 -0
index 136105b..fa7d88e 100644
@@ -14,7 +14,7 @@ EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a u-boot"
 

SERIAL_CONSOLES = "115200;ttyAMA0"

meta-arm-bsp/conf/machine/a5ds.conf +1 -1
-IMAGE_FSTYPES += "tar.bz2 wic wic.nopt cpio.gz"
+IMAGE_FSTYPES += "tar.bz2 cpio.gz"

EXTRA_IMAGEDEPENDS += "u-boot"

--
2.17.1

#7 lore raw

On 23 Mar 2020, at 14:41, Jon Mason via Lists.Yoctoproject.Org<http://Lists.Yoctoproject.Org> <[email protected]<mailto:[email protected]>> wrote:

On Mon, Mar 23, 2020 at 10:27 AM Bertrand Marquis <[email protected]<mailto:[email protected]>> wrote:

On 23 Mar 2020, at 14:21, Jon Mason via Lists.Yoctoproject.Org<http://lists.yoctoproject.org/> <[email protected]<mailto:[email protected]>> wrote:

The current WIC references in the A5DS config file are causing a build break, due to not being defined. These WIC files should be revisited once the IOTA distro is present.

Change-Id Ied2cd6f768625d18150ed60bd5fe317e06c7f48a

Thanks Bertrand. I think you mean Reviewed-by though. Per the Linux kernel process (which I believe Yocto/OE follows):

From Documentation/SubmittingPatches

<snip>
Acked-by: is often used by the maintainer of the affected code when that maintainer neither contributed to nor forwarded the patch. </snip>

<snip>
Reviewed-by:, instead, indicates that the patch has been reviewed and found acceptable according to the Reviewer's Statement:

Reviewer's statement of oversight

By offering my Reviewed-by: tag, I state that:

(a) I have carried out a technical review of this patch to evaluate its appropriateness and readiness for inclusion into the mainline kernel.

(b) Any problems, concerns, or questions relating to the patch have been communicated back to the submitter. I am satisfied with the submitter's response to my comments.

(c) While there may be things that could be improved with this submission, I believe that it is, at this time, (1) a worthwhile modification to the kernel, and (2) free of known issues which would argue against its inclusion.

(d) While I have reviewed the patch and believe it to be sound, I do not (unless explicitly stated elsewhere) make any warranties or guarantees that it will achieve its stated purpose or function properly in any given situation.

A Reviewed-by tag is a statement of opinion that the patch is an appropriate modification of the kernel without any remaining serious technical issues. Any interested reviewer (who has done the work) can offer a Reviewed-by tag for a patch. This tag serves to give credit to reviewers and to inform maintainers of the degree of review which has been done on the patch. Reviewed-by: tags, when supplied by reviewers known to understand the subject area and to perform thorough reviews, will normally increase the likelihood of your patch getting into the kernel. </snip>

So in this case, probably the only "Acked-by" would be the author of the original patch, Rui Silva. Everyone else should do a Reviewed-by.

Agree
Bertrand

Thanks,
Jon

---
meta-arm-bsp/conf/machine/a5ds.conf | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-bsp/conf/machine/a5ds.conf +0 -0
index 136105b..fa7d88e 100644
@@ -14,7 +14,7 @@ EXTRA_IMAGEDEPENDS += "virtual/trusted-firmware-a u-boot"
 

SERIAL_CONSOLES = "115200;ttyAMA0"

-IMAGE_FSTYPES += "tar.bz2 wic wic.nopt cpio.gz"
+IMAGE_FSTYPES += "tar.bz2 cpio.gz"

EXTRA_IMAGEDEPENDS += "u-boot"

--
2.17.1