kunit: tool: add missing test data file content
PATCH v2 1/1 kunit: tool: add missing test data file content
Add a missing raw dmesg test log to test the kunit_tool's dmesg parser. test_prefix_poundsign and test_output_with_prefix_isolated_correctly fail without this test log.
--- .../testing/kunit/test_data/test_pound_sign.log | Bin 0 -> 1656 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
tools/testing/kunit/test_data/test_pound_sign.log binary +0 -0
base-commit: 021ed9f551da33449a5238e45e849913422671d7
Signature · 1 line
2.25.1.696.g5e7596f4ac-goog
Quoted 6 lines · Brendan Higgins
Add a missing raw dmesg test log to test the kunit_tool's dmesg parser.
test_prefix_poundsignandtest_output_with_prefix_isolated_correctlyfail without this test log.Signed-off-by Brendan Higgins <[email protected]>
This patch does indeed fix the kunit_tool's unit tests (run with ./tools/testing/kunit/kunit_tool_test.py).
Beforehand, it failed with the errors below:
======================================================================
ERROR: test_prefix_poundsign (__main__.KUnitParserTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./tools/testing/kunit/kunit_tool_test.py", line 208, intest_prefix_poundsign
self.assertEqual('kunit-resource-test', result.suites[0].name)
IndexError: list index out of range
======================================================================
FAIL: test_output_with_prefix_isolated_correctly (__main__.KUnitParserTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./tools/testing/kunit/kunit_tool_test.py", line 116, intest_output_with_prefix_isolated_correctly
self.assertContains('TAP version 14\n', result)
File "./tools/testing/kunit/kunit_tool_test.py", line 96, in
assertContains
str(needle) + '" not found in "' + str(haystack) + '"!')
AssertionError: "TAP version 14
" not found in "<generator object isolate_kunit_output at 0x7f4e88d85ed0>"!
----------------------------------------------------------------------
Ran 20 tests in 0.022s
FAILED (failures=1, errors=1)
shuah
maintainerQuoted 34 lines · David Gow
Quoted 6 lines · Brendan Higgins
Add a missing raw dmesg test log to test the kunit_tool's dmesg parser.
test_prefix_poundsignandtest_output_with_prefix_isolated_correctlyfail without this test log.Signed-off-by Brendan Higgins <[email protected]>Tested-by David Gow <[email protected]>This patch does indeed fix the kunit_tool's unit tests (run with
./tools/testing/kunit/kunit_tool_test.py).Beforehand, it failed with the errors below:
======================================================================
ERROR:test_prefix_poundsign(__main__.KUnitParserTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./tools/testing/kunit/kunit_tool_test.py", line 208, intest_prefix_poundsign
self.assertEqual('kunit-resource-test', result.suites[0].name)
IndexError: list index out of range======================================================================
FAIL:test_output_with_prefix_isolated_correctly(__main__.KUnitParserTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./tools/testing/kunit/kunit_tool_test.py", line 116, intest_output_with_prefix_isolated_correctly
self.assertContains('TAP version 14\n', result)
File "./tools/testing/kunit/kunit_tool_test.py", line 96, in
assertContains
Quoted 9 lines
str(needle) + '" not found in "' + str(haystack) + '"!')AssertionError: "TAP version 14
" not found in "<generator objectisolate_kunit_outputat0x7f4e88d85ed0>"!----------------------------------------------------------------------
Ran 20 tests in 0.022sFAILED (failures=1, errors=1)
Applied to linux-kselftest kunit for Linux 5.7-rc1.
thanks,
-- Shuah