Skip to contentSkip to conversation

i386: Remove unused define's from hax and hvf

PATCH Applied Julio Faracco 2 participants 2 messages Mar 23, 2020 – May 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386: Remove unused define's from hax and hvf

Commit acb9f95a removed boundary checks for ID and VCPU ID. After that, the max definitions of that boundaries are not required anymore. This commit is only a code cleanup.

---
 target/i386/hax-i386.h     | 2 --
 target/i386/hvf/hvf-i386.h | 2 --
 2 files changed, 4 deletions(-)
target/i386/hax-i386.h +0 -2
index 54e9d8b057..70fe5cefeb 100644
@@ -41,8 +41,6 @@ struct hax_state {
 };
 
 #define HAX_MAX_VCPU 0x10
-#define MAX_VM_ID 0x40
-#define MAX_VCPU_ID 0x40
 
 struct hax_vm {
     hax_fd fd;
target/i386/hvf/hvf-i386.h +0 -2
index 15ee4835cf..fbe4a350c5 100644
@@ -21,8 +21,6 @@
 #include "x86.h"
 
 #define HVF_MAX_VCPU 0x10
-#define MAX_VM_ID 0x40
-#define MAX_VCPU_ID 0x40
 
 extern struct hvf_state hvf_global;
 
Signature · 1 line
2.24.1
#1 lore raw
Quoted 29 lines · Julio Faracco

Commit acb9f95a removed boundary checks for ID and VCPU ID. After that, the max definitions of that boundaries are not required anymore. This commit is only a code cleanup.

---
 target/i386/hax-i386.h     | 2 --
 target/i386/hvf/hvf-i386.h | 2 --
 2 files changed, 4 deletions(-)
target/i386/hax-i386.h +0 -2
index 54e9d8b057..70fe5cefeb 100644
@@ -41,8 +41,6 @@ struct hax_state {
 };
 
 #define HAX_MAX_VCPU 0x10
-#define MAX_VM_ID 0x40
-#define MAX_VCPU_ID 0x40
 
 struct hax_vm {
     hax_fd fd;
target/i386/hvf/hvf-i386.h +0 -0
index 15ee4835cf..fbe4a350c5 100644

target/i386/hvf/hvf-i386.h line 26

Quoted 8 lines
target/i386/hvf/hvf-i386.h +0 -2
@@ -21,8 +21,6 @@
 #include "x86.h"
 
 #define HVF_MAX_VCPU 0x10
-#define MAX_VM_ID 0x40
-#define MAX_VCPU_ID 0x40
 
 extern struct hvf_state hvf_global;
 

Queued, thanks.

Paolo