Skip to contentSkip to conversation

nvme-tcp: don't poll a non-live queue

PATCH In review Sagi Grimberg 2 participants 2 messages Mar 23, 2020 – Mar 24, 2020 NVMe

lore
Share & tools
lore

Sagi Grimberg

author maintainer
#0 lore raw

PATCH v2 1/1 nvme-tcp: don't poll a non-live queue

In error recovery we might be removing the queue so check we can actually poll before we do.

---
Changes from v1:
- applies cleanly on nvme-5.6-rc6

 drivers/nvme/host/tcp.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvme/host/tcp.c +3 -0
index 80b3da7b7e02..8f944e2b0231 100644
@@ -2295,6 +2295,9 @@ static int nvme_tcp_poll(struct blk_mq_hw_ctx *hctx)
 	struct nvme_tcp_queue *queue = hctx->driver_data;
 	struct sock *sk = queue->sock->sk;
 
+	if (!test_bit(NVME_TCP_Q_LIVE, &queue->flags))
+		return 0;
+
 	if (sk_can_busy_loop(sk) && skb_queue_empty_lockless(&sk->sk_receive_queue))
 		sk_busy_loop(sk, true);
 	nvme_tcp_try_recv(queue);
Signature · 7 lines
2.20.1


_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme