tools/xenstore: fix a use after free problem in xenstored
PATCH 1/1 tools/xenstore: fix a use after free problem in xenstored
Commit 562a1c0f7ef3fb ("tools/xenstore: dont unlink connection object twice") introduced a potential use after free problem in domain_cleanup(): after calling talloc_unlink() for domain->conn domain->conn is set to NULL. The problem is that domain is registered as talloc child of domain->conn, so it might be freed by the talloc_unlink() call.
--- tools/xenstore/xenstored_domain.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/xenstore/xenstored_domain.c +4 -1
@@ -214,6 +214,7 @@ static void domain_cleanup(void) {xc_dominfo_t dominfo;struct domain *domain; +struct connection *conn;int notify =0 ; again:
@@ -230,8 +231,10 @@ static void domain_cleanup(void)continue ; }if (domain->conn) { -talloc_unlink (talloc_autofree_context (), domain->conn); +/* domain is a talloc child of domain->conn. */ + conn = domain->conn; domain->conn =NULL ; +talloc_unlink (talloc_autofree_context (), conn); notify =0 ;/* destroy_domain() fires the watch */ goto again; }
Signature · 1 line
2.16.4
Ping?
Quoted 38 lines · Juergen Gross
Commit
562a1c0f7ef3fb("tools/xenstore: dont unlink connection object twice") introduced a potential use after free problem indomain_cleanup(): after callingtalloc_unlink()fordomain->conndomain->connis set to NULL. The problem is that domain is registered as talloc child ofdomain->conn, so it might be freed by thetalloc_unlink()call.Fixes 562a1c0f7ef3fb ("tools/xenstore: dont unlink connection object twice")Signed-off-by Juergen Gross <[email protected]>--- tools/xenstore/xenstored_domain.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/xenstore/xenstored_domain.c +4
-1@@ -214,6 +214,7 @@ static void domain_cleanup(void) {xc_dominfo_t dominfo;struct domain *domain; +struct connection *conn;int notify =0 ; again:@@ -230,8 +231,10 @@ static void domain_cleanup(void)continue ; }if (domain->conn) { -talloc_unlink (talloc_autofree_context (), domain->conn); +/* domain is a talloc child of domain->conn. */ + conn = domain->conn; domain->conn =NULL ; +talloc_unlink (talloc_autofree_context (), conn); notify =0 ;/* destroy_domain() fires the watch */ goto again; }