Skip to contentSkip to conversation

Acceptance test: Fix to EXEC migration

PATCH In review Oksana Vohchana 3 participants 7 messages Mar 25, 2020 – Mar 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Acceptance test: Fix to EXEC migration

The exec migration test isn't run a whole test scenario. This patch fixes it

---
 tests/acceptance/migration.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/acceptance/migration.py +3 -3
index a8367ca023..0365289cda 100644
@@ -70,8 +70,8 @@ class Migration(Test):
 
     @skipUnless(find_command('nc', default=False), "'nc' command not found")
     def test_migration_with_exec(self):
-        """
-        The test works for both netcat-traditional and netcat-openbsd packages
-        """
+        """The test works for both netcat-traditional and netcat-openbsd packages."""
         free_port = self._get_free_port()
         dest_uri = 'exec:nc -l localhost %u' % free_port
+        src_uri = 'exec:nc localhost %u' % free_port
+        self.do_migrate(dest_uri, src_uri)
Signature · 1 line
2.21.1
Reviewed-by Tested-by Wainer dos Santos Moschetta on v1 1/1
#1 lore raw

Hi Oksana,

v2 was https://www.mail-archive.com/[email protected]/msg682899.html, so this is v3. Please increment the version in the patch subject.

You could also send a simple "ping" to the specific patch, instead of resending it.

Quoted 4 lines · Oksana Vohchana

The exec migration test isn't run a whole test scenario. This patch fixes it

v1 of this patch has already received reviewers tags (https://www.mail-archive.com/[email protected]/msg679629.html), please collect them and keep them when you resend the same patch:

Quoted 9 lines
---
  tests/acceptance/migration.py | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
tests/acceptance/migration.py +0 -0
index a8367ca023..0365289cda 100644

tests/acceptance/migration.py class Migration(Test): · line 73

Quoted 7 lines
tests/acceptance/migration.py +1 -3
@@ -70,8 +70,8 @@ class Migration(Test):
 
      @skipUnless(find_command('nc', default=False), "'nc' command not found")
      def test_migration_with_exec(self):
-        """
-        The test works for both netcat-traditional and netcat-openbsd packages
-        """
+        """The test works for both netcat-traditional and netcat-openbsd packages."""

Btw why are you changing the comment style?

tests/acceptance/migration.py class Migration(Test): · line 77

Quoted 5 lines
tests/acceptance/migration.py +2 -0
          free_port = self._get_free_port()
          dest_uri = 'exec:nc -l localhost %u' % free_port
+        src_uri = 'exec:nc localhost %u' % free_port
+        self.do_migrate(dest_uri, src_uri)

Alex, if there is no Python testing pullreq, can you take this patch via your testing tree?

Thanks,

Phil.

#2 lore raw

Hi Philippe
Thanks for the review
I have some comments

Quoted 10 lines · Philippe Mathieu-Daudé

Hi Oksana,

v2 was
https://www.mail-archive.com/[email protected]/msg682899.html, so this is v3. Please increment the version in the patch subject.

You could also send a simple "ping" to the specific patch, instead of resending it.

On 3/25/20 12:31 PM, Oksana Vohchana wrote:

Quoted 9 lines
Quoted 4 lines

The exec migration test isn't run a whole test scenario. This patch fixes it

v1 of this patch has already received reviewers tags
(https://www.mail-archive.com/[email protected]/msg679629.html),
please collect them and keep them when you resend the same patch:

I have reposted patch without this fix because this change isn't related to the series:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg06919.html
Is it make sense to keep this fix as a separate patch?

Quoted 20 lines

Review

Quoted 5 lines
---
  tests/acceptance/migration.py | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
(quoted diff) +0 -0

b/tests/acceptance/migration.py

tests/acceptance/migration.py class Migration(Test): · line 71

Quoted 6 lines

index a8367ca023..0365289cda 100644

tests/acceptance/migration.py +0 -0
@@ -70,8 +70,8 @@ class Migration(Test):
 
      @skipUnless(find_command('nc', default=False), "'nc' command not

found")

tests/acceptance/migration.py class Migration(Test):

Quoted 3 lines
tests/acceptance/migration.py +0 -2
      def test_migration_with_exec(self):
-        """
-        The test works for both netcat-traditional and netcat-openbsd
Quoted 7 lines

packages

tests/acceptance/migration.py class Migration(Test): · line 73

Quoted 2 lines
tests/acceptance/migration.py +1 -1
-        """
+        """The test works for both netcat-traditional and

netcat-openbsd packages."""

Btw why are you changing the comment style?

I got failure in PEP257

Quoted 14 lines

tests/acceptance/migration.py class Migration(Test): · line 77

Quoted 5 lines
tests/acceptance/migration.py +2 -0
          free_port = self._get_free_port()
          dest_uri = 'exec:nc -l localhost %u' % free_port
+        src_uri = 'exec:nc localhost %u' % free_port
+        self.do_migrate(dest_uri, src_uri)

Alex, if there is no Python testing pullreq, can you take this patch via your testing tree?

Thanks,

Phil.

Thanks

#3 lore raw
Quoted 57 lines · Oksana Voshchana

Hi Philippe
Thanks for the review
I have some comments

On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé <[email protected] <mailto:[email protected]>> wrote:

Hi Oksana,

v2 was
https://www.mail-archive.com/[email protected]/msg682899.html, so this is v3. Please increment the version in the patch subject.

You could also send a simple "ping" to the specific patch, instead of resending it.

On 3/25/20 12:31 PM, Oksana Vohchana wrote:
> The exec migration test isn't run a whole test scenario. > This patch fixes it
>
> Signed-off-by: Oksana Vohchana <[email protected]
<mailto:[email protected]>>

v1 of this patch has already received reviewers tags
(https://www.mail-archive.com/[email protected]/msg679629.html),
please collect them and keep them when you resend the same patch:

I have reposted patch without this fix because this change isn't related to the series:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg06919.html
Is it make sense to keep this fix as a separate patch?

Fixes 2e768cb682bf

<mailto:[email protected]>>

<mailto:[email protected]>>

> ---
>   tests/acceptance/migration.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-) >
> diff --git a/tests/acceptance/migration.py
b/tests/acceptance/migration.py
> index a8367ca023..0365289cda 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -70,8 +70,8 @@ class Migration(Test):
>
>       @skipUnless(find_command('nc', default=False), "'nc'
command not found")
>       def test_migration_with_exec(self):
> -        """
> -        The test works for both netcat-traditional and
netcat-openbsd packages
> -        """
> +        """The test works for both netcat-traditional and
netcat-openbsd packages."""

Quoted 3 lines

Btw why are you changing the comment style?

I got failure in PEP257

OK, next time please add comment in the patch description too.

Quoted 11 lines

>           free_port = self._get_free_port()
>           dest_uri = 'exec:nc -l localhost %u' % free_port > +        src_uri = 'exec:nc localhost %u' % free_port > +        self.do_migrate(dest_uri, src_uri)
>

Alex, if there is no Python testing pullreq, can you take this patch via
your testing tree?

Cc'ing David since it is migration related.

Quoted 6 lines

Thanks,

Phil.

Thanks

#6 lore raw
In reply to Oksana Voshchana
Quoted 22 lines · Oksana Voshchana

Hi Philippe
Thanks for the review
I have some comments

On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé <[email protected] <mailto:[email protected]>> wrote:

Hi Oksana,

v2 was
https://www.mail-archive.com/[email protected]/msg682899.html, so this is v3. Please increment the version in the patch subject.

You could also send a simple "ping" to the specific patch, instead of resending it.

On 3/25/20 12:31 PM, Oksana Vohchana wrote:
> The exec migration test isn't run a whole test scenario. > This patch fixes it
>
> Signed-off-by: Oksana Vohchana <[email protected]
<mailto:[email protected]>>

Quoted 7 lines

v1 of this patch has already received reviewers tags
(https://www.mail-archive.com/[email protected]/msg679629.html),
please collect them and keep them when you resend the same patch:

I have reposted patch without this fix because this change isn't related to the series:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg06919.html
Is it make sense to keep this fix as a separate patch?

As we are in freeze and this is a fix, it is fine to reply to your own patch with

"Ping? As this is a fix, can we get this single patch merged for 5.0 please? Thanks!"

You are responsible of tracking your own patches and ping them (every week) if they are ignored.

Quoted 48 lines
Fixes 2e768cb682bf

<mailto:[email protected]>>

<mailto:[email protected]>>

> ---
>   tests/acceptance/migration.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-) >
> diff --git a/tests/acceptance/migration.py
b/tests/acceptance/migration.py
> index a8367ca023..0365289cda 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -70,8 +70,8 @@ class Migration(Test):
>
>       @skipUnless(find_command('nc', default=False), "'nc'
command not found")
>       def test_migration_with_exec(self):
> -        """
> -        The test works for both netcat-traditional and
netcat-openbsd packages
> -        """
> +        """The test works for both netcat-traditional and
netcat-openbsd packages."""

Btw why are you changing the comment style?

I got failure in PEP257

>           free_port = self._get_free_port()
>           dest_uri = 'exec:nc -l localhost %u' % free_port > +        src_uri = 'exec:nc localhost %u' % free_port > +        self.do_migrate(dest_uri, src_uri)
>

Alex, if there is no Python testing pullreq, can you take this patch via
your testing tree?

Thanks,

Phil.

Thanks

#4 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 74 lines · * Philippe Mathieu-Daudé ([email protected]) wrote:
Quoted 59 lines · Oksana Voshchana

Hi Philippe
Thanks for the review
I have some comments

On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé <[email protected] <mailto:[email protected]>> wrote:

Hi Oksana,

v2 was
https://www.mail-archive.com/[email protected]/msg682899.html, so this is v3. Please increment the version in the patch subject.

You could also send a simple "ping" to the specific patch, instead of resending it.

On 3/25/20 12:31 PM, Oksana Vohchana wrote:
> The exec migration test isn't run a whole test scenario. > This patch fixes it
>
> Signed-off-by: Oksana Vohchana <[email protected]
<mailto:[email protected]>>

v1 of this patch has already received reviewers tags
(https://www.mail-archive.com/[email protected]/msg679629.html),
please collect them and keep them when you resend the same patch:

I have reposted patch without this fix because this change isn't related to the series:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg06919.html
Is it make sense to keep this fix as a separate patch?

Fixes 2e768cb682bf

<mailto:[email protected]>>

<mailto:[email protected]>>

> ---
>   tests/acceptance/migration.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-) >
> diff --git a/tests/acceptance/migration.py
b/tests/acceptance/migration.py
> index a8367ca023..0365289cda 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -70,8 +70,8 @@ class Migration(Test):
>
>       @skipUnless(find_command('nc', default=False), "'nc'
command not found")
>       def test_migration_with_exec(self):
> -        """
> -        The test works for both netcat-traditional and
netcat-openbsd packages
> -        """
> +        """The test works for both netcat-traditional and
netcat-openbsd packages."""

Quoted 3 lines

Btw why are you changing the comment style?

I got failure in PEP257

OK, next time please add comment in the patch description too.

Quoted 8 lines

>           free_port = self._get_free_port()
>           dest_uri = 'exec:nc -l localhost %u' % free_port > +        src_uri = 'exec:nc localhost %u' % free_port > +        self.do_migrate(dest_uri, src_uri)
>

Quoted 5 lines
Quoted 3 lines

Alex, if there is no Python testing pullreq, can you take this patch via
your testing tree?

Cc'ing David since it is migration related.

I tend to leave the tests/acceptance to someone other than the migration tree; so feel free to take them via testing or trivial given the size.

Dave

Quoted 7 lines
Quoted 6 lines

Thanks,

Phil.

Thanks

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

#5 lore raw

Hi David,

Quoted 75 lines · Dr. David Alan Gilbert
Quoted 74 lines · * Philippe Mathieu-Daudé ([email protected]) wrote:
Quoted 59 lines · Oksana Voshchana

Hi Philippe
Thanks for the review
I have some comments

On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé <[email protected] <mailto:[email protected]>> wrote:

Hi Oksana,

v2 was
https://www.mail-archive.com/[email protected]/msg682899.html, so this is v3. Please increment the version in the patch subject.

You could also send a simple "ping" to the specific patch, instead of resending it.

On 3/25/20 12:31 PM, Oksana Vohchana wrote:
> The exec migration test isn't run a whole test scenario. > This patch fixes it
>
> Signed-off-by: Oksana Vohchana <[email protected]
<mailto:[email protected]>>

v1 of this patch has already received reviewers tags
(https://www.mail-archive.com/[email protected]/msg679629.html),
please collect them and keep them when you resend the same patch:

I have reposted patch without this fix because this change isn't related to the series:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg06919.html
Is it make sense to keep this fix as a separate patch?

Fixes 2e768cb682bf

<mailto:[email protected]>>

<mailto:[email protected]>>

> ---
>   tests/acceptance/migration.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-) >
> diff --git a/tests/acceptance/migration.py
b/tests/acceptance/migration.py
> index a8367ca023..0365289cda 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -70,8 +70,8 @@ class Migration(Test):
>
>       @skipUnless(find_command('nc', default=False), "'nc'
command not found")
>       def test_migration_with_exec(self):
> -        """
> -        The test works for both netcat-traditional and
netcat-openbsd packages
> -        """
> +        """The test works for both netcat-traditional and
netcat-openbsd packages."""

Quoted 3 lines

Btw why are you changing the comment style?

I got failure in PEP257

OK, next time please add comment in the patch description too.

Quoted 8 lines

>           free_port = self._get_free_port()
>           dest_uri = 'exec:nc -l localhost %u' % free_port > +        src_uri = 'exec:nc localhost %u' % free_port > +        self.do_migrate(dest_uri, src_uri)
>

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Alex, if there is no Python testing pullreq, can you take this patch via
your testing tree?

Cc'ing David since it is migration related.

I tend to leave the tests/acceptance to someone other than the migration tree; so feel free to take them via testing or trivial given the size.

Acceptance tests are in the same tests/acceptance directory for no particular reason. We thought they would share some common code but this code is in the python/qemu/ directory.

Similarly to C Qtests stored in the tests/qtest, acceptance are in tests/acceptance. tests/qtest have various maintainers, when a maintainer has interest in a qtest (subsystem covered by the test), the test is added to the subsystem maintained section. I'd rather see the same with acceptance tests. For example with Oksana's test, I can review that it correctly uses the acceptance testing framework, and it doesn't break the rest of the tests, but I have no idea if it properly tests the migration features it aims to.

Back to this particular patch, if Eduardo/Cleber ack I can send a pullreq for rc2.

Quoted 13 lines

Dave

Quoted 7 lines
Quoted 6 lines

Thanks,

Phil.

Thanks

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK