ASoC: Intel: boards: Revert SSP0 links to use dummy
Subsystems (3)
Cezary Rojewski
maintainercover ASoC: Intel: boards: Revert SSP0 links to use dummy
Recent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.
While harmless so far, this flow isn't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.
Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54
Cezary Rojewski (3):
ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components
ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components
sound/soc/intel/boards/bdw-rt5650.c | 7 ++++--- sound/soc/intel/boards/bdw-rt5677.c | 7 ++++--- sound/soc/intel/boards/broadwell.c | 7 ++++--- 3 files changed, 12 insertions(+), 9 deletions(-)
Signature · 1 line
2.17.1
Cezary Rojewski
maintainerPATCH 3/3 ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components
Recent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.
While harmless so far, this flow isn't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.
--- sound/soc/intel/boards/bdw-rt5650.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/bdw-rt5650.c +4 -3
@@ -226,9 +226,6 @@ SND_SOC_DAILINK_DEF(be,#if IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL )SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); -#else -SND_SOC_DAILINK_DEF (ssp0_port, -DAILINK_COMP_ARRAY (COMP_DUMMY ()));#endif static struct snd_soc_dai_link bdw_rt5650_dais[] = {
@@ -263,7 +260,11 @@ static struct snd_soc_dai_link bdw_rt5650_dais[] = { .dpcm_playback = 1, .dpcm_capture = 1, .init = bdw_rt5650_init, +#if !IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL ) +SND_SOC_DAILINK_REG (dummy, be, dummy), +#else SND_SOC_DAILINK_REG(ssp0_port, be, platform), +#endif }, };
Signature · 1 line
2.17.1
Cezary Rojewski
maintainerPATCH 2/3 ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
In reply to Cezary RojewskiRecent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.
While harmless so far, this flow isn't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.
--- sound/soc/intel/boards/bdw-rt5677.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/bdw-rt5677.c +4 -3
@@ -298,9 +298,6 @@ SND_SOC_DAILINK_DEF(be,#if IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL )SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); -#else -SND_SOC_DAILINK_DEF (ssp0_port, -DAILINK_COMP_ARRAY (COMP_DUMMY ()));#endif /* Wake on voice interface */
@@ -349,7 +346,11 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = { .dpcm_playback = 1, .dpcm_capture = 1, .init = bdw_rt5677_init, +#if !IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL ) +SND_SOC_DAILINK_REG (dummy, be, dummy), +#else SND_SOC_DAILINK_REG(ssp0_port, be, platform), +#endif }, };
Signature · 1 line
2.17.1
Cezary Rojewski
maintainerPATCH 1/3 ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components
In reply to Cezary RojewskiRecent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.
While harmless so far, this flow isn't correct and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.
Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54
--- sound/soc/intel/boards/broadwell.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/broadwell.c +4 -3
@@ -167,9 +167,6 @@ SND_SOC_DAILINK_DEF(codec,#if IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL )SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); -#else -SND_SOC_DAILINK_DEF (ssp0_port, -DAILINK_COMP_ARRAY (COMP_DUMMY ()));#endif /* broadwell digital audio interface glue - connects codec <--> CPU */
@@ -225,7 +222,11 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = { .ops = &broadwell_rt286_ops, .dpcm_playback = 1, .dpcm_capture = 1, +#if !IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL ) +SND_SOC_DAILINK_REG (dummy, codec, dummy), +#else SND_SOC_DAILINK_REG(ssp0_port, codec, platform), +#endif }, };
Signature · 1 line
2.17.1
Quoted 11 lines · Cezary Rojewski
Recent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start.
hw_paramsfor haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.While harmless so far, this flow isn't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.
Quoted 7 lines
Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54Cezary Rojewski (3):
ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components
ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components
Thanks Cezary, for the series
Quoted 6 lines
sound/soc/intel/boards/bdw-rt5650.c | 7 ++++--- sound/soc/intel/boards/bdw-rt5677.c | 7 ++++--- sound/soc/intel/boards/broadwell.c | 7 ++++--- 3 files changed, 12 insertions(+), 9 deletions(-)
Mark Brown
maintainerApplied "ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components" to the asoc tree
In reply to Cezary RojewskiThe patch
ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
From c031d3de80a4f6127fc7b953fdaeead934e61c1a Mon Sep 17 00:00:00 2001
From: Cezary Rojewski <[email protected]>
Date: Wed, 25 Mar 2020 14:16:10 +0100
Subject: [PATCH] ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy
components
Recent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.
While harmless so far, this flow isn't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.
--- sound/soc/intel/boards/bdw-rt5677.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/bdw-rt5677.c +4 -3
@@ -298,9 +298,6 @@ SND_SOC_DAILINK_DEF(be,#if IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL )SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); -#else -SND_SOC_DAILINK_DEF (ssp0_port, -DAILINK_COMP_ARRAY (COMP_DUMMY ()));#endif /* Wake on voice interface */
@@ -350,7 +347,11 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = { .dpcm_playback = 1, .dpcm_capture = 1, .init = bdw_rt5677_init, +#if !IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL ) +SND_SOC_DAILINK_REG (dummy, be, dummy), +#else SND_SOC_DAILINK_REG(ssp0_port, be, platform), +#endif }, };
Signature · 1 line
2.20.1
Mark Brown
maintainerApplied "ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components" to the asoc tree
In reply to Cezary RojewskiThe patch
ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
From f25e203070e5b12e4db366ee99b86f33a968f1ae Mon Sep 17 00:00:00 2001
From: Cezary Rojewski <[email protected]>
Date: Wed, 25 Mar 2020 14:16:11 +0100
Subject: [PATCH] ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy
components
Recent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there.
While harmless so far, this flow isn't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series.
--- sound/soc/intel/boards/bdw-rt5650.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
sound/soc/intel/boards/bdw-rt5650.c +4 -3
@@ -226,9 +226,6 @@ SND_SOC_DAILINK_DEF(be,#if IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL )SND_SOC_DAILINK_DEF (ssp0_port,DAILINK_COMP_ARRAY (COMP_CPU ("ssp0-port" ))); -#else -SND_SOC_DAILINK_DEF (ssp0_port, -DAILINK_COMP_ARRAY (COMP_DUMMY ()));#endif static struct snd_soc_dai_link bdw_rt5650_dais[] = {
@@ -264,7 +261,11 @@ static struct snd_soc_dai_link bdw_rt5650_dais[] = { .dpcm_playback = 1, .dpcm_capture = 1, .init = bdw_rt5650_init, +#if !IS_ENABLED (CONFIG_SND_SOC_SOF_BROADWELL ) +SND_SOC_DAILINK_REG (dummy, be, dummy), +#else SND_SOC_DAILINK_REG(ssp0_port, be, platform), +#endif }, };
Signature · 1 line
2.20.1