Skip to contentSkip to conversation

staging: octeon-usb: line over 80 characters

PATCH Superseded Gokce Kuler 3 participants 3 messages Mar 25, 2020 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: octeon-usb: line over 80 characters

Moved from the comma character to the bottom line after for it exceeds 80 characters.

---
 drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/octeon-usb/octeon-hcd.c +2 -1
index a73289ba..dbafd46 100644
@@ -2641,7 +2641,8 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
 						     hcintmsk.u32);
 				usbc_hcchar.s.chdis = 1;
 				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCCHARX(channel, usb->index),
+						     CVMX_USBCX_HCCHARX(
+						     channel, usb->index),
 						     usbc_hcchar.u32);
 				return 0;
 			} else if (usbc_hcint.s.xfercompl) {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 13 lines · Gokce Kuler

Moved from the comma character to the bottom line after for it exceeds 80 characters.

---
 drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/octeon-usb/octeon-hcd.c +0 -0
index a73289ba..dbafd46 100644

drivers/staging/octeon-usb/octeon-hcd.c static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel) · line 2646

Quoted 7 lines
drivers/staging/octeon-usb/octeon-hcd.c +2 -1
@@ -2641,7 +2641,8 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
 						     hcintmsk.u32);
 				usbc_hcchar.s.chdis = 1;
 				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCCHARX(channel, usb->index),
+						     CVMX_USBCX_HCCHARX(
+						     channel, usb->index),
 						     usbc_hcchar.u32);

This is confusing, It is had to see which arguments go with which function. I don't know if it would be acceptable to add a few spaces in front of channel.

julia

Quoted 10 lines
drivers/staging/octeon-usb/octeon-hcd.c +0 -1
 				return 0;
 			} else if (usbc_hcint.s.xfercompl) {
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325202714.GA14306%40siyah2.

#2 lore raw
Quoted 9 lines · Julia Lawall

drivers/staging/octeon-usb/octeon-hcd.c static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel) · line 2646

Quoted 5 lines

cvmx_usb_write_csr32(usb,

drivers/staging/octeon-usb/octeon-hcd.c +2 -1
-						     CVMX_USBCX_HCCHARX(channel, usb->index),
+						     CVMX_USBCX_HCCHARX(
+						     channel, usb->index),
  						     usbc_hcchar.u32);

This is confusing, It is had to see which arguments go with which function. I don't know if it would be acceptable to add a few spaces in front of channel.

I agree with Julia. Can we do the following and still be within the 80 character per line?

cvmx_usb_write_csr32(usb,

		     CVMX_USBCX_HCCHARX(channel,
                                        usb->index),
                     usbc_hcchar.u32);

thanks,
-lakshmi