Skip to contentSkip to conversation

staging: qlge: Block comments use a trailing */ on a separate line

PATCH In review Gokce Kuler 2 participants 3 messages Mar 25, 2020 – Mar 26, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: qlge: Block comments use a trailing */ on a separate line

Deleted more * for block comments rules.

---
 drivers/staging/qlge/qlge_mpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/qlge/qlge_mpi.c +1 -1
index 60c08d9..31322ec 100644
@@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
 		/* Signal the resulting link up AEN
 		 * that the frame routing and mac addr
 		 * needs to be set.
-		 * */
+		 */
 		set_bit(QL_CAM_RT_SET, &qdev->flags);
 		/* Do ACK if required */
 		if (timeout) {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 1 line · Gokce Kuler

Deleted more * for block comments rules.

The subject line and the log message should be in the imperative. Actually, your subject line is quite confusing, because it describes the situation one wants to end up with, rather than what should be done. Something like "Adjust end of block comment" would be fine for the subject line. The log message could be "Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch.".

julia

Quoted 27 lines
---
 drivers/staging/qlge/qlge_mpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/qlge/qlge_mpi.c +1 -2
index 60c08d9..31322ec 100644
@@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
 		/* Signal the resulting link up AEN
 		 * that the frame routing and mac addr
 		 * needs to be set.
-		 * */
+		 */
 		set_bit(QL_CAM_RT_SET, &qdev->flags);
 		/* Do ACK if required */
 		if (timeout) {
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325231055.GA29122%40siyah2.

#2 lore raw

Thanks for the feedback!

Julia Lawall <[email protected]>, 26 Mar 2020 Per, 10:21 tarihinde şunu yazdı:

Quoted 49 lines · Gokce Kuler
Quoted 2 lines

Deleted more * for block comments rules.

The subject line and the log message should be in the imperative. Actually, your subject line is quite confusing, because it describes the situation one wants to end up with, rather than what should be done. Something like "Adjust end of block comment" would be fine for the subject line. The log message could be "Drop an unnecessary * on the last line of a block comment to follow the Linux kernel coding conventions. Problem found by checkpatch.".

julia

Review

Quoted 7 lines
---
 drivers/staging/qlge/qlge_mpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/qlge/qlge_mpi.c

Quoted 15 lines

index 60c08d9..31322ec 100644

drivers/staging/qlge/qlge_mpi.c +1 -2
@@ -1178,7 +1178,7 @@ void ql_mpi_idc_work(struct work_struct *work)
              /* Signal the resulting link up AEN
               * that the frame routing and mac addr
               * needs to be set.
-              * */
+              */
              set_bit(QL_CAM_RT_SET, &qdev->flags);
              /* Do ACK if required */
              if (timeout) {
--

2.7.4

Quoted 2 lines

--
You received this message because you are subscribed to the Google

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected].

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20200325231055.GA29122%40siyah2
.

Quoted 1 line