Skip to contentSkip to conversation

usb: chipidea: udc: fix the kernel doc for udc.h

PATCH New Peter Chen 1 participant 3 messages Mar 26, 2020

Subsystems (2)
USB Chipidea USB high speed dual role controller
lore
Share & tools
lore

Peter Chen

author maintainer
#0 lore raw

PATCH 1/3 usb: chipidea: udc: fix the kernel doc for udc.h

From: Peter Chen <[email protected]>

The kernel doc for td_node is outdated, update it.

Signed-off-by Peter Chen <[email protected]>
---
 drivers/usb/chipidea/udc.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/usb/chipidea/udc.h +1 -4
index ebb11b625bb8..32b56f84f77a 100644
@@ -67,10 +67,7 @@ struct td_node {
  * struct ci_hw_req - usb request representation
  * @req: request structure for gadget drivers
  * @queue: link to QH list
- * @ptr: transfer descriptor for this request
- * @dma: dma address for the transfer descriptor
- * @zptr: transfer descriptor for the zero packet
- * @zdma: dma address of the zero packet's transfer descriptor
+ * @tds: link to TD list
  */
 struct ci_hw_req {
 	struct usb_request	req;
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 2/3 usb: chipidea: core: refine the description for this driver

From: Peter Chen <[email protected]>

Some descriptions are outdated, update them.

Signed-off-by Peter Chen <[email protected]>
---
 drivers/usb/chipidea/core.c | 40 +++++++------------------------------
 1 file changed, 7 insertions(+), 33 deletions(-)
drivers/usb/chipidea/core.c +7 -33
index ae0bdc036464..12971c96c19e 100644
@@ -3,42 +3,16 @@
  * core.c - ChipIdea USB IP core family device controller
  *
  * Copyright (C) 2008 Chipidea - MIPS Technologies, Inc. All rights reserved.
+ * Copyright (C) 2020 NXP
  *
  * Author: David Lopo
- */
-
-/*
- * Description: ChipIdea USB IP core family device controller
- *
- * This driver is composed of several blocks:
- * - HW:     hardware interface
- * - DBG:    debug facilities (optional)
- * - UTIL:   utilities
- * - ISR:    interrupts handling
- * - ENDPT:  endpoint operations (Gadget API)
- * - GADGET: gadget operations (Gadget API)
- * - BUS:    bus glue code, bus abstraction layer
- *
- * Compile Options
- * - STALL_IN:  non-empty bulk-in pipes cannot be halted
- *              if defined mass storage compliance succeeds but with warnings
- *              => case 4: Hi >  Dn
- *              => case 5: Hi >  Di
- *              => case 8: Hi <> Do
- *              if undefined usbtest 13 fails
- * - TRACE:     enable function tracing (depends on DEBUG)
- *
- * Main Features
- * - Chapter 9 & Mass Storage Compliance with Gadget File Storage
- * - Chapter 9 Compliance with Gadget Zero (STALL_IN undefined)
- * - Normal & LPM support
- *
- * USBTEST Report
- * - OK: 0-12, 13 (STALL_IN defined) & 14
- * - Not Supported: 15 & 16 (ISO)
+ *	   Peter Chen <[email protected]>
  *
- * TODO List
- * - Suspend & Remote Wakeup
+ * Main Features:
+ * - Four transfers are supported, usbtest is passed
+ * - USB Certification for gadget: CH9 and Mass Storage are passed
+ * - Low power mode
+ * - USB wakeup
  */
 #include <linux/delay.h>
 #include <linux/device.h>
Signature · 1 line
2.17.1
author maintainer
#2 lore raw

PATCH 3/3 usb: chipidea: core: show the real pointer value for register

In reply to Peter Chen

From: Peter Chen <[email protected]>

The pointer value is "ptrval" like below at current code:
ci_hdrc ci_hdrc.0: ChipIdea HDRC found, revision: 25, lpm: 0;
cap: (ptrval) op: (ptrval)

According to Documentation/core-api/printk-formats.rst, we change it from %p to %px for real value.

Signed-off-by Peter Chen <[email protected]>
---
 drivers/usb/chipidea/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/chipidea/core.c +1 -1
index 12971c96c19e..ea8ac4a54a8d 100644
@@ -246,7 +246,7 @@ static int hw_device_init(struct ci_hdrc *ci, void __iomem *base)
 	ci->rev = ci_get_revision(ci);
 
 	dev_dbg(ci->dev,
-		"ChipIdea HDRC found, revision: %d, lpm: %d; cap: %p op: %p\n",
+		"revision: %d, lpm: %d; cap: %px op: %px\n",
 		ci->rev, ci->hw_bank.lpm, ci->hw_bank.cap, ci->hw_bank.op);
 
 	/* setup lock mode ? */
Signature · 1 line
2.17.1