Skip to contentSkip to conversation

staging: wlan-ng: fix use-after-free Read in hfa384x_usbin_callback

PATCH New Qiujun Huang 1 participant 1 message Mar 26, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wlan-ng: fix use-after-free Read in hfa384x_usbin_callback

We can't handle the case length > WLAN_DATA_MAXLEN.
Because the size of rxfrm->data is WLAN_DATA_MAXLEN(2312), and we can't read more than that.

Thanks-to: Hillf Danton <[email protected]>

Reported-and-tested-by [email protected]
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/staging/wlan-ng/hfa384x_usb.c +2 -0
index b71756ab0394..7fe64fcd385d 100644
@@ -3372,6 +3372,8 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
 	     WLAN_HDR_A4_LEN + WLAN_DATA_MAXLEN + WLAN_CRC_LEN)) {
 		pr_debug("overlen frm: len=%zd\n",
 			 skblen - sizeof(struct p80211_caphdr));
+
+		return;
 	}
 
 	skb = dev_alloc_skb(skblen);
Signature · 1 line
2.17.1