Skip to contentSkip to conversation

ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

RFC PATCH In review Fabio Estevam 2 participants 3 messages Mar 26, 2020 – Mar 27, 2020

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

RFC PATCH 1/1 ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

The I2C2 pins are already used and the following errors are seen:

imx27-pinctrl 10015000.iomuxc: pin MX27_PAD_I2C2_SDA already requested by 10012000.i2c; cannot claim for 1001d000.i2c imx27-pinctrl 10015000.iomuxc: pin-69 (1001d000.i2c) status -22
imx27-pinctrl 10015000.iomuxc: could not request pin 69 (MX27_PAD_I2C2_SDA) from group i2c2grp on device 10015000.iomuxc imx-i2c 1001d000.i2c: Error applying setting, reverse things back
imx-i2c: probe of 1001d000.i2c failed with error -22

Fix it by adding the correct I2C1 IOMUX entries for the pinctrl_i2c1 group.

---
Hi,

I don't have access to this board, nor to its schematics to confirm.

Noticed this error at:
https://storage.kernelci.org/next/master/next-20200326/arm/imx_v4_v5_defconfig/gcc-8/lab-pengutronix/boot-imx27-phytec-phycard-s-rdk.html

Please help to confirm.

 arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts +2 -2
index 0cd75dadf292..188639738dc3 100644
@@ -75,8 +75,8 @@
 	imx27-phycard-s-rdk {
 		pinctrl_i2c1: i2c1grp {
 			fsl,pins = <
-				MX27_PAD_I2C2_SDA__I2C2_SDA 0x0
-				MX27_PAD_I2C2_SCL__I2C2_SCL 0x0
+				MX27_PAD_I2C_DATA__I2C_DATA 0x0
+				MX27_PAD_I2C_CLK__I2C_CLK 0x0
 			>;
 		};
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

Hi Fabio,

-----Fabio Estevam <[email protected]> schrieb: -----

Quoted 26 lines

An: [email protected]
Von: Fabio Estevam <[email protected]>
Datum: 26.03.2020 14:50
Kopie: [email protected], [email protected], [email protected], [email protected], Fabio Estevam <[email protected]>
Betreff: [RFC PATCH] ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries

The I2C2 pins are already used and the following errors are seen:

imx27-pinctrl 10015000.iomuxc: pin MX27_PAD_I2C2_SDA already requested by 10012000.i2c; cannot claim for 1001d000.i2c imx27-pinctrl 10015000.iomuxc: pin-69 (1001d000.i2c) status -22 imx27-pinctrl 10015000.iomuxc: could not request pin 69 (MX27_PAD_I2C2_SDA) from group i2c2grp on device 10015000.iomuxc imx-i2c 1001d000.i2c: Error applying setting, reverse things back
imx-i2c: probe of 1001d000.i2c failed with error -22

Fix it by adding the correct I2C1 IOMUX entries for the pinctrl_i2c1 group.

---
Hi,

Quoted 7 lines

I don't have access to this board, nor to its schematics to confirm.

Noticed this error at:
https://storage.kernelci.org/next/master/next-20200326/arm/imx_v4_v5_
defconfig/gcc-8/lab-pengutronix/boot-imx27-phytec-phycard-s-rdk.html

Please help to confirm.

I don't have a board here either but I checked the schematics and your fix looks good.

Regards,
Stefan

Quoted 24 lines

arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts +2 -2
index 0cd75dadf292..188639738dc3 100644
@@ -75,8 +75,8 @@
 imx27-phycard-s-rdk {
 		pinctrl_i2c1: i2c1grp {
 			fsl,pins = <
-				MX27_PAD_I2C2_SDA__I2C2_SDA 0x0
-				MX27_PAD_I2C2_SCL__I2C2_SCL 0x0
+				MX27_PAD_I2C_DATA__I2C_DATA 0x0
+				MX27_PAD_I2C_CLK__I2C_CLK 0x0
 			>;
 		};
 
Signature · 1 line
2.17.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author reviewer
#2 lore raw

Hi Stefan,

Quoted 1 line · Stefan Riedmüller

I don't have a board here either but I checked the schematics and your fix looks good.

Thanks for checking.

I have just resent it without the RFC tag, added stable on Cc and the Fixes tag.

Please reply with your Reviewed-by if possible.

Thanks

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel