Skip to contentSkip to conversation

test/py: mmc: Fix 'mmc info' testcase

PATCH New Harald Seiler 4 participants 4 messages Mar 26, 2020 – Mar 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test/py: mmc: Fix 'mmc info' testcase

Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed the layout of mmc info output. Reflect this change in the respective testcase.

Also fix a typo in the documentation.

Fixes 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent")
---
 test/py/tests/test_mmc_rd.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
test/py/tests/test_mmc_rd.py +2 -2
index a25aa5f6f78e..ea652f913618 100644
@@ -56,7 +56,7 @@ env__mmc_dev_configs = (
         'info_mode': ???,
         'info_buswidth': ???.
     },
-}
+)
 
 # Configuration data for test_mmc_rd; defines regions of the MMC (entire
 # devices, or ranges of sectors) which can be read:
@@ -210,7 +210,7 @@ def test_mmc_info(u_boot_console, env__mmc_dev_config):
     assert good_response in response
     good_response = "Bus Speed: %s" % info_speed
     assert good_response in response
-    good_response = "Mode : %s" % info_mode
+    good_response = "Mode: %s" % info_mode
     assert good_response in response
     good_response = "Bus Width: %s" % info_buswidth
     assert good_response in response
Signature · 1 line
2.25.2
#1 lore raw

PATCH 1/1 test/py: mmc: Fix 'mmc info' testcase

Quoted 5 lines · Harald Seiler

Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed the layout of mmc info output. Reflect this change in the respective testcase.

Also fix a typo in the documentation.

I guess I don't have these tests enabled, which is why my test system didn't catch this.

#2 lore raw

PATCH 1/1 test/py: mmc: Fix 'mmc info' testcase

In reply to Harald Seiler
Quoted 5 lines · Harald Seiler

Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed the layout of mmc info output. Reflect this change in the respective testcase.

Quoted 7 lines

Also fix a typo in the documentation.

Fixes 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent")
---
 test/py/tests/test_mmc_rd.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
#3 lore raw

PATCH 1/1 test/py: mmc: Fix 'mmc info' testcase

In reply to Harald Seiler
Quoted 10 lines · Harald Seiler

Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed the layout of mmc info output. Reflect this change in the respective testcase.

Also fix a typo in the documentation.

Fixes 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent")

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200327/3a36faa7/attachment.sig>