Skip to contentSkip to conversation

Input: move the new KEY_SELECTIVE_SCREENSHOT keycode

PATCH In review Dmitry Torokhov 2 participants 2 messages Mar 26, 2020

Subsystems (2)
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 Input: move the new KEY_SELECTIVE_SCREENSHOT keycode

We should try to keep keycodes sequential unless there is a reason to leave a gap in numbering, so let's move it from 0x280 to 0x27a while we still can.

Fixes 3b059da9835c ("Input: allocate keycode for Selective Screenshot key")
---
 include/uapi/linux/input-event-codes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/input-event-codes.h +1 -1
index 008be2609ce1..6923dc7e0298 100644
@@ -653,7 +653,7 @@
 #define KEY_PRIVACY_SCREEN_TOGGLE	0x279
 
 /* Select an area of screen to be copied */
-#define KEY_SELECTIVE_SCREENSHOT	0x280
+#define KEY_SELECTIVE_SCREENSHOT	0x27a
 
 /*
  * Some keyboards have keys which do not have a defined meaning, these keys
Signature · 5 lines
2.26.0.rc2.310.g2932bb562d-goog


-- 
Dmitry
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Dmitry Torokhov

We should try to keep keycodes sequential unless there is a reason to leave a gap in numbering, so let's move it from 0x280 to 0x27a while we still can.

Fixes 3b059da9835c ("Input: allocate keycode for Selective Screenshot key")

Thanks! My apologies for overlooking.

Quoted 23 lines
---
 include/uapi/linux/input-event-codes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/input-event-codes.h +1 -2
index 008be2609ce1..6923dc7e0298 100644
@@ -653,7 +653,7 @@
 #define KEY_PRIVACY_SCREEN_TOGGLE      0x279
 
 /* Select an area of screen to be copied */
-#define KEY_SELECTIVE_SCREENSHOT       0x280
+#define KEY_SELECTIVE_SCREENSHOT       0x27a
 
 /*
  * Some keyboards have keys which do not have a defined meaning, these keys
--

2.26.0.rc2.310.g2932bb562d-goog

--
Dmitry