Skip to contentSkip to conversation

Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel

PATCH Superseded Harigovindan P 3 participants 7 messages Mar 27, 2020 – Mar 31, 2020

Subsystems (5)

v10 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

v10 cover Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel

Adding support for visionox rm69299 panel driver and adding bindings for the same panel.

Harigovindan P (2):
dt-bindings: display: add visionox rm69299 panel variant drm/panel: add support for rm69299 visionox panel driver

 .../display/panel/visionox,rm69299.yaml       |  58 ++++
 drivers/gpu/drm/panel/Kconfig                 |   8 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-visionox-rm69299.c    | 295 ++++++++++++++++++
 4 files changed, 362 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c
Signature · 1 line
2.25.1
#1 lore raw

PATCH v10 1/2 dt-bindings: display: add visionox rm69299 panel variant

Add bindings for visionox rm69299 panel.

---

Changes in v2:
- Removed unwanted properties from description.
- Creating source files without execute permissions(Rob Herring).
Changes in v3:
- Changing txt file into yaml
Changes in v4:
- Updating license identifier.
- Moving yaml file inside panel directory.
- Removing pinctrl entries.
- Adding documentation for reset-gpios.
Changes in v5:
- No changes. Updated 2/2 Patch.
Changes in v6:
- Removing patternProperties.
- Added " |" after description.
- Setting port and reset-gpios to true.
- Removing @ae94000 for dsi node.
Changes in v7:
- Added reg property.
Changes in v8:
- Rearranged additionalProperties.
- Dropping improper reg property.
Changes in v9:

    - Adding additionalProperties at the same level as
      'properties'
    - Adding properties for "ports" which includes:
      -> #address-cells
      -> #size-cells
      -> port@0

Changes in v10:
- Changed file mode
- Making port as required
- Fixing example by removing ports and unit address in port
- Removing indentation for 'additionalProperties'

 .../display/panel/visionox,rm69299.yaml       | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml new file +58 -0
new file mode 100644
index 000000000000..1a44caae5f9b
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/visionox,rm69299.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Visionox model RM69299 Panels Device Tree Bindings.
+
+maintainers:
+ - Harigovindan P <[email protected]>
+
+description: |
+ This binding is for display panels using a Visionox RM692999 panel.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: visionox,rm69299-1080p-display
+
+  vdda-supply:
+    description: |
+      Phandle of the regulator that provides the vdda supply voltage.
+
+  vdd3p3-supply:
+    description: |
+      Phandle of the regulator that provides the vdd3p3 supply voltage.
+
+  port: true
+
+  reset-gpios: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - vdda-supply
+  - vdd3p3-supply
+  - reset-gpios
+  - port
+
+examples:
+  - |
+    panel {
+        compatible = "visionox,rm69299-1080p-display";
+
+        vdda-supply = <&src_pp1800_l8c>;
+        vdd3p3-supply = <&src_pp2800_l18a>;
+
+        reset-gpios = <&pm6150l_gpio 3 0>;
+        port {
+            panel0_in: endpoint {
+                remote-endpoint = <&dsi0_out>;
+            };
+        };
+    };
+...
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v10 1/2] dt-bindings: display: add visionox rm69299 panel variant

Hi Harigovindan

Quoted 34 lines · Harigovindan P

Add bindings for visionox rm69299 panel.

---

Changes in v2:
- Removed unwanted properties from description.
- Creating source files without execute permissions(Rob Herring).
Changes in v3:
- Changing txt file into yaml
Changes in v4:
- Updating license identifier.
- Moving yaml file inside panel directory.
- Removing pinctrl entries.
- Adding documentation for reset-gpios.
Changes in v5:
- No changes. Updated 2/2 Patch.
Changes in v6:
- Removing patternProperties.
- Added " |" after description.
- Setting port and reset-gpios to true.
- Removing @ae94000 for dsi node.
Changes in v7:
- Added reg property.
Changes in v8:
- Rearranged additionalProperties.
- Dropping improper reg property.
Changes in v9:

    - Adding additionalProperties at the same level as
      'properties'
    - Adding properties for "ports" which includes:
      -> #address-cells
      -> #size-cells
      -> port@0
Quoted 5 lines

Changes in v10:
- Changed file mode
- Making port as required
- Fixing example by removing ports and unit address in port
- Removing indentation for 'additionalProperties'

Fixed ident in a few places (one space => two sapces), and applied to drm-misc-next.

Sam

Quoted 76 lines
 .../display/panel/visionox,rm69299.yaml       | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml new file +58 -0
new file mode 100644
index 000000000000..1a44caae5f9b
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/visionox,rm69299.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Visionox model RM69299 Panels Device Tree Bindings.
+
+maintainers:
+ - Harigovindan P <[email protected]>
+
+description: |
+ This binding is for display panels using a Visionox RM692999 panel.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: visionox,rm69299-1080p-display
+
+  vdda-supply:
+    description: |
+      Phandle of the regulator that provides the vdda supply voltage.
+
+  vdd3p3-supply:
+    description: |
+      Phandle of the regulator that provides the vdd3p3 supply voltage.
+
+  port: true
+
+  reset-gpios: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - vdda-supply
+  - vdd3p3-supply
+  - reset-gpios
+  - port
+
+examples:
+  - |
+    panel {
+        compatible = "visionox,rm69299-1080p-display";
+
+        vdda-supply = <&src_pp1800_l8c>;
+        vdd3p3-supply = <&src_pp2800_l18a>;
+
+        reset-gpios = <&pm6150l_gpio 3 0>;
+        port {
+            panel0_in: endpoint {
+                remote-endpoint = <&dsi0_out>;
+            };
+        };
+    };
+...
Signature · 6 lines
2.25.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
In reply to Harigovindan P

Hi Harigovindan

Quoted 5 lines · Harigovindan P

Adding support for visionox rm69299 panel driver and adding bindings for the same panel.

Harigovindan P (2):
dt-bindings: display: add visionox rm69299 panel variant drm/panel: add support for rm69299 visionox panel driver

I have only the first patch, which is now applied. Please resend second patch as it is lost somewhere.

Sam

Quoted 16 lines
 .../display/panel/visionox,rm69299.yaml       |  58 ++++
 drivers/gpu/drm/panel/Kconfig                 |   8 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-visionox-rm69299.c    | 295 ++++++++++++++++++
 4 files changed, 362 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c
Signature · 6 lines
2.25.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw

Hi Sam,

Quoted 11 lines · Sam Ravnborg

Hi Harigovindan

Quoted 5 lines · Harigovindan P

Adding support for visionox rm69299 panel driver and adding bindings for the same panel.

Harigovindan P (2):
dt-bindings: display: add visionox rm69299 panel variant drm/panel: add support for rm69299 visionox panel driver

I have only the first patch, which is now applied. Please resend second patch as it is lost somewhere.

Yes, it seems for v8, v9 and v10 only the bindings were sent, even though the cover letter and subject say it's a series of two patches.

To my knowledge the latest version of the driver patch is this:

https://patchwork.kernel.org/patch/11439689/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

Hi Matthias.

Quoted 15 lines · Matthias Kaehlcke

Hi Sam,

Quoted 11 lines · Sam Ravnborg

Hi Harigovindan

Quoted 5 lines · Harigovindan P

Adding support for visionox rm69299 panel driver and adding bindings for the same panel.

Harigovindan P (2):
dt-bindings: display: add visionox rm69299 panel variant drm/panel: add support for rm69299 visionox panel driver

I have only the first patch, which is now applied. Please resend second patch as it is lost somewhere.

Quoted 6 lines

Yes, it seems for v8, v9 and v10 only the bindings were sent, even though the cover letter and subject say it's a series of two patches.

To my knowledge the latest version of the driver patch is this:

https://patchwork.kernel.org/patch/11439689/

I did not go back and check, but I recall there was review feedback that is not yet addressed.

I applied the patch here and checkpatch was not happy:
total: 14 errors, 22 warnings, 11 checks, 314 lines checked

Many of these are trivial indent or spaces used where tabs should be used.
These needs to be fixed before the driver will be applied.

And there was too much that I just did it while applying.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw
Quoted 28 lines · Sam Ravnborg

Hi Matthias.

Quoted 15 lines · Matthias Kaehlcke

Hi Sam,

Quoted 11 lines · Sam Ravnborg

Hi Harigovindan

Quoted 5 lines · Harigovindan P

Adding support for visionox rm69299 panel driver and adding bindings for the same panel.

Harigovindan P (2):
dt-bindings: display: add visionox rm69299 panel variant drm/panel: add support for rm69299 visionox panel driver

I have only the first patch, which is now applied. Please resend second patch as it is lost somewhere.

Quoted 6 lines

Yes, it seems for v8, v9 and v10 only the bindings were sent, even though the cover letter and subject say it's a series of two patches.

To my knowledge the latest version of the driver patch is this:

https://patchwork.kernel.org/patch/11439689/

I did not go back and check, but I recall there was review feedback that is not yet addressed.

Quoted 8 lines

I applied the patch here and checkpatch was not happy:
total: 14 errors, 22 warnings, 11 checks, 314 lines checked

Many of these are trivial indent or spaces used where tabs should be used.
These needs to be fixed before the driver will be applied.

And there was too much that I just did it while applying.

Oh, I totally missed these, sure this needs to be addressed.

Harigovindan, please also double check if there is any outstanding feedback that still needs to be addressed.

Thanks

Matthias