Skip to contentSkip to conversation

RDMA/hns: Fix uninitialized variable bug

PATCH Superseded Gustavo A. R. Silva 3 participants 4 messages Mar 27, 2020 – Mar 28, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/hns: Fix uninitialized variable bug

There is a potential execution path in which variable *ret* is returned without being properly initialized, previously.

Fix this by initializing variable *ret* to -ENODEV.

Addresses-Coverity-ID: 1491917 ("Uninitialized scalar variable")

Fixes 2f49de21f3e9 ("RDMA/hns: Optimize mhop get flow for multi-hop addressing")
---
 drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/hns/hns_roce_hem.c +1 -1
index c96378718f88..3fd8100c2b56 100644
@@ -603,7 +603,7 @@ static int set_mhop_hem(struct hns_roce_dev *hr_dev,
 {
 	struct ib_device *ibdev = &hr_dev->ib_dev;
 	int step_idx;
-	int ret;
+	int ret = -ENODEV;
 
 	if (index->inited & HEM_INDEX_L0) {
 		ret = hr_dev->hw->set_hem(hr_dev, table, obj, 0);
Signature · 1 line
2.26.0
#1 lore raw
Quoted 18 lines · Gustavo A. R. Silva

There is a potential execution path in which variable *ret* is returned without being properly initialized, previously.

Fix this by initializing variable *ret* to -ENODEV.

Addresses-Coverity-ID: 1491917 ("Uninitialized scalar variable")

Fixes 2f49de21f3e9 ("RDMA/hns: Optimize mhop get flow for multi-hop addressing")
---
 drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/hns/hns_roce_hem.c +0 -0
index c96378718f88..3fd8100c2b56 100644

drivers/infiniband/hw/hns/hns_roce_hem.c static int set_mhop_hem(struct hns_roce_dev *hr_dev, · line 609

Quoted 8 lines
drivers/infiniband/hw/hns/hns_roce_hem.c +1 -1
@@ -603,7 +603,7 @@ static int set_mhop_hem(struct hns_roce_dev *hr_dev,
 {
 	struct ib_device *ibdev = &hr_dev->ib_dev;
 	int step_idx;
-	int ret;
+	int ret = -ENODEV;
 
 	if (index->inited & HEM_INDEX_L0) {
 		ret = hr_dev->hw->set_hem(hr_dev, table, obj, 0);

Hi Gustavo,

Thanks for your modification. But I check the code and I think "ret" should be initialized to 0, which means no need to set hem and it is not an error.

Weihang

#2 lore raw
Quoted 24 lines · liweihang
Quoted 23 lines · Gustavo A. R. Silva

There is a potential execution path in which variable *ret* is returned without being properly initialized, previously.

Fix this by initializing variable *ret* to -ENODEV.

Addresses-Coverity-ID: 1491917 ("Uninitialized scalar variable")

Fixes 2f49de21f3e9 ("RDMA/hns: Optimize mhop get flow for multi-hop addressing")
---
 drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/hns/hns_roce_hem.c +1 -1
index c96378718f88..3fd8100c2b56 100644
@@ -603,7 +603,7 @@ static int set_mhop_hem(struct hns_roce_dev *hr_dev,
 {
 	struct ib_device *ibdev = &hr_dev->ib_dev;
 	int step_idx;
-	int ret;
+	int ret = -ENODEV;
 
Quoted 6 lines

drivers/infiniband/hw/hns/hns_roce_hem.c static int set_mhop_hem(struct hns_roce_dev *hr_dev, · line 609

Quoted 3 lines
drivers/infiniband/hw/hns/hns_roce_hem.c +0 -0
 	if (index->inited & HEM_INDEX_L0) {
 		ret = hr_dev->hw->set_hem(hr_dev, table, obj, 0);

Hi Gustavo,

Hi Weihang,

Quoted 4 lines

Thanks for your modification. But I check the code and I think "ret" should be initialized to 0, which means no need to set hem and it is not an error.

Oh, I see. Thanks for the feedback. I'll send v2 shortly.

Thanks
--
Gustavo

#3 lore raw
In reply to liweihang
Quoted 28 lines · liweihang
Quoted 16 lines · Gustavo A. R. Silva

There is a potential execution path in which variable *ret* is returned without being properly initialized, previously.

Fix this by initializing variable *ret* to -ENODEV.

Addresses-Coverity-ID: 1491917 ("Uninitialized scalar variable")

Fixes 2f49de21f3e9 ("RDMA/hns: Optimize mhop get flow for multi-hop addressing")
 drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/hns/hns_roce_hem.c +1 -0
index c96378718f88..3fd8100c2b56 100644
+++ b/drivers/infiniband/hw/hns/hns_roce_hem.c

drivers/infiniband/hw/hns/hns_roce_hem.c static int set_mhop_hem(struct hns_roce_dev *hr_dev, · line 609

Quoted 8 lines
drivers/infiniband/hw/hns/hns_roce_hem.c +1 -1
@@ -603,7 +603,7 @@ static int set_mhop_hem(struct hns_roce_dev *hr_dev,
 {
 	struct ib_device *ibdev = &hr_dev->ib_dev;
 	int step_idx;
-	int ret;
+	int ret = -ENODEV;
 
 	if (index->inited & HEM_INDEX_L0) {
 		ret = hr_dev->hw->set_hem(hr_dev, table, obj, 0);

Hi Gustavo,

Quoted 3 lines

Thanks for your modification. But I check the code and I think "ret" should be initialized to 0, which means no need to set hem and it is not an error.

Weihang, thank you for checking, I would have taken it without your remarks :)

Jason