Skip to contentSkip to conversation

staging: sm750fb: line over 80 characters

PATCH Superseded Gokce Kuler 2 participants 2 messages Mar 28, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: sm750fb: line over 80 characters

Line is split from comma and add bottom line for 80 characters rule.

---
 drivers/staging/sm750fb/sm750.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/sm750fb/sm750.c +3 -1
index 8f305c9..092f1c6 100644
@@ -711,7 +711,9 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
 		} else {
 			output->paths = sm750_crt;
 			crtc->channel = sm750_primary;
-			/* not consider of padding stuffs for oScreen,need fix */
+			/* not consider of padding stuffs for oScreen,
+			 * need fix
+			 */
 			crtc->oScreen = sm750_dev->vidmem_size >> 1;
 			crtc->vScreen = sm750_dev->pvMem + crtc->oScreen;
 		}
Signature · 1 line
2.7.4
#1 lore raw
Quoted 1 line · Gokce Kuler

Line is split from comma and add bottom line for 80 characters rule.

"from comma" is not an important piece of information. Since comments aren't code, they can be split anywhere.

From the log message, it looks like you are doing two different things. But the second one is actually necessary because you have converted a single line comment to a multiline comment.

It would probably be clear enough just to say:

Convert a single line comment to a multiline comment to respect the 80 character rule.

Problem found using checkpatch. (if that was the case)

julia

Quoted 29 lines
---
 drivers/staging/sm750fb/sm750.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/sm750fb/sm750.c +3 -2
index 8f305c9..092f1c6 100644
@@ -711,7 +711,9 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
 		} else {
 			output->paths = sm750_crt;
 			crtc->channel = sm750_primary;
-			/* not consider of padding stuffs for oScreen,need fix */
+			/* not consider of padding stuffs for oScreen,
+			 * need fix
+			 */
 			crtc->oScreen = sm750_dev->vidmem_size >> 1;
 			crtc->vScreen = sm750_dev->pvMem + crtc->oScreen;
 		}
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200328001552.GA14914%40siyah2.