Skip to contentSkip to conversation

dt-bindings: clock: dac: syscon-icst: Remove unneeded unit name

PATCH Superseded Fabio Estevam 3 participants 3 messages Mar 28, 2020 – Jun 3, 2020

Subsystems (3)
Device tree bindings Common clk Arm integrator, versatile and realview support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 dt-bindings: clock: dac: syscon-icst: Remove unneeded unit name

The following warnings are seen with 'make dt_binding_check':

Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_vs_reg): /example-0/clock@00: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_format): /example-0/clock@00: unit name should not have leading 0s

Fix them by removing the unneeded clock unit name.

Signed-off-by Fabio Estevam <[email protected]>
---
 Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +1 -1
index de9a465096db..444aeea27db8 100644
@@ -91,7 +91,7 @@ required:
 
 examples:
   - |
-    vco1: clock@00 {
+    vco1: clock {
       compatible = "arm,impd1-vco1";
       #clock-cells = <0>;
       lock-offset = <0x08>;
Signature · 1 line
2.17.1
maintainer
#1 lore raw

Quoting Fabio Estevam (2020-03-28 11:49:58)

Quoted 9 lines

The following warnings are seen with 'make dt_binding_check':

Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_vs_reg): /example-0/clock@00: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_format): /example-0/clock@00: unit name should not have leading 0s

Fix them by removing the unneeded clock unit name.

Signed-off-by Fabio Estevam <[email protected]>

---

Rob were you going to pick this up? Doesn't look like a critical warning to fix in v5.7 final right now.

Quoted 16 lines
 Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml +1 -1
index de9a465096db..444aeea27db8 100644
@@ -91,7 +91,7 @@ required:
 
 examples:
   - |
-    vco1: clock@00 {
+    vco1: clock {
       compatible = "arm,impd1-vco1";
       #clock-cells = <0>;
       lock-offset = <0x08>;
Reviewed-by on v1 1/1
#2 lore raw
In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

The following warnings are seen with 'make dt_binding_check':

Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_vs_reg): /example-0/clock@00: node has a unit name, but no reg or ranges property Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_format): /example-0/clock@00: unit name should not have leading 0s

Fix them by removing the unneeded clock unit name.

Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij