perf build-test: Honour JOBS to override detection of
PATCH 1/1 perf build-test: Honour JOBS to override detection of
Jiri,
Ack?
----
When one does:
$ make -C tools/perf build-test
The makefile in tools/perf/tests/ will, just like the main one, detect how many cores are in the system and use it with -j.
Sometimes we may need to override that, for instance, when using icecream or distcc to use multiple machines in the build process, then we need to, as with the main makefile, use:
$ make JOBS=N -C tools/perf build-test
Fix the tests makefile to honour that.
--- tools/perf/tests/make | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
tools/perf/tests/make +7 -3
@@ -28,9 +28,13 @@ endif PARALLEL_OPT= ifeq ($(SET_PARALLEL),1) - cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null) - ifeq ($(cores),0) - cores := 1 + ifeq ($(JOBS),) + cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null) + ifeq ($(cores),0) + cores := 1 + endif + else + cores=$(JOBS) endif PARALLEL_OPT="-j$(cores)" endif
Signature · 1 line
2.25.1
Quoted 3 lines · Arnaldo Carvalho de Melo
Jiri,
Ack?
yep ;-)
jirka
Quoted 50 lines
----
When one does:
$ make -C tools/perf build-testThe makefile in
tools/perf/tests/will, just like the main one, detect how many cores are in the system and use it with -j.Sometimes we may need to override that, for instance, when using icecream or distcc to use multiple machines in the build process, then we need to, as with the main makefile, use:
$ make JOBS=N -C tools/perf build-testFix the tests makefile to honour that.
Cc Adrian Hunter <[email protected]>Cc Jiri Olsa <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>--- tools/perf/tests/make | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)tools/perf/tests/make +7
-3@@ -28,9 +28,13 @@ endif PARALLEL_OPT= ifeq ($(SET_PARALLEL),1) - cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null) - ifeq ($(cores),0) - cores := 1 + ifeq ($(JOBS),) + cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null) + ifeq ($(cores),0) + cores := 1 + endif + else + cores=$(JOBS) endif PARALLEL_OPT="-j$(cores)" endifSignature · 1 line
2.25.1
[tip: perf/urgent] perf build-test: Honour JOBS to override detection of number of cores
In reply to Arnaldo Carvalho de MeloThe following commit has been merged into the perf/urgent branch of tip:
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: 7b1642f2fc1e1f20948e806b7ce319f660633342 Gitweb: https://git.kernel.org/tip/7b1642f2fc1e1f20948e806b7ce319f660633342 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Mon, 30 Mar 2020 09:32:41 -03:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Fri, 03 Apr 2020 09:37:55 -03:00
perf build-test: Honour JOBS to override detection of number of cores
When one does:
$ make -C tools/perf build-test
The makefile in tools/perf/tests/ will, just like the main one, detect how many cores are in the system and use it with -j.
Sometimes we may need to override that, for instance, when using icecream or distcc to use multiple machines in the build process, then we need to, as with the main makefile, use:
$ make JOBS=N -C tools/perf build-test
Fix the tests makefile to honour that.
--- tools/perf/tests/make | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
tools/perf/tests/make +7 -3
@@ -28,9 +28,13 @@ endif PARALLEL_OPT= ifeq ($(SET_PARALLEL),1) - cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null) - ifeq ($(cores),0) - cores := 1 + ifeq ($(JOBS),) + cores := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null) + ifeq ($(cores),0) + cores := 1 + endif + else + cores=$(JOBS) endif PARALLEL_OPT="-j$(cores)" endif