Skip to contentSkip to conversation

mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()

PATCH Applied Wei Yang 2 participants 2 messages Mar 30, 2020 – Mar 31, 2020

Subsystems (2)
lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH v4 1/1 mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists()

Slightly simplify the code by initializing user_mask with NODE_MASK_NONE, instead of later calling nodes_clear(). This saves a line of code.

---
v4: adjust subject/description as suggested by John Hubbard
v3: adjust the commit log a little
v2: use NODE_MASK_NONE as suggested by David Hildenbrand

---
 mm/page_alloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/page_alloc.c +1 -2
index ef790dfad6aa..dfcf2682ed40 100644
@@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
 {
 	static int node_order[MAX_NUMNODES];
 	int node, load, nr_nodes = 0;
-	nodemask_t used_mask;
+	nodemask_t used_mask = NODE_MASK_NONE;
 	int local_node, prev_node;
 
 	/* NUMA-aware ordering of nodes */
 	local_node = pgdat->node_id;
 	load = nr_online_nodes;
 	prev_node = local_node;
-	nodes_clear(used_mask);
 
 	memset(node_order, 0, sizeof(node_order));
 	while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
Signature · 1 line
2.23.0
Reviewed-by on v4 1/1
#1 lore raw
Quoted 36 lines

Slightly simplify the code by initializing user_mask with NODE_MASK_NONE, instead of later calling nodes_clear(). This saves a line of code.

---
v4: adjust subject/description as suggested by John Hubbard
v3: adjust the commit log a little
v2: use NODE_MASK_NONE as suggested by David Hildenbrand

---
 mm/page_alloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/page_alloc.c +1 -3
index ef790dfad6aa..dfcf2682ed40 100644
@@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
 {
        static int node_order[MAX_NUMNODES];
        int node, load, nr_nodes = 0;
-       nodemask_t used_mask;
+       nodemask_t used_mask = NODE_MASK_NONE;
        int local_node, prev_node;
 
        /* NUMA-aware ordering of nodes */
        local_node = pgdat->node_id;
        load = nr_online_nodes;
        prev_node = local_node;
-       nodes_clear(used_mask);
 
        memset(node_order, 0, sizeof(node_order));
        while ((node = find_next_best_node(local_node, &used_mask)) >= 0) {
--
Quoted 1 line

2.23.0