netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write
Subsystems (3)
PATCH 1/1 netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write
In case memory resources for dummy_data were allocated, release them before return.
Addresses-Coverity-ID: 1491997 ("Resource leak")
--- drivers/net/netdevsim/dev.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/netdevsim/dev.c +1 -0
@@ -75,6 +75,7 @@ static ssize_t nsim_dev_take_snapshot_write(struct file *file, err =devlink_region_snapshot_id_get (devlink, &id);if (err) {pr_err ("Failed to get snapshot id\n" ); +kfree (dummy_data);return err; } err = devlink_region_snapshot_create(nsim_dev->dummy_region,
Signature · 1 line
2.23.0
Quoted 6 lines · On Mon, 30 Mar 2020 18:27:02 -0500 Gustavo A. R. Silva wrote:
In case memory resources for
dummy_datawere allocated, release them before return.Addresses-Coverity-ID: 1491997 ("Resource leak")
Fixes 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")Signed-off-by Gustavo A. R. Silva <[email protected]>
From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 30 Mar 2020 18:27:02 -0500
Quoted 6 lines
In case memory resources for
dummy_datawere allocated, release them before return.Addresses-Coverity-ID: 1491997 ("Resource leak")
Fixes 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thanks.
Quoted 12 lines
-----Original Message-----
From: Gustavo A. R. Silva <[email protected]>
Sent: Monday, March 30, 2020 4:27 PM
To: Jakub Kicinski <[email protected]>; David S. Miller <[email protected]>; Keller, Jacob E <[email protected]>; Jiri Pirko <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH net-next] netdevsim: dev: Fix memory leak innsim_dev_take_snapshot_write
Quoted 8 lines
In case memory resources for
dummy_datawere allocated, release them before return.Addresses-Coverity-ID: 1491997 ("Resource leak")
Fixes 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids havebeen used")
Signed-off-by Gustavo A. R. Silva <[email protected]>---
Ahh! Thanks!
Belated Reviewed-by: Jacob Keller <[email protected]>