Linux 4.19.106-rt46-rc1
Subsystems (2)
cover Linux 4.19.106-rt46-rc1
Dear RT Folks,
This is the RT stable review cycle of patch 4.19.106-rt46-rc1.
Please scream at me if I messed something up. Please test the patches too.
The -rc release will be uploaded to kernel.org and will be deleted when the final release is out. This is just a review release (or release candidate).
The pre-releases will not be pushed to the git repository, only the final release is.
If all goes well, this patch will be converted to the next main release on 4/3/2020.
Enjoy,
-- Steve
To build 4.19.106-rt46-rc1 directly, the following patches should be applied:
http://www.kernel.org/pub/linux/kernel/v4.x/linux-4.19.tar.xz
http://www.kernel.org/pub/linux/kernel/v4.x/patch-4.19.106.xz
http://www.kernel.org/pub/linux/kernel/projects/rt/4.19/patch-4.19.106-rt46-rc1.patch.xz
You can also build from 4.19.106-rt45 by applying the incremental patch:
http://www.kernel.org/pub/linux/kernel/projects/rt/4.19/incr/patch-4.19.106-rt45-rt46-rc1.patch.xz
Changes from 4.19.106-rt45:
---
Steven Rostedt (VMware) (2):
irq_work: Fix checking of IRQ_WORK_LAZY flag set on non PREEMPT_RT Linux 4.19.106-rt46-rc1
Tiejun Chen (1):
lib/ubsan: Remove flags parameter from calls to ubsan_prologue() and ubsan_epilogue()
----
kernel/irq_work.c | 15 ++++++++------- lib/ubsan.c | 5 ++--- localversion-rt | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-)
PATCH 3/3 Linux 4.19.106-rt46-rc1
4.19.106-rt46-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: "Steven Rostedt (VMware)" <[email protected]>
--- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
localversion-rt +1 -1
@@ -1 +1 @@ --rt45 +-rt46-rc1
Signature · 1 line
2.25.1
PATCH 2/3 irq_work: Fix checking of IRQ_WORK_LAZY flag set on non PREEMPT_RT
In reply to Steven Rostedt4.19.106-rt46-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: "Steven Rostedt (VMware)" <[email protected]>
When CONFIG_PREEMPT_RT_FULL is not set, some of the checks for using lazy_list are not properly made as the IRQ_WORK_LAZY is not checked. There's two locations that need this update, so a use_lazy_list() helper function is added and used in both locations.
--- kernel/irq_work.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
kernel/irq_work.c +8 -7
@@ -70,6 +70,12 @@ static void __irq_work_queue_local(struct irq_work *work, struct llist_head *lisarch_irq_work_raise (); } +static inline bool use_lazy_list (struct irq_work *work) +{ +return (IS_ENABLED (CONFIG_PREEMPT_RT_FULL ) && !(work->flags &IRQ_WORK_HARD_IRQ )) + || (work->flags &IRQ_WORK_LAZY ); +} +/* Enqueue the irq work @work on the current CPU */ bool irq_work_queue (struct irq_work *work) {
@@ -81,11 +87,10 @@ bool irq_work_queue(struct irq_work *work)/* Queue the entry and raise the IPI if needed. */ preempt_disable (); -if (IS_ENABLED (CONFIG_PREEMPT_RT_FULL ) && !(work->flags &IRQ_WORK_HARD_IRQ )) +if (use_lazy_list (work)) list =this_cpu_ptr (&lazy_list);else list =this_cpu_ptr (&raised_list); -__irq_work_queue_local (work, list);preempt_enable ();
@@ -106,7 +111,6 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)#else /* CONFIG_SMP: */ struct llist_head *list; -bool lazy_work, realtime =IS_ENABLED (CONFIG_PREEMPT_RT_FULL );/* All work should have been flushed before going offline */ WARN_ON_ONCE (cpu_is_offline (cpu));
@@ -116,10 +120,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)return false;preempt_disable (); - - lazy_work = work->flags &IRQ_WORK_LAZY ; - -if (lazy_work || (realtime && !(work->flags &IRQ_WORK_HARD_IRQ ))) +if (use_lazy_list (work)) list = &per_cpu (lazy_list, cpu);else list = &per_cpu (raised_list, cpu);
Signature · 1 line
2.25.1
PATCH 1/3 lib/ubsan: Remove flags parameter from calls to ubsan_prologue() and ubsan_epilogue()
In reply to Steven Rostedt4.19.106-rt46-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Tiejun Chen <[email protected]>
Fails to build with CONFIG_UBSAN=y
lib/ubsan.c: In function '__ubsan_handle_vla_bound_not_positive':lib/ubsan.c:348:2: error: too many arguments to function 'ubsan_prologue'
ubsan_prologue(&data->location, &flags);
^~~~~~~~~~~~~~lib/ubsan.c:146:13: note: declared here
static void ubsan_prologue(struct source_location *location)
^~~~~~~~~~~~~~
lib/ubsan.c:353:2: error: too many arguments to function 'ubsan_epilogue'
ubsan_epilogue(&flags);
^~~~~~~~~~~~~~lib/ubsan.c:155:13: note: declared here
static void ubsan_epilogue(void)
^~~~~~~~~~~~~~
--- lib/ubsan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
lib/ubsan.c +2 -3
@@ -339,18 +339,17 @@ EXPORT_SYMBOL(__ubsan_handle_type_mismatch_v1);void __ubsan_handle_vla_bound_not_positive (struct vla_bound_data *data,void *bound) { -unsigned long flags;char bound_str[VALUE_LENGTH ];if (suppress_report (&data->location))return ; -ubsan_prologue (&data->location, &flags); +ubsan_prologue (&data->location);val_to_string (bound_str,sizeof (bound_str), data->type, bound);pr_err ("variable length array bound value %s <= 0\n" , bound_str); -ubsan_epilogue (&flags); +ubsan_epilogue (); }EXPORT_SYMBOL (__ubsan_handle_vla_bound_not_positive);
Signature · 1 line
2.25.1
Re: [PATCH RT 2/3] irq_work: Fix checking of IRQ_WORK_LAZY flag set on non PREEMPT_RT
In reply to Steven RostedtHi!
Quoted 7 lines
4.19.106-rt46-rc1 stable review patch.
If anyone has any objections, please let me know.------------------
From: "Steven Rostedt (VMware)" <[email protected]>
Quoted 8 lines
When
CONFIG_PREEMPT_RT_FULLis not set, some of the checks for usinglazy_listare not properly made as theIRQ_WORK_LAZYis not checked. There's two locations that need this update, so ause_lazy_list()helper function is added and used in both locations.Reported-by Pavel Machek <[email protected]>Signed-off-by Steven Rostedt (VMware) <[email protected]>
Looks okay to me, thank you.
I'm currently playing with 4.4.X branch, but I'll eventually test it.
Is it possible that 4.4.X branch needs similar patch? My code review suggests so...
Best regards, Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH RT 2/3] irq_work: Fix checking of IRQ_WORK_LAZY flag set on non PREEMPT_RT
Hi Pavel,
Quoted 4 lines · Pavel Machek
I'm currently playing with 4.4.X branch, but I'll eventually test it.
Is it possible that 4.4.X branch needs similar patch? My code review suggests so...
I was waiting for Steven to post the final patch. I'll pick it up for the next v4.4-rt release.
Thanks,
Daniel
Re: [PATCH RT 2/3] irq_work: Fix checking of IRQ_WORK_LAZY flag set on non PREEMPT_RT
Hi!
Quoted 8 lines · Pavel Machek
Quoted 4 lines
I'm currently playing with 4.4.X branch, but I'll eventually test it.
Is it possible that 4.4.X branch needs similar patch? My code review suggests so...
I was waiting for Steven to post the final patch. I'll pick it up for the next v4.4-rt release.
It will not apply cleanly...
Here is version that applies to 4.4, and should compile. Not sure what other branches it should be applied to.
Best regards,
Pavel
-- cut --
From: "Steven Rostedt (VMware)" <[email protected]>
When CONFIG_PREEMPT_RT_FULL is not set, some of the checks for using lazy_list are not properly made as the IRQ_WORK_LAZY is not checked. There's two locations that need this update, so a use_lazy_list() helper function is added and used in both locations.
kernel/irq_work.c +9 -3
@@ -57,6 +57,12 @@ void __weak arch_irq_work_raise(void)*/ } +static inline bool use_lazy_list (struct irq_work *work) +{ +return (IS_ENABLED (CONFIG_PREEMPT_RT_FULL ) && !(work->flags &IRQ_WORK_HARD_IRQ )) + || (work->flags &IRQ_WORK_LAZY ); +} +#ifdef CONFIG_SMP /* * Enqueue the irq_work @work on @cpu unless it's already pending
@@ -78,7 +84,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu)if (!irq_work_claim (work))return false; -if (IS_ENABLED (CONFIG_PREEMPT_RT_FULL ) && !(work->flags &IRQ_WORK_HARD_IRQ )) +if (use_lazy_list (work)) list = &per_cpu (lazy_list, cpu);else list = &per_cpu (raised_list, cpu);
@@ -95,7 +101,7 @@ EXPORT_SYMBOL_GPL(irq_work_queue_on);bool irq_work_queue (struct irq_work *work) {struct llist_head *list; -bool lazy_work, realtime =IS_ENABLED (CONFIG_PREEMPT_RT_FULL ); +int lazy_work;/* Only queue if not already pending */ if (!irq_work_claim (work))
@@ -106,7 +112,7 @@ bool irq_work_queue(struct irq_work *work) lazy_work = work->flags &IRQ_WORK_LAZY ; -if (lazy_work || (realtime && !(work->flags &IRQ_WORK_HARD_IRQ ))) +if (use_lazy_list (work)) list =this_cpu_ptr (&lazy_list);else list =this_cpu_ptr (&raised_list);
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany