Skip to contentSkip to conversation

net: ipv6: rpl_iptunnel: Fix potential memory leak in rpl_do_srh_inline

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Mar 31, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ipv6: rpl_iptunnel: Fix potential memory leak in rpl_do_srh_inline

In case memory resources for buf were allocated, release them before return.

Addresses-Coverity-ID: 1492011 ("Resource leak")

Fixes a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
---
 net/ipv6/rpl_iptunnel.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
net/ipv6/rpl_iptunnel.c +3 -1
index 203037afe001..a49ddc6cd020 100644
@@ -155,8 +155,10 @@ static int rpl_do_srh_inline(struct sk_buff *skb, const struct rpl_lwt *rlwt,
 	hdrlen = ((csrh->hdrlen + 1) << 3);
 
 	err = skb_cow_head(skb, hdrlen + skb->mac_len);
-	if (unlikely(err))
+	if (unlikely(err)) {
+		kfree(buf);
 		return err;
+	}
 
 	skb_pull(skb, sizeof(struct ipv6hdr));
 	skb_postpull_rcsum(skb, skb_network_header(skb),
Signature · 1 line
2.26.0
maintainer Applied
#1 lore raw

From: "Gustavo A. R. Silva" <[email protected]>
Date: Tue, 31 Mar 2020 11:35:06 -0500

Quoted 6 lines

In case memory resources for buf were allocated, release them before return.

Addresses-Coverity-ID: 1492011 ("Resource leak")

Fixes a7a29f9c361f ("net: ipv6: add rpl sr tunnel")

Applied, thanks.