Skip to contentSkip to conversation

efi_loader: enable RNG if DM_RNG is enabled

PATCH New Peter Robinson 3 participants 3 messages Apr 1, 2020 – Apr 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi_loader: enable RNG if DM_RNG is enabled

Enable EFI_RNG_PROTOCOL by default if DM_RNG is set.

---

I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config has enabled both DM_RNG and UEFI.

 lib/efi_loader/Kconfig | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/Kconfig +1 -0
index 9890144d41..b9a770281e 100644
@@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND
 
 config EFI_RNG_PROTOCOL
 	bool "EFI_RNG_PROTOCOL support"
+	default y if DM_RNG
 	depends on DM_RNG
 	help
 	  Provide a EFI_RNG_PROTOCOL implementation using the hardware random
Signature · 1 line
2.26.0
#1 lore raw

PATCH 1/1 efi_loader: enable RNG if DM_RNG is enabled

Quoted 8 lines · Peter Robinson

Enable EFI_RNG_PROTOCOL by default if DM_RNG is set.

---

I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config has enabled both DM_RNG and UEFI.

-sughosh

Quoted 21 lines
 lib/efi_loader/Kconfig | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/Kconfig +1 -0
index 9890144d41..b9a770281e 100644
@@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND
 
 config EFI_RNG_PROTOCOL
        bool "EFI_RNG_PROTOCOL support"
+       default y if DM_RNG
        depends on DM_RNG
        help
          Provide a EFI_RNG_PROTOCOL implementation using the hardware

random
--
2.26.0

#2 lore raw

PATCH 1/1 efi_loader: enable RNG if DM_RNG is enabled

In reply to Peter Robinson
Quoted 16 lines · Peter Robinson

Enable EFI_RNG_PROTOCOL by default if DM_RNG is set.

---

I think it makes sense to enable EFI_RNG_PROTOCOL by default if a config has enabled both DM_RNG and UEFI.

 lib/efi_loader/Kconfig | 1 +
 1 file changed, 1 insertion(+)
lib/efi_loader/Kconfig +0 -0
index 9890144d41..b9a770281e 100644

lib/efi_loader/Kconfig config EFI_GRUB_ARM32_WORKAROUND · line 128

Quoted 4 lines
lib/efi_loader/Kconfig +1 -0
@@ -125,6 +125,7 @@ config EFI_GRUB_ARM32_WORKAROUND
 
 config EFI_RNG_PROTOCOL
 	bool "EFI_RNG_PROTOCOL support"
+	default y if DM_RNG

Thank you for your patch.

If you have 'depends on DM_RNG', there is not need for 'if DM RNG'.

You can use scripts/get_maintainer.pl to determine all addressees for a patch (Alex was missing).

Otherwise

Quoted 4 lines
lib/efi_loader/Kconfig +0 -0
 	depends on DM_RNG
 	help
 	  Provide a EFI_RNG_PROTOCOL implementation using the hardware random