Skip to contentSkip to conversation

ARM: dts: stm32: Repair AV96 board

PATCH Superseded Marek Vasut 3 participants 53 messages Apr 1, 2020 – Apr 22, 2020

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover ARM: dts: stm32: Repair AV96 board

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
ARM: dts: stm32: Repair SDMMC1 operation on AV96
ARM: dts: stm32: Repair PMIC configuration on AV96
ARM: dts: stm32: Repair PMIC interrupt on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
ARM: dts: stm32: Add QSPI NOR on AV96
ARM: dts: stm32: Add configuration EEPROM on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
ARM: dts: stm32: Enable WiFi on AV96
ARM: dts: stm32: Add alternate pinmux for USART2 pins
ARM: dts: stm32: Enable Bluetooth on AV96
ARM: dts: stm32: Add alternate pinmux for LTDC pins
ARM: dts: stm32: Add bindings for HDMI video on AV96
ARM: dts: stm32: Add alternate pinmux for SAI2 pins
ARM: dts: stm32: Add bindings for audio on AV96
ARM: dts: stm32: Add bindings for USB on AV96
ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--
 2 files changed, 571 insertions(+), 33 deletions(-)

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]

Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH v4 1/22 ARM: dts: stm32: Add alternate pinmux for ethernet RGMII

Add another mux option for DWMAC RGMII, this is used on AV96 board.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next
Rename the pinmux nodes to ethernet0_rgmii_{,sleep_}pins_c

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 51 ++++++++++++++++++++++++
 1 file changed, 51 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +51 -0
index eb85ad19c926..6fce6133d644 100644
@@ -213,6 +213,57 @@ pins1 {
 		 };
 	};
 
+	ethernet0_rgmii_pins_c: rgmii-2 {
+		pins1 {
+			pinmux = <STM32_PINMUX('G', 5, AF11)>, /* ETH_RGMII_CLK125 */
+				 <STM32_PINMUX('G', 4, AF11)>, /* ETH_RGMII_GTX_CLK */
+				 <STM32_PINMUX('B', 12, AF11)>, /* ETH_RGMII_TXD0 */
+				 <STM32_PINMUX('G', 14, AF11)>, /* ETH_RGMII_TXD1 */
+				 <STM32_PINMUX('C', 2, AF11)>, /* ETH_RGMII_TXD2 */
+				 <STM32_PINMUX('E', 2, AF11)>, /* ETH_RGMII_TXD3 */
+				 <STM32_PINMUX('G', 11, AF11)>, /* ETH_RGMII_TX_CTL */
+				 <STM32_PINMUX('C', 1, AF11)>; /* ETH_MDC */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <2>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('A', 2, AF11)>; /* ETH_MDIO */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+		pins3 {
+			pinmux = <STM32_PINMUX('C', 4, AF11)>, /* ETH_RGMII_RXD0 */
+				 <STM32_PINMUX('C', 5, AF11)>, /* ETH_RGMII_RXD1 */
+				 <STM32_PINMUX('H', 6, AF11)>, /* ETH_RGMII_RXD2 */
+				 <STM32_PINMUX('B', 1, AF11)>, /* ETH_RGMII_RXD3 */
+				 <STM32_PINMUX('A', 1, AF11)>, /* ETH_RGMII_RX_CLK */
+				 <STM32_PINMUX('A', 7, AF11)>; /* ETH_RGMII_RX_CTL */
+			bias-disable;
+		};
+	};
+
+	ethernet0_rgmii_sleep_pins_c: rgmii-sleep-2 {
+		pins1 {
+			pinmux = <STM32_PINMUX('G', 5, ANALOG)>, /* ETH_RGMII_CLK125 */
+				 <STM32_PINMUX('G', 4, ANALOG)>, /* ETH_RGMII_GTX_CLK */
+				 <STM32_PINMUX('B', 12, ANALOG)>, /* ETH_RGMII_TXD0 */
+				 <STM32_PINMUX('G', 14, ANALOG)>, /* ETH_RGMII_TXD1 */
+				 <STM32_PINMUX('C', 2, ANALOG)>, /* ETH_RGMII_TXD2 */
+				 <STM32_PINMUX('E', 2, ANALOG)>, /* ETH_RGMII_TXD3 */
+				 <STM32_PINMUX('G', 11, ANALOG)>, /* ETH_RGMII_TX_CTL */
+				 <STM32_PINMUX('A', 2, ANALOG)>, /* ETH_MDIO */
+				 <STM32_PINMUX('C', 1, ANALOG)>, /* ETH_MDC */
+				 <STM32_PINMUX('C', 4, ANALOG)>, /* ETH_RGMII_RXD0 */
+				 <STM32_PINMUX('C', 5, ANALOG)>, /* ETH_RGMII_RXD1 */
+				 <STM32_PINMUX('H', 6, ANALOG)>, /* ETH_RGMII_RXD2 */
+				 <STM32_PINMUX('B', 1, ANALOG)>, /* ETH_RGMII_RXD3 */
+				 <STM32_PINMUX('A', 1, ANALOG)>, /* ETH_RGMII_RX_CLK */
+				 <STM32_PINMUX('A', 7, ANALOG)>; /* ETH_RGMII_RX_CTL */
+		};
+	};
+
 	ethernet0_rmii_pins_a: rmii-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('G', 13, AF11)>, /* ETH1_RMII_TXD0 */
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH v4 2/22 ARM: dts: stm32: Repair ethernet operation on AV96

In reply to Marek Vasut

The AV96 RGMII uses different pinmux for ETH_RGMII_TXD0, ETH_RGMII_RXD2 and ETH_RGMII_TX_CTL. Use the correct pinmux to make ethernet operational.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next
Use renamed pinmux nodes ethernet0_rgmii_{,sleep_}pins_c

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +2 -2
index aba38950f2e9..a66b86a456c9 100644
@@ -81,8 +81,8 @@ led6 {
 
 &ethernet0 {
 	status = "okay";
-	pinctrl-0 = <&ethernet0_rgmii_pins_a>;
-	pinctrl-1 = <&ethernet0_rgmii_sleep_pins_a>;
+	pinctrl-0 = <&ethernet0_rgmii_pins_c>;
+	pinctrl-1 = <&ethernet0_rgmii_sleep_pins_c>;
 	pinctrl-names = "default", "sleep";
 	phy-mode = "rgmii";
 	max-speed = <1000>;
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH v4 3/22 ARM: dts: stm32: Add missing ethernet PHY reset on AV96

In reply to Marek Vasut

Add PHY reset GPIO on AV96 ethernet PHY.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: Drop phy-reset-duration
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +1 -0
index a66b86a456c9..a33fddd3e023 100644
@@ -87,6 +87,7 @@ &ethernet0 {
 	phy-mode = "rgmii";
 	max-speed = <1000>;
 	phy-handle = <&phy0>;
+	phy-reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
 
 	mdio0 {
 		#address-cells = <1>;
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#5 lore raw

PATCH v4 4/22 ARM: dts: stm32: Add missing ethernet PHY skews on AV96

In reply to Marek Vasut

The KS9031 PHY supports configurable PHY skews to compensate for the board routing. Fill in the correct values.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +14 -0
index a33fddd3e023..edcc57864495 100644
@@ -95,6 +95,20 @@ mdio0 {
 		compatible = "snps,dwmac-mdio";
 		phy0: ethernet-phy@7 {
 			reg = <7>;
+
+			rxc-skew-ps = <1500>;
+			rxdv-skew-ps = <540>;
+			rxd0-skew-ps = <420>;
+			rxd1-skew-ps = <420>;
+			rxd2-skew-ps = <420>;
+			rxd3-skew-ps = <420>;
+
+			txc-skew-ps = <1440>;
+			txen-skew-ps = <540>;
+			txd0-skew-ps = <420>;
+			txd1-skew-ps = <420>;
+			txd2-skew-ps = <420>;
+			txd3-skew-ps = <420>;
 		};
 	};
 };
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#6 lore raw

PATCH v4 5/22 ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins

In reply to Marek Vasut

Add another mux option for SDMMC1 direction pins, in particular SDMMC1_D123DIR, this is used on AV96 board.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: Fix SDMMC1_D123DIR AF, should be AF11
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +24 -0
index 6fce6133d644..fadf09f04f53 100644
@@ -1084,6 +1084,30 @@ pins {
 		};
 	};
 
+	sdmmc1_dir_pins_b: sdmmc1-dir-1 {
+		pins1 {
+			pinmux = <STM32_PINMUX('F', 2, AF11)>, /* SDMMC1_D0DIR */
+				 <STM32_PINMUX('E', 14, AF11)>, /* SDMMC1_D123DIR */
+				 <STM32_PINMUX('B', 9, AF11)>; /* SDMMC1_CDIR */
+			slew-rate = <1>;
+			drive-push-pull;
+			bias-pull-up;
+		};
+		pins2{
+			pinmux = <STM32_PINMUX('E', 4, AF8)>; /* SDMMC1_CKIN */
+			bias-pull-up;
+		};
+	};
+
+	sdmmc1_dir_sleep_pins_b: sdmmc1-dir-sleep-1 {
+		pins {
+			pinmux = <STM32_PINMUX('F', 2, ANALOG)>, /* SDMMC1_D0DIR */
+				 <STM32_PINMUX('E', 14, ANALOG)>, /* SDMMC1_D123DIR */
+				 <STM32_PINMUX('B', 9, ANALOG)>, /* SDMMC1_CDIR */
+				 <STM32_PINMUX('E', 4, ANALOG)>; /* SDMMC1_CKIN */
+		};
+	};
+
 	sdmmc2_b4_pins_a: sdmmc2-b4-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('B', 14, AF9)>, /* SDMMC2_D0 */
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#7 lore raw

PATCH v4 6/22 ARM: dts: stm32: Repair SDMMC1 operation on AV96

In reply to Marek Vasut

The SD uses different pinmux for the D123DIRline, use such a pinmux, otherwise there is a pinmux collision on the AV96. Add missing SD voltage regulator switch.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: Disable SDR104, it seems unstable thus far
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +18 -3
index edcc57864495..a6f21ac5a94a 100644
@@ -77,6 +77,20 @@ led6 {
 			default-state = "off";
 		};
 	};
+
+	sd_switch: regulator-sd_switch {
+		compatible = "regulator-gpio";
+		regulator-name = "sd_switch";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <2900000>;
+		regulator-type = "voltage";
+		regulator-always-on;
+
+		gpios = <&gpioi 5 GPIO_ACTIVE_HIGH>;
+		gpios-states = <0>;
+		states = <1800000 0x1>,
+			 <2900000 0x0>;
+	};
 };
 
 &ethernet0 {
@@ -304,9 +318,9 @@ &rtc {
 
 &sdmmc1 {
 	pinctrl-names = "default", "opendrain", "sleep";
-	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_a>;
-	pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
-	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
+	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;
+	pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>;
+	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>;
 	cd-gpios = <&gpioi 8 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
 	disable-wp;
 	st,sig-dir;
@@ -314,6 +328,7 @@ &sdmmc1 {
 	st,use-ckin;
 	bus-width = <4>;
 	vmmc-supply = <&vdd_sd>;
+	vqmmc-supply = <&sd_switch>;
 	status = "okay";
 };
 
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#9 lore raw

PATCH v4 7/22 ARM: dts: stm32: Repair PMIC configuration on AV96

In reply to Marek Vasut

The core and vdd PMIC buck regulators were misconfigured, which caused instability of the board and malfunction of high-speed interfaces, like the RGMII. Configure the PMIC correctly to repair these problems.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: Model the Enpirion EP53A8LQI on the DHCOR SoM as a fixed regulator
V3: Move this before the SDMMC2 patch, as there is now a dependency
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +16 -4
index a6f21ac5a94a..260410461dc8 100644
@@ -91,6 +91,17 @@ sd_switch: regulator-sd_switch {
 		states = <1800000 0x1>,
 			 <2900000 0x0>;
 	};
+
+	/* Enpirion EP3A8LQI U2 on the DHCOR */
+	vdd_io: regulator-buck-io {
+		compatible = "regulator-fixed";
+		regulator-name = "buck-io";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		regulator-boot-on;
+		vin-supply = <&vdd>;
+	};
 };
 
 &ethernet0 {
@@ -177,7 +188,7 @@ regulators {
 
 			vddcore: buck1 {
 				regulator-name = "vddcore";
-				regulator-min-microvolt = <1200000>;
+				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1350000>;
 				regulator-always-on;
 				regulator-initial-mode = <0>;
@@ -195,8 +206,8 @@ vdd_ddr: buck2 {
 
 			vdd: buck3 {
 				regulator-name = "vdd";
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2900000>;
+				regulator-max-microvolt = <2900000>;
 				regulator-always-on;
 				regulator-initial-mode = <0>;
 				regulator-over-current-protection;
@@ -274,6 +285,7 @@ vbus_otg: pwr_sw1 {
 				regulator-name = "vbus_otg";
 				interrupts = <IT_OCP_OTG 0>;
 				interrupt-parent = <&pmic>;
+				regulator-active-discharge = <1>;
 			};
 
 			vbus_sw: pwr_sw2 {
@@ -304,7 +316,7 @@ &iwdg2 {
 };
 
 &pwr_regulators {
-	vdd-supply = <&vdd>;
+	vdd-supply = <&vdd_io>;
 	vdd_3v3_usbfs-supply = <&vdd_usb>;
 };
 
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#10 lore raw

PATCH v4 8/22 ARM: dts: stm32: Repair PMIC interrupt on AV96

In reply to Marek Vasut

The PMIC interrupt line is connected to PA0 on the DHCOR SoM, fix it. This makes the POWER button on the AV96 working, and also all the other PMIC interrupts. Furthermore, scrub the bogus interrupt-parent props.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: Move this before the SDMMC2 patch
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +1 -9
index 260410461dc8..c824ff4e6127 100644
@@ -170,7 +170,7 @@ &i2c4 {
 	pmic: stpmic@33 {
 		compatible = "st,stpmic1";
 		reg = <0x33>;
-		interrupts-extended = <&exti 55 IRQ_TYPE_EDGE_FALLING>;
+		interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>;
 		interrupt-controller;
 		#interrupt-cells = <2>;
 		status = "okay";
@@ -227,7 +227,6 @@ vdda: ldo1 {
 				regulator-min-microvolt = <2900000>;
 				regulator-max-microvolt = <2900000>;
 				interrupts = <IT_CURLIM_LDO1 0>;
-				interrupt-parent = <&pmic>;
 			};
 
 			v2v8: ldo2 {
@@ -235,7 +234,6 @@ v2v8: ldo2 {
 				regulator-min-microvolt = <2800000>;
 				regulator-max-microvolt = <2800000>;
 				interrupts = <IT_CURLIM_LDO2 0>;
-				interrupt-parent = <&pmic>;
 			};
 
 			vtt_ddr: ldo3 {
@@ -249,7 +247,6 @@ vtt_ddr: ldo3 {
 			vdd_usb: ldo4 {
 				regulator-name = "vdd_usb";
 				interrupts = <IT_CURLIM_LDO4 0>;
-				interrupt-parent = <&pmic>;
 			};
 
 			vdd_sd: ldo5 {
@@ -257,7 +254,6 @@ vdd_sd: ldo5 {
 				regulator-min-microvolt = <2900000>;
 				regulator-max-microvolt = <2900000>;
 				interrupts = <IT_CURLIM_LDO5 0>;
-				interrupt-parent = <&pmic>;
 				regulator-boot-on;
 			};
 
@@ -266,7 +262,6 @@ v1v8: ldo6 {
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
 				interrupts = <IT_CURLIM_LDO6 0>;
-				interrupt-parent = <&pmic>;
 				regulator-enable-ramp-delay = <300000>;
 			};
 
@@ -278,20 +273,17 @@ vref_ddr: vref_ddr {
 			bst_out: boost {
 				regulator-name = "bst_out";
 				interrupts = <IT_OCP_BOOST 0>;
-				interrupt-parent = <&pmic>;
 			};
 
 			vbus_otg: pwr_sw1 {
 				regulator-name = "vbus_otg";
 				interrupts = <IT_OCP_OTG 0>;
-				interrupt-parent = <&pmic>;
 				regulator-active-discharge = <1>;
 			};
 
 			vbus_sw: pwr_sw2 {
 				regulator-name = "vbus_sw";
 				interrupts = <IT_OCP_SWOUT 0>;
-				interrupt-parent = <&pmic>;
 				regulator-active-discharge = <1>;
 			};
 		};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#11 lore raw

PATCH v4 9/22 ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7

In reply to Marek Vasut

Add another mux option for SDMMC2 pins 4..7, this is used on AV96 board.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +21 -0
index fadf09f04f53..98c709c08f85 100644
@@ -1247,6 +1247,27 @@ pins {
 		};
 	};
 
+	sdmmc2_d47_pins_c: sdmmc2-d47-2 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
+				 <STM32_PINMUX('A', 15, AF9)>, /* SDMMC2_D5 */
+				 <STM32_PINMUX('C', 6, AF10)>, /* SDMMC2_D6 */
+				 <STM32_PINMUX('C', 7, AF10)>; /* SDMMC2_D7 */
+			slew-rate = <1>;
+			drive-push-pull;
+			bias-pull-up;
+		};
+	};
+
+	sdmmc2_d47_sleep_pins_c: sdmmc2-d47-sleep-2 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */
+				 <STM32_PINMUX('A', 15, ANALOG)>, /* SDMMC2_D5 */
+				 <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */
+				 <STM32_PINMUX('C', 7, ANALOG)>; /* SDMMC2_D7 */
+		};
+	};
+
 	sdmmc3_b4_pins_a: sdmmc3-b4-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('F', 0, AF9)>, /* SDMMC3_D0 */
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#14 lore raw

PATCH v4 11/22 ARM: dts: stm32: Add QSPI NOR on AV96

In reply to Marek Vasut

The DH Electronics DHCOR SOM has QSPI NOR on the SoM itself, add it into the DT.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: Use spi-flash in the DT node instead of explicit model name
V3: Reduce the SPI controller window to 2 MiB, which is the flash size
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +20 -0
index df68768e8a12..5831280f78ee 100644
@@ -21,6 +21,7 @@ aliases {
 		mmc0 = &sdmmc1;
 		serial0 = &uart4;
 		serial1 = &uart7;
+		spi0 = &qspi;
 	};
 
 	chosen {
@@ -312,6 +313,25 @@ &pwr_regulators {
 	vdd_3v3_usbfs-supply = <&vdd_usb>;
 };
 
+&qspi {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&qspi_clk_pins_a &qspi_bk1_pins_a>;
+	pinctrl-1 = <&qspi_clk_sleep_pins_a &qspi_bk1_sleep_pins_a>;
+	reg = <0x58003000 0x1000>, <0x70000000 0x200000>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	flash0: spi-flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-rx-bus-width = <4>;
+		spi-max-frequency = <108000000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+	};
+};
+
 &rng1 {
 	status = "okay";
 };
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#12 lore raw

PATCH v4 10/22 ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96

In reply to Marek Vasut

Add DT node describing the eMMC attached to SDMMC2 controller of the STM32MP1 on DHCOR SoM, which is the SoM soldered on AV96.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: Connect Vcc to the enpirion output instead of 3v3 directly
Note that this patch now depends on:
mmc: mmci: Only call .post_sig_volt_switch if voltage switch happened
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +16 -0
index c824ff4e6127..df68768e8a12 100644
@@ -336,6 +336,22 @@ &sdmmc1 {
 	status = "okay";
 };
 
+&sdmmc2 {
+	pinctrl-names = "default", "opendrain", "sleep";
+	pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_b>;
+	pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_b>;
+	pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_b>;
+	bus-width = <8>;
+	mmc-ddr-1_8v;
+	no-sd;
+	no-sdio;
+	non-removable;
+	st,neg-edge;
+	vmmc-supply = <&v3v3>;
+	vqmmc-supply = <&vdd_io>;
+	status = "okay";
+};
+
 &uart4 {
 	/* On Low speed expansion header */
 	label = "LS-UART1";
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#16 lore raw

PATCH v4 12/22 ARM: dts: stm32: Add configuration EEPROM on AV96

In reply to Marek Vasut

The board has an EEPROM on the same I2C bus as PMIC, at address 0x53. The EEPROM contains the board MAC address.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +6 -0
index 5831280f78ee..b29e26eedbea 100644
@@ -301,6 +301,12 @@ watchdog {
 			status = "disabled";
 		};
 	};
+
+	eeprom@53 {
+		compatible = "atmel,24c02";
+		reg = <0x53>;
+		pagesize = <16>;
+	};
 };
 
 &iwdg2 {
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#17 lore raw

PATCH v4 13/22 ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins

In reply to Marek Vasut

Add another mux option for SDMMC3 pins, in particular PD5_SDMMC3_D2 and PD0_SDMMC3_CMD, this is used on AV96 board.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 54 ++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +54 -0
index 98c709c08f85..0f9a6b1325f9 100644
@@ -1322,6 +1322,60 @@ pins {
 		};
 	};
 
+	sdmmc3_b4_pins_b: sdmmc3-b4-1 {
+		pins1 {
+			pinmux = <STM32_PINMUX('F', 0, AF9)>, /* SDMMC3_D0 */
+				 <STM32_PINMUX('F', 4, AF9)>, /* SDMMC3_D1 */
+				 <STM32_PINMUX('D', 5, AF10)>, /* SDMMC3_D2 */
+				 <STM32_PINMUX('D', 7, AF10)>, /* SDMMC3_D3 */
+				 <STM32_PINMUX('D', 0, AF10)>; /* SDMMC3_CMD */
+			slew-rate = <1>;
+			drive-push-pull;
+			bias-pull-up;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('G', 15, AF10)>; /* SDMMC3_CK */
+			slew-rate = <2>;
+			drive-push-pull;
+			bias-pull-up;
+		};
+	};
+
+	sdmmc3_b4_od_pins_b: sdmmc3-b4-od-1 {
+		pins1 {
+			pinmux = <STM32_PINMUX('F', 0, AF9)>, /* SDMMC3_D0 */
+				 <STM32_PINMUX('F', 4, AF9)>, /* SDMMC3_D1 */
+				 <STM32_PINMUX('D', 5, AF10)>, /* SDMMC3_D2 */
+				 <STM32_PINMUX('D', 7, AF10)>; /* SDMMC3_D3 */
+			slew-rate = <1>;
+			drive-push-pull;
+			bias-pull-up;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('G', 15, AF10)>; /* SDMMC3_CK */
+			slew-rate = <2>;
+			drive-push-pull;
+			bias-pull-up;
+		};
+		pins3 {
+			pinmux = <STM32_PINMUX('D', 0, AF10)>; /* SDMMC2_CMD */
+			slew-rate = <1>;
+			drive-open-drain;
+			bias-pull-up;
+		};
+	};
+
+	sdmmc3_b4_sleep_pins_b: sdmmc3-b4-sleep-1 {
+		pins {
+			pinmux = <STM32_PINMUX('F', 0, ANALOG)>, /* SDMMC3_D0 */
+				 <STM32_PINMUX('F', 4, ANALOG)>, /* SDMMC3_D1 */
+				 <STM32_PINMUX('D', 5, ANALOG)>, /* SDMMC3_D2 */
+				 <STM32_PINMUX('D', 7, ANALOG)>, /* SDMMC3_D3 */
+				 <STM32_PINMUX('G', 15, ANALOG)>, /* SDMMC3_CK */
+				 <STM32_PINMUX('D', 0, ANALOG)>; /* SDMMC3_CMD */
+		};
+	};
+
 	spdifrx_pins_a: spdifrx-0 {
 		pins {
 			pinmux = <STM32_PINMUX('G', 12, AF8)>; /* SPDIF_IN1 */
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#18 lore raw

PATCH v4 14/22 ARM: dts: stm32: Enable WiFi on AV96

In reply to Marek Vasut

The WiFi/Bluetooth SDIO chip is attached to SDMMC3 on AV96, describe it in DT to make it available. Remove WiFi LED and turn it into a regulator, because it is a GPIO controlling the WL_REG_ON input of the WiFi chip. The LED is just an indicator connected to the same line, but not the primary function.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 38 +++++++++++++++++----
 1 file changed, 31 insertions(+), 7 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +31 -7
index b29e26eedbea..bf21480b255e 100644
@@ -65,13 +65,6 @@ led4 {
 		};
 
 		led5 {
-			label = "yellow:wifi";
-			gpios = <&gpioz 3 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "phy0tx";
-			default-state = "off";
-		};
-
-		led6 {
 			label = "blue:bt";
 			gpios = <&gpioz 6 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "bluetooth-power";
@@ -103,6 +96,17 @@ vdd_io: regulator-buck-io {
 		regulator-boot-on;
 		vin-supply = <&vdd>;
 	};
+
+	wlan_pwr: regulator-wlan {
+		compatible = "regulator-fixed";
+
+		regulator-name = "wl-reg";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpios = <&gpioz 3 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };
 
 &ethernet0 {
@@ -378,6 +382,26 @@ &sdmmc2 {
 	status = "okay";
 };
 
+&sdmmc3 {
+	pinctrl-names = "default", "opendrain", "sleep";
+	pinctrl-0 = <&sdmmc3_b4_pins_b>;
+	pinctrl-1 = <&sdmmc3_b4_od_pins_b>;
+	pinctrl-2 = <&sdmmc3_b4_sleep_pins_b>;
+	broken-cd;
+	non-removable;
+	st,neg-edge;
+	bus-width = <4>;
+	vmmc-supply = <&wlan_pwr>;
+	status = "okay";
+
+	#address-cells = <1>;
+	#size-cells = <0>;
+	brcmf: bcrmf@1 {
+		reg = <1>;
+		compatible = "brcm,bcm4329-fmac";
+	};
+};
+
 &uart4 {
 	/* On Low speed expansion header */
 	label = "LS-UART1";
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#19 lore raw

PATCH v4 15/22 ARM: dts: stm32: Add alternate pinmux for USART2 pins

In reply to Marek Vasut

Add mux option for USART2 pins, this is used on AV96 board.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +24 -0
index 0f9a6b1325f9..f4bf87bd9b7e 100644
@@ -1389,6 +1389,30 @@ pins {
 		};
 	};
 
+	usart2_pins_a: usart2-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('F', 5, AF7)>, /* USART2_TX */
+				 <STM32_PINMUX('D', 4, AF7)>; /* USART2_RTS */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('D', 6, AF7)>, /* USART2_RX */
+				 <STM32_PINMUX('D', 3, AF7)>; /* USART2_CTS_NSS */
+			bias-disable;
+		};
+	};
+
+	usart2_sleep_pins_a: usart2-sleep-0 {
+		pins {
+			pinmux = <STM32_PINMUX('F', 5, ANALOG)>, /* USART2_TX */
+				 <STM32_PINMUX('D', 4, ANALOG)>, /* USART2_RTS */
+				 <STM32_PINMUX('D', 6, ANALOG)>, /* USART2_RX */
+				 <STM32_PINMUX('D', 3, ANALOG)>; /* USART2_CTS_NSS */
+		};
+	};
+
 	usart3_pins_a: usart3-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('B', 10, AF7)>; /* USART3_TX */
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#21 lore raw

PATCH v4 17/22 ARM: dts: stm32: Add alternate pinmux for LTDC pins

In reply to Marek Vasut

Add new mux option for LTDC pins, this is used on AV96 board.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: - Rebase on stm32-next
- Rename to ltdc.*pins_d

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 74 ++++++++++++++++++++++++
 1 file changed, 74 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +74 -0
index f4bf87bd9b7e..c3a7402860af 100644
@@ -662,6 +662,80 @@ pins1 {
 		};
 	};
 
+	ltdc_pins_d: ltdc-3 {
+		pins1 {
+			pinmux = <STM32_PINMUX('G',  7, AF14)>; /* LCD_CLK */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <3>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('I', 10, AF14)>, /* LCD_HSYNC */
+				 <STM32_PINMUX('I',  9, AF14)>, /* LCD_VSYNC */
+				 <STM32_PINMUX('E', 13, AF14)>, /* LCD_DE */
+				 <STM32_PINMUX('G', 13, AF14)>, /* LCD_R0 */
+				 <STM32_PINMUX('H',  3, AF14)>, /* LCD_R1 */
+				 <STM32_PINMUX('H',  8, AF14)>, /* LCD_R2 */
+				 <STM32_PINMUX('H',  9, AF14)>, /* LCD_R3 */
+				 <STM32_PINMUX('A',  5, AF14)>, /* LCD_R4 */
+				 <STM32_PINMUX('H', 11, AF14)>, /* LCD_R5 */
+				 <STM32_PINMUX('H', 12, AF14)>, /* LCD_R6 */
+				 <STM32_PINMUX('E', 15, AF14)>, /* LCD_R7 */
+				 <STM32_PINMUX('E',  5, AF14)>, /* LCD_G0 */
+				 <STM32_PINMUX('B',  0, AF14)>, /* LCD_G1 */
+				 <STM32_PINMUX('H', 13, AF14)>, /* LCD_G2 */
+				 <STM32_PINMUX('E', 11, AF14)>, /* LCD_G3 */
+				 <STM32_PINMUX('H', 15, AF14)>, /* LCD_G4 */
+				 <STM32_PINMUX('H',  4,  AF9)>, /* LCD_G5 */
+				 <STM32_PINMUX('I', 11,  AF9)>, /* LCD_G6 */
+				 <STM32_PINMUX('G',  8, AF14)>, /* LCD_G7 */
+				 <STM32_PINMUX('D',  9, AF14)>, /* LCD_B0 */
+				 <STM32_PINMUX('G', 12, AF14)>, /* LCD_B1 */
+				 <STM32_PINMUX('G', 10, AF14)>, /* LCD_B2 */
+				 <STM32_PINMUX('D', 10, AF14)>, /* LCD_B3 */
+				 <STM32_PINMUX('E', 12, AF14)>, /* LCD_B4 */
+				 <STM32_PINMUX('A',  3, AF14)>, /* LCD_B5 */
+				 <STM32_PINMUX('B',  8, AF14)>, /* LCD_B6 */
+				 <STM32_PINMUX('I',  7, AF14)>; /* LCD_B7 */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <2>;
+		};
+	};
+
+	ltdc_sleep_pins_d: ltdc-sleep-3 {
+		pins {
+			pinmux = <STM32_PINMUX('G',  7, ANALOG)>, /* LCD_CLK */
+				 <STM32_PINMUX('I', 10, ANALOG)>, /* LCD_HSYNC */
+				 <STM32_PINMUX('I',  9, ANALOG)>, /* LCD_VSYNC */
+				 <STM32_PINMUX('E', 13, ANALOG)>, /* LCD_DE */
+				 <STM32_PINMUX('G', 13, ANALOG)>, /* LCD_R0 */
+				 <STM32_PINMUX('H',  3, ANALOG)>, /* LCD_R1 */
+				 <STM32_PINMUX('H',  8, ANALOG)>, /* LCD_R2 */
+				 <STM32_PINMUX('H',  9, ANALOG)>, /* LCD_R3 */
+				 <STM32_PINMUX('A',  5, ANALOG)>, /* LCD_R4 */
+				 <STM32_PINMUX('H', 11, ANALOG)>, /* LCD_R5 */
+				 <STM32_PINMUX('H', 12, ANALOG)>, /* LCD_R6 */
+				 <STM32_PINMUX('E', 15, ANALOG)>, /* LCD_R7 */
+				 <STM32_PINMUX('E',  5, ANALOG)>, /* LCD_G0 */
+				 <STM32_PINMUX('B',  0, ANALOG)>, /* LCD_G1 */
+				 <STM32_PINMUX('H', 13, ANALOG)>, /* LCD_G2 */
+				 <STM32_PINMUX('E', 11, ANALOG)>, /* LCD_G3 */
+				 <STM32_PINMUX('H', 15, ANALOG)>, /* LCD_G4 */
+				 <STM32_PINMUX('H',  4, ANALOG)>, /* LCD_G5 */
+				 <STM32_PINMUX('I', 11, ANALOG)>, /* LCD_G6 */
+				 <STM32_PINMUX('G',  8, ANALOG)>, /* LCD_G7 */
+				 <STM32_PINMUX('D',  9, ANALOG)>, /* LCD_B0 */
+				 <STM32_PINMUX('G', 12, ANALOG)>, /* LCD_B1 */
+				 <STM32_PINMUX('G', 10, ANALOG)>, /* LCD_B2 */
+				 <STM32_PINMUX('D', 10, ANALOG)>, /* LCD_B3 */
+				 <STM32_PINMUX('E', 12, ANALOG)>, /* LCD_B4 */
+				 <STM32_PINMUX('A',  3, ANALOG)>, /* LCD_B5 */
+				 <STM32_PINMUX('B',  8, ANALOG)>, /* LCD_B6 */
+				 <STM32_PINMUX('I',  7, ANALOG)>; /* LCD_B7 */
+		};
+	};
+
 	m_can1_pins_a: m-can1-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('H', 13, AF9)>; /* CAN1_TX */
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#20 lore raw

PATCH v4 16/22 ARM: dts: stm32: Enable Bluetooth on AV96

In reply to Marek Vasut

The WiFi/Bluetooth chip is attached to USART2 on AV96 as well, describe it in DT to make it available. Remove BT LED and turn it into a shutdown GPIO, because the GPIO line controls the BT_REG_ON signal. The LED is just an indicator connected to the same line, but not the primary function.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 23 ++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +16 -7
index bf21480b255e..faa9a5185ddd 100644
@@ -21,6 +21,7 @@ aliases {
 		mmc0 = &sdmmc1;
 		serial0 = &uart4;
 		serial1 = &uart7;
+		serial2 = &usart2;
 		spi0 = &qspi;
 	};
 
@@ -63,13 +64,6 @@ led4 {
 			default-state = "off";
 			panic-indicator;
 		};
-
-		led5 {
-			label = "blue:bt";
-			gpios = <&gpioz 6 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "bluetooth-power";
-			default-state = "off";
-		};
 	};
 
 	sd_switch: regulator-sd_switch {
@@ -417,3 +411,18 @@ &uart7 {
 	pinctrl-0 = <&uart7_pins_a>;
 	status = "okay";
 };
+
+/* Bluetooth */
+&usart2 {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&usart2_pins_a>;
+	pinctrl-1 = <&usart2_sleep_pins_a>;
+	st,hw-flow-ctrl;
+	status = "okay";
+
+	bluetooth {
+		compatible = "brcm,bcm43438-bt";
+		max-speed = <3000000>;
+		shutdown-gpios = <&gpioz 6 GPIO_ACTIVE_HIGH>;
+	};
+};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#24 lore raw

PATCH v4 19/22 ARM: dts: stm32: Add alternate pinmux for SAI2 pins

In reply to Marek Vasut

Add new mux option for SAI2 pins, this is used on AV96 board.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V4: New patch

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 32 ++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +32 -0
index c3a7402860af..aeddcaadb829 100644
@@ -1028,6 +1028,25 @@ pins {
 		};
 	};
 
+	sai2a_pins_c: sai2a-4 {
+		pins {
+			pinmux = <STM32_PINMUX('D', 13, AF10)>, /* SAI2_SCK_A */
+				 <STM32_PINMUX('D', 11, AF10)>, /* SAI2_SD_A */
+				 <STM32_PINMUX('D', 12, AF10)>; /* SAI2_FS_A */
+			slew-rate = <0>;
+			drive-push-pull;
+			bias-disable;
+		};
+	};
+
+	sai2a_sleep_pins_c: sai2a-5 {
+		pins {
+			pinmux = <STM32_PINMUX('D', 13, ANALOG)>, /* SAI2_SCK_A */
+				 <STM32_PINMUX('D', 11, ANALOG)>, /* SAI2_SD_A */
+				 <STM32_PINMUX('D', 12, ANALOG)>; /* SAI2_FS_A */
+		};
+	};
+
 	sai2b_pins_a: sai2b-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('E', 12, AF10)>, /* SAI2_SCK_B */
@@ -1065,6 +1084,19 @@ pins {
 		};
 	};
 
+	sai2b_pins_c: sai2a-4 {
+		pins1 {
+			pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */
+			bias-disable;
+		};
+	};
+
+	sai2b_sleep_pins_c: sai2a-sleep-5 {
+		pins {
+			pinmux = <STM32_PINMUX('F', 11, ANALOG)>; /* SAI2_SD_B */
+		};
+	};
+
 	sai4a_pins_a: sai4a-0 {
 		pins {
 			pinmux = <STM32_PINMUX('B', 5, AF10)>; /* SAI4_SD_A */
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#22 lore raw

PATCH v4 18/22 ARM: dts: stm32: Add bindings for HDMI video on AV96

In reply to Marek Vasut

Fill in the HDMI video pipeline from AV96 into the DT.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next
Use renamed ltdc_*_pins_d

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 79 +++++++++++++++++++++
 1 file changed, 79 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +79 -0
index faa9a5185ddd..756e79f2255a 100644
@@ -25,10 +25,28 @@ aliases {
 		spi0 = &qspi;
 	};
 
+	/* XTal Q1 */
+	cec_clock: clk-cec-fixed {
+		#clock-cells = <0>;
+		compatible = "fixed-clock";
+		clock-frequency = <24000000>;
+	};
+
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con: endpoint {
+				remote-endpoint = <&adv7513_out>;
+			};
+		};
+	};
+
 	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xc0000000 0x40000000>;
@@ -300,6 +318,50 @@ watchdog {
 		};
 	};
 
+	hdmi-transmitter@3d {
+		compatible = "adi,adv7513";
+		reg = <0x3d>, <0x2d>, <0x4d>, <0x5d>;
+		reg-names = "main", "cec", "edid", "packet";
+		clocks = <&cec_clock>;
+		clock-names = "cec";
+
+		avdd-supply = <&v3v3>;
+		dvdd-supply = <&v3v3>;
+		pvdd-supply = <&v3v3>;
+		dvdd-3v-supply = <&v3v3>;
+		bgvdd-supply = <&v3v3>;
+
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-parent = <&gpiog>;
+
+		status = "okay";
+
+		adi,input-depth = <8>;
+		adi,input-colorspace = "rgb";
+		adi,input-clock = "1x";
+		adi,input-style = <1>;
+		adi,input-justification = "evenly";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				adv7513_in: endpoint {
+					remote-endpoint = <&ltdc_ep0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				adv7513_out: endpoint {
+					remote-endpoint = <&hdmi_con>;
+				};
+			};
+		};
+	};
+
 	eeprom@53 {
 		compatible = "atmel,24c02";
 		reg = <0x53>;
@@ -312,6 +374,23 @@ &iwdg2 {
 	status = "okay";
 };
 
+&ltdc {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&ltdc_pins_d>;
+	pinctrl-1 = <&ltdc_sleep_pins_d>;
+	status = "okay";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ltdc_ep0_out: endpoint@0 {
+			reg = <0>;
+			remote-endpoint = <&adv7513_in>;
+		};
+	};
+};
+
 &pwr_regulators {
 	vdd-supply = <&vdd_io>;
 	vdd_3v3_usbfs-supply = <&vdd_usb>;
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#25 lore raw

PATCH v4 20/22 ARM: dts: stm32: Add bindings for audio on AV96

In reply to Marek Vasut

Fill in the bindings for HDMI audio on AV96, this permits audio playback via attached HDMI device if such device supports it.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 39 +++++++++++++++++++++
 1 file changed, 39 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +39 -0
index 756e79f2255a..2f5a53e1b50d 100644
@@ -98,6 +98,13 @@ sd_switch: regulator-sd_switch {
 			 <2900000 0x0>;
 	};
 
+	sound {
+		compatible = "audio-graph-card";
+		label = "STM32MP1-AV96-HDMI";
+		dais = <&sai2a_port>;
+		status = "okay";
+	};
+
 	/* Enpirion EP3A8LQI U2 on the DHCOR */
 	vdd_io: regulator-buck-io {
 		compatible = "regulator-fixed";
@@ -359,6 +366,13 @@ adv7513_out: endpoint {
 					remote-endpoint = <&hdmi_con>;
 				};
 			};
+
+			port@2 {
+				reg = <2>;
+				adv7513_i2s0: endpoint {
+					remote-endpoint = <&sai2a_endpoint>;
+				};
+			};
 		};
 	};
 
@@ -423,6 +437,31 @@ &rtc {
 	status = "okay";
 };
 
+&sai2 {
+	clocks = <&rcc SAI2>, <&rcc PLL3_Q>, <&rcc PLL3_R>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&sai2a_pins_c>;
+	pinctrl-1 = <&sai2a_sleep_pins_c>;
+	clock-names = "pclk", "x8k", "x11k";
+	status = "okay";
+
+	sai2a: audio-controller@4400b004 {
+		#clock-cells = <0>;
+		dma-names = "tx";
+		clocks = <&rcc SAI2_K>;
+		clock-names = "sai_ck";
+		status = "okay";
+
+		sai2a_port: port {
+			sai2a_endpoint: endpoint {
+				remote-endpoint = <&adv7513_i2s0>;
+				format = "i2s";
+				mclk-fs = <256>;
+			};
+		};
+	};
+};
+
 &sdmmc1 {
 	pinctrl-names = "default", "opendrain", "sleep";
 	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#26 lore raw

PATCH v4 21/22 ARM: dts: stm32: Add bindings for USB on AV96

In reply to Marek Vasut

Fill in the bindings for USB host and gadget on AV96.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 31 +++++++++++++++++++++
 1 file changed, 31 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +31 -0
index 2f5a53e1b50d..31f23e60629f 100644
@@ -544,3 +544,34 @@ bluetooth {
 		shutdown-gpios = <&gpioz 6 GPIO_ACTIVE_HIGH>;
 	};
 };
+
+&usbh_ehci {
+	phys = <&usbphyc_port0>;
+	phy-names = "usb";
+	status = "okay";
+};
+
+&usbotg_hs {
+	pinctrl-0 = <&usbotg_hs_pins_a>;
+	pinctrl-names = "default";
+	phy-names = "usb2-phy";
+	phys = <&usbphyc_port1 0>;
+	status = "okay";
+	vbus-supply = <&vbus_otg>;
+};
+
+&usbphyc {
+	status = "okay";
+};
+
+&usbphyc_port0 {
+	phy-supply = <&vdd_usb>;
+	vdda1v1-supply = <&reg11>;
+	vdda1v8-supply = <&reg18>;
+};
+
+&usbphyc_port1 {
+	phy-supply = <&vdd_usb>;
+	vdda1v1-supply = <&reg11>;
+	vdda1v8-supply = <&reg18>;
+};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#36 lore raw

PATCH v4 22/22 ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

In reply to Marek Vasut

The LED labels do not match the silkscreen on the board, fix it.

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: No change
V3: No change

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +3 -3
index 31f23e60629f..9fcc15b6e76d 100644
@@ -55,21 +55,21 @@ memory@c0000000 {
 	led {
 		compatible = "gpio-leds";
 		led1 {
-			label = "green:user1";
+			label = "green:user0";
 			gpios = <&gpioz 7 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 			default-state = "off";
 		};
 
 		led2 {
-			label = "green:user2";
+			label = "green:user1";
 			gpios = <&gpiof 3 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "mmc0";
 			default-state = "off";
 		};
 
 		led3 {
-			label = "green:user3";
+			label = "green:user2";
 			gpios = <&gpiog 0 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "mmc1";
 			default-state = "off";
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#38 lore raw
In reply to Marek Vasut

Hi Marek,

Quoted 3 lines · Marek Vasut

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Can you please share a git tree with all these patches? These are not applying cleanly on top of mainline/master or linux-next/master.

Thanks,
Mani

Quoted 28 lines

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
ARM: dts: stm32: Repair SDMMC1 operation on AV96
ARM: dts: stm32: Repair PMIC configuration on AV96
ARM: dts: stm32: Repair PMIC interrupt on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
ARM: dts: stm32: Add QSPI NOR on AV96
ARM: dts: stm32: Add configuration EEPROM on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
ARM: dts: stm32: Enable WiFi on AV96
ARM: dts: stm32: Add alternate pinmux for USART2 pins
ARM: dts: stm32: Enable Bluetooth on AV96
ARM: dts: stm32: Add alternate pinmux for LTDC pins
ARM: dts: stm32: Add bindings for HDMI video on AV96
ARM: dts: stm32: Add alternate pinmux for SAI2 pins
ARM: dts: stm32: Add bindings for audio on AV96
ARM: dts: stm32: Add bindings for USB on AV96
ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--
 2 files changed, 571 insertions(+), 33 deletions(-)
Quoted 11 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]

Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#39 lore raw
Quoted 1 line · Manivannan Sadhasivam

Hi Marek,

Hi,

Quoted 7 lines · Marek Vasut
Quoted 3 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Can you please share a git tree with all these patches? These are not applying cleanly on top of mainline/master or linux-next/master.

Alex asked for them to be rebased on
git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
branch
stm32-next

So that's where they apply.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#40 lore raw
Quoted 10 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi Marek,

Hi,

Quoted 5 lines · Marek Vasut
Quoted 3 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Quoted 8 lines
Quoted 2 lines

Can you please share a git tree with all these patches? These are not applying cleanly on top of mainline/master or linux-next/master.

Alex asked for them to be rebased on
git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
branch
stm32-next

Thanks, I'm able to build with your patches. Btw, I just found that the current mainline versions of u-boot and Linux kernel are certainly broken on old Avenger96 (588-100) as well.

u-boot doesn't boot while linux kernel has MMC2 and Ethernet broken as you reported. However, checking out the commit which added Avenger96 board support in both projects works fine.

So this clearly tells that there is a regression which caused the board support to be broken with mainline u-boot and kernel. I didn't try to find the offending commit(s) as the support for STM32MP1 got matured in both the projects. But we can go ahead with your patches.

I will review the remaining patches tomorrow.

Thanks,
Mani

Quoted 1 line

So that's where they apply.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#41 lore raw
Quoted 20 lines · Manivannan Sadhasivam
Quoted 10 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi Marek,

Hi,

Quoted 5 lines · Marek Vasut
Quoted 3 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Quoted 8 lines
Quoted 2 lines

Can you please share a git tree with all these patches? These are not applying cleanly on top of mainline/master or linux-next/master.

Alex asked for them to be rebased on
git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
branch
stm32-next

Quoted 3 lines

Thanks, I'm able to build with your patches. Btw, I just found that the current mainline versions of u-boot and Linux kernel are certainly broken on old Avenger96 (588-100) as well.

Considering the difference between the prototype board and the 588-200 production board, that's quite possible. Are you willing to test things on the 588-100 board ? If so, then we can try and support the 588-100 too.

Quoted 3 lines

u-boot doesn't boot while linux kernel has MMC2 and Ethernet broken as you reported. However, checking out the commit which added Avenger96 board support in both projects works fine.

At least
35a54d41d9d4 ("ARM: dts: stm32mp1: sync device tree with v5.2-rc4") in U-Boot broke the old board.

But that should all be fixed for the upcoming U-Boot release in master already (for 588-200).

The rest is a lot of incorrect pinmux in both, fixed in U-Boot already, fixed by this set for Linux.

Quoted 6 lines

So this clearly tells that there is a regression which caused the board support to be broken with mainline u-boot and kernel. I didn't try to find the offending commit(s) as the support for STM32MP1 got matured in both the projects. But we can go ahead with your patches.

I will review the remaining patches tomorrow

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#42 lore raw
Quoted 21 lines · Marek Vasut
Quoted 20 lines · Manivannan Sadhasivam
Quoted 18 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi Marek,

Hi,

Quoted 7 lines · Marek Vasut
Quoted 3 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Can you please share a git tree with all these patches? These are not applying cleanly on top of mainline/master or linux-next/master.

Alex asked for them to be rebased on
git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
branch
stm32-next

Quoted 8 lines
Quoted 3 lines

Thanks, I'm able to build with your patches. Btw, I just found that the current mainline versions of u-boot and Linux kernel are certainly broken on old Avenger96 (588-100) as well.

Considering the difference between the prototype board and the 588-200 production board, that's quite possible. Are you willing to test things on the 588-100 board ? If so, then we can try and support the 588-100 too.

I can but looks like DH Electronics doesn't want to support 588-100. You can check with them!

Quoted 8 lines
Quoted 3 lines

u-boot doesn't boot while linux kernel has MMC2 and Ethernet broken as you reported. However, checking out the commit which added Avenger96 board support in both projects works fine.

At least
35a54d41d9d4 ("ARM: dts: stm32mp1: sync device tree with v5.2-rc4") in U-Boot broke the old board.

Quoted 6 lines

But that should all be fixed for the upcoming U-Boot release in master already (for 588-200).

The rest is a lot of incorrect pinmux in both, fixed in U-Boot already, fixed by this set for Linux.

Yeah. Let me have a look.

Thanks,
Mani

Quoted 6 lines
Quoted 6 lines

So this clearly tells that there is a regression which caused the board support to be broken with mainline u-boot and kernel. I didn't try to find the offending commit(s) as the support for STM32MP1 got matured in both the projects. But we can go ahead with your patches.

I will review the remaining patches tomorrow

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v4 3/22
#4 lore raw

Re: [PATCH V4 03/22] ARM: dts: stm32: Add missing ethernet PHY reset on AV96

In reply to Marek Vasut
Quoted 3 lines · Marek Vasut

Add PHY reset GPIO on AV96 ethernet PHY.

Thanks,
Mani

Quoted 30 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: No change
V3: Drop phy-reset-duration
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +1 -0
index a66b86a456c9..a33fddd3e023 100644
@@ -87,6 +87,7 @@ &ethernet0 {
 	phy-mode = "rgmii";
 	max-speed = <1000>;
 	phy-handle = <&phy0>;
+	phy-reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
 
 	mdio0 {
 		#address-cells = <1>;
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v4 6/22
#8 lore raw

Re: [PATCH V4 06/22] ARM: dts: stm32: Repair SDMMC1 operation on AV96

In reply to Marek Vasut
Quoted 5 lines · Marek Vasut

The SD uses different pinmux for the D123DIRline, use such a pinmux, otherwise there is a pinmux collision on the AV96. Add missing SD voltage regulator switch.

Thanks,
Mani

Quoted 64 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: Disable SDR104, it seems unstable thus far
V3: No change
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +18 -3
index edcc57864495..a6f21ac5a94a 100644
@@ -77,6 +77,20 @@ led6 {
 			default-state = "off";
 		};
 	};
+
+	sd_switch: regulator-sd_switch {
+		compatible = "regulator-gpio";
+		regulator-name = "sd_switch";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <2900000>;
+		regulator-type = "voltage";
+		regulator-always-on;
+
+		gpios = <&gpioi 5 GPIO_ACTIVE_HIGH>;
+		gpios-states = <0>;
+		states = <1800000 0x1>,
+			 <2900000 0x0>;
+	};
 };
 
 &ethernet0 {
@@ -304,9 +318,9 @@ &rtc {
 
 &sdmmc1 {
 	pinctrl-names = "default", "opendrain", "sleep";
-	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_a>;
-	pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
-	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
+	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;
+	pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>;
+	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>;
 	cd-gpios = <&gpioi 8 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
 	disable-wp;
 	st,sig-dir;
@@ -314,6 +328,7 @@ &sdmmc1 {
 	st,use-ckin;
 	bus-width = <4>;
 	vmmc-supply = <&vdd_sd>;
+	vqmmc-supply = <&sd_switch>;
 	status = "okay";
 };
 
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v4 10/22
#13 lore raw

Re: [PATCH V4 10/22] ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96

In reply to Marek Vasut
Quoted 4 lines · Marek Vasut

Add DT node describing the eMMC attached to SDMMC2 controller of the STM32MP1 on DHCOR SoM, which is the SoM soldered on AV96.

Thanks,
Mani

Quoted 47 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: No change
V3: Connect Vcc to the enpirion output instead of 3v3 directly
Note that this patch now depends on:
mmc: mmci: Only call .post_sig_volt_switch if voltage switch happened
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +16 -0
index c824ff4e6127..df68768e8a12 100644
@@ -336,6 +336,22 @@ &sdmmc1 {
 	status = "okay";
 };
 
+&sdmmc2 {
+	pinctrl-names = "default", "opendrain", "sleep";
+	pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_b>;
+	pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_b>;
+	pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_b>;
+	bus-width = <8>;
+	mmc-ddr-1_8v;
+	no-sd;
+	no-sdio;
+	non-removable;
+	st,neg-edge;
+	vmmc-supply = <&v3v3>;
+	vqmmc-supply = <&vdd_io>;
+	status = "okay";
+};
+
 &uart4 {
 	/* On Low speed expansion header */
 	label = "LS-UART1";
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v4 11/22
#15 lore raw

Re: [PATCH V4 11/22] ARM: dts: stm32: Add QSPI NOR on AV96

In reply to Marek Vasut
Quoted 4 lines · Marek Vasut

The DH Electronics DHCOR SOM has QSPI NOR on the SoM itself, add it into the DT.

Thanks,
Mani

Quoted 56 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: Use spi-flash in the DT node instead of explicit model name
V3: Reduce the SPI controller window to 2 MiB, which is the flash size
V4: Rebase on stm32-next

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +20 -0
index df68768e8a12..5831280f78ee 100644
@@ -21,6 +21,7 @@ aliases {
 		mmc0 = &sdmmc1;
 		serial0 = &uart4;
 		serial1 = &uart7;
+		spi0 = &qspi;
 	};
 
 	chosen {
@@ -312,6 +313,25 @@ &pwr_regulators {
 	vdd_3v3_usbfs-supply = <&vdd_usb>;
 };
 
+&qspi {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&qspi_clk_pins_a &qspi_bk1_pins_a>;
+	pinctrl-1 = <&qspi_clk_sleep_pins_a &qspi_bk1_sleep_pins_a>;
+	reg = <0x58003000 0x1000>, <0x70000000 0x200000>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	flash0: spi-flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-rx-bus-width = <4>;
+		spi-max-frequency = <108000000>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+	};
+};
+
 &rng1 {
 	status = "okay";
 };
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v4 18/22
#23 lore raw

Re: [PATCH V4 18/22] ARM: dts: stm32: Add bindings for HDMI video on AV96

In reply to Marek Vasut
Quoted 3 lines · Marek Vasut

Fill in the HDMI video pipeline from AV96 into the DT.

Thanks,
Mani

Quoted 127 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: No change
V3: No change
V4: Rebase on stm32-next
Use renamed ltdc_*_pins_d

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 79 +++++++++++++++++++++
 1 file changed, 79 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +79 -0
index faa9a5185ddd..756e79f2255a 100644
@@ -25,10 +25,28 @@ aliases {
 		spi0 = &qspi;
 	};
 
+	/* XTal Q1 */
+	cec_clock: clk-cec-fixed {
+		#clock-cells = <0>;
+		compatible = "fixed-clock";
+		clock-frequency = <24000000>;
+	};
+
 	chosen {
 		stdout-path = "serial0:115200n8";
 	};
 
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con: endpoint {
+				remote-endpoint = <&adv7513_out>;
+			};
+		};
+	};
+
 	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xc0000000 0x40000000>;
@@ -300,6 +318,50 @@ watchdog {
 		};
 	};
 
+	hdmi-transmitter@3d {
+		compatible = "adi,adv7513";
+		reg = <0x3d>, <0x2d>, <0x4d>, <0x5d>;
+		reg-names = "main", "cec", "edid", "packet";
+		clocks = <&cec_clock>;
+		clock-names = "cec";
+
+		avdd-supply = <&v3v3>;
+		dvdd-supply = <&v3v3>;
+		pvdd-supply = <&v3v3>;
+		dvdd-3v-supply = <&v3v3>;
+		bgvdd-supply = <&v3v3>;
+
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-parent = <&gpiog>;
+
+		status = "okay";
+
+		adi,input-depth = <8>;
+		adi,input-colorspace = "rgb";
+		adi,input-clock = "1x";
+		adi,input-style = <1>;
+		adi,input-justification = "evenly";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				adv7513_in: endpoint {
+					remote-endpoint = <&ltdc_ep0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				adv7513_out: endpoint {
+					remote-endpoint = <&hdmi_con>;
+				};
+			};
+		};
+	};
+
 	eeprom@53 {
 		compatible = "atmel,24c02";
 		reg = <0x53>;
@@ -312,6 +374,23 @@ &iwdg2 {
 	status = "okay";
 };
 
+&ltdc {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&ltdc_pins_d>;
+	pinctrl-1 = <&ltdc_sleep_pins_d>;
+	status = "okay";
+
+	port {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ltdc_ep0_out: endpoint@0 {
+			reg = <0>;
+			remote-endpoint = <&adv7513_in>;
+		};
+	};
+};
+
 &pwr_regulators {
 	vdd-supply = <&vdd_io>;
 	vdd_3v3_usbfs-supply = <&vdd_usb>;
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#27 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

In reply to Marek Vasut
Quoted 3 lines · Marek Vasut

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Thanks,
Mani

Quoted 56 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: No change
V3: No change

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 31 +++++++++++++++++++++
 1 file changed, 31 insertions(+)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +31 -0
index 2f5a53e1b50d..31f23e60629f 100644
@@ -544,3 +544,34 @@ bluetooth {
 		shutdown-gpios = <&gpioz 6 GPIO_ACTIVE_HIGH>;
 	};
 };
+
+&usbh_ehci {
+	phys = <&usbphyc_port0>;
+	phy-names = "usb";
+	status = "okay";
+};
+
+&usbotg_hs {
+	pinctrl-0 = <&usbotg_hs_pins_a>;
+	pinctrl-names = "default";
+	phy-names = "usb2-phy";
+	phys = <&usbphyc_port1 0>;
+	status = "okay";
+	vbus-supply = <&vbus_otg>;
+};
+
+&usbphyc {
+	status = "okay";
+};
+
+&usbphyc_port0 {
+	phy-supply = <&vdd_usb>;
+	vdda1v1-supply = <&reg11>;
+	vdda1v8-supply = <&reg18>;
+};
+
+&usbphyc_port1 {
+	phy-supply = <&vdd_usb>;
+	vdda1v1-supply = <&reg11>;
+	vdda1v8-supply = <&reg18>;
+};
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v4 22/22
#37 lore raw

Re: [PATCH V4 22/22] ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

In reply to Marek Vasut
Quoted 3 lines · Marek Vasut

The LED labels do not match the silkscreen on the board, fix it.

Thanks,
Mani

Quoted 46 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: No change
V3: No change

---
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/stm32mp157a-avenger96.dts +3 -3
index 31f23e60629f..9fcc15b6e76d 100644
@@ -55,21 +55,21 @@ memory@c0000000 {
 	led {
 		compatible = "gpio-leds";
 		led1 {
-			label = "green:user1";
+			label = "green:user0";
 			gpios = <&gpioz 7 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 			default-state = "off";
 		};
 
 		led2 {
-			label = "green:user2";
+			label = "green:user1";
 			gpios = <&gpiof 3 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "mmc0";
 			default-state = "off";
 		};
 
 		led3 {
-			label = "green:user3";
+			label = "green:user2";
 			gpios = <&gpiog 0 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "mmc1";
 			default-state = "off";
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#43 lore raw
In reply to Marek Vasut

Hi,

Quoted 8 lines · Marek Vasut

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96

Ethernet works fine with cold boot but after warm reboot it fails with below message,

[   18.192842] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   18.197539] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

Thanks,
Mani

Quoted 23 lines

ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
ARM: dts: stm32: Repair SDMMC1 operation on AV96
ARM: dts: stm32: Repair PMIC configuration on AV96
ARM: dts: stm32: Repair PMIC interrupt on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
ARM: dts: stm32: Add QSPI NOR on AV96
ARM: dts: stm32: Add configuration EEPROM on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
ARM: dts: stm32: Enable WiFi on AV96
ARM: dts: stm32: Add alternate pinmux for USART2 pins
ARM: dts: stm32: Enable Bluetooth on AV96
ARM: dts: stm32: Add alternate pinmux for LTDC pins
ARM: dts: stm32: Add bindings for HDMI video on AV96
ARM: dts: stm32: Add alternate pinmux for SAI2 pins
ARM: dts: stm32: Add bindings for audio on AV96
ARM: dts: stm32: Add bindings for USB on AV96
ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--
 2 files changed, 571 insertions(+), 33 deletions(-)
Quoted 11 lines

Cc: Alexandre Torgue <[email protected]>
Cc: Manivannan Sadhasivam <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Patrice Chotard <[email protected]>
Cc: Patrick Delaunay <[email protected]>
Cc: [email protected]
To: [email protected]

Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#28 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

In reply to Manivannan Sadhasivam
Quoted 7 lines · Manivannan Sadhasivam
Quoted 3 lines · Marek Vasut

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#44 lore raw
In reply to Manivannan Sadhasivam
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 10 lines · Marek Vasut
Quoted 8 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96

Quoted 5 lines

Ethernet works fine with cold boot but after warm reboot it fails with below message,

[   18.192842] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   18.197539] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

Try this patch:

(quoted diff) +0 -0

b/arch/arm/boot/dts/stm32mp157a-avenger96.dts
index 9fcc15b6e76d..3387d6353418 100644

arch/arm/boot/dts/stm32mp157a-avenger96.dts +3 -1
@@ -136,12 +136,14 @@ &ethernet0 {
        phy-mode = "rgmii";
        max-speed = <1000>;
        phy-handle = <&phy0>;
-       phy-reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
 
        mdio0 {
                #address-cells = <1>;
                #size-cells = <0>;
                compatible = "snps,dwmac-mdio";
+               reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
+               reset-delay-us = <1000>;
+
                phy0: ethernet-phy@7 {
                        reg = <7>;
 

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#29 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

In reply to Marek Vasut
Quoted 11 lines · Marek Vasut
Quoted 7 lines · Manivannan Sadhasivam
Quoted 3 lines · Marek Vasut

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

I think I see what doesn't work for you.

It seems the following works on next:
power on -> plug in USB stick (or any other USB device) -> unplug -> plug in usb host (e.g. PC)

But this does not:
power on -> plug in usb host (e.g. PC)
- the PC is not detected

Did that ^ ever work for you before ? I suspect this is a bug in the DWC2 driver. The OTG operation there is known to be flaky at best.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#45 lore raw
In reply to Marek Vasut

Hi,

Quoted 15 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 10 lines · Marek Vasut
Quoted 8 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96

Quoted 8 lines
Quoted 5 lines

Ethernet works fine with cold boot but after warm reboot it fails with below message,

[   18.192842] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   18.197539] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

Try this patch:

[   17.270826] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   17.275519] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

It doesn't work. Sorry, I don't have much time to dig into this issue so I'll leave it up to you :)

Thanks,
Mani

Quoted 10 lines
arch/arm/boot/dts/stm32mp157a-avenger96.dts +0 -1
index 9fcc15b6e76d..3387d6353418 100644
@@ -136,12 +136,14 @@ &ethernet0 {
        phy-mode = "rgmii";
        max-speed = <1000>;
        phy-handle = <&phy0>;
-       phy-reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;

arch/arm/boot/dts/stm32mp157a-avenger96.dts &ethernet0 { · line 148

Quoted 10 lines
arch/arm/boot/dts/stm32mp157a-avenger96.dts +3 -0
 
        mdio0 {
                #address-cells = <1>;
                #size-cells = <0>;
                compatible = "snps,dwmac-mdio";
+               reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
+               reset-delay-us = <1000>;
+
                phy0: ethernet-phy@7 {
                        reg = <7>;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#30 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

In reply to Marek Vasut

Hi,

Quoted 15 lines · Marek Vasut
Quoted 11 lines · Marek Vasut
Quoted 7 lines · Manivannan Sadhasivam
Quoted 3 lines · Marek Vasut

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

I think I see what doesn't work for you.

Quoted 8 lines

It seems the following works on next:
power on -> plug in USB stick (or any other USB device) -> unplug -> plug in usb host (e.g. PC)

But this does not:
power on -> plug in usb host (e.g. PC)
- the PC is not detected

Both doesn't work. I have the rndis gadget configured in userspace but plugging in the micro-b cable doesn't do anything.

Quoted 2 lines

Did that ^ ever work for you before ? I suspect this is a bug in the DWC2 driver. The OTG operation there is known to be flaky at best.

Not on this board. I don't recall what happended with vendor image. But I do have another STM32MP1 based 96Board (which will be submitted soon), there I can get OTG port working.

But in that board a BG96 modem is connected to USB2 port on the board itself which gets enumerated during probe.

Thanks,
Mani

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#31 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 31 lines · Marek Vasut
Quoted 15 lines · Marek Vasut
Quoted 11 lines · Manivannan Sadhasivam
Quoted 7 lines · Marek Vasut
Quoted 3 lines

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

I think I see what doesn't work for you.

Quoted 8 lines

It seems the following works on next:
power on -> plug in USB stick (or any other USB device) -> unplug -> plug in usb host (e.g. PC)

But this does not:
power on -> plug in usb host (e.g. PC)
- the PC is not detected

Both doesn't work. I have the rndis gadget configured in userspace but plugging in the micro-b cable doesn't do anything.

Quoted 2 lines

Did that ^ ever work for you before ? I suspect this is a bug in the DWC2 driver. The OTG operation there is known to be flaky at best.

Quoted 6 lines

Not on this board. I don't recall what happended with vendor image. But I do have another STM32MP1 based 96Board (which will be submitted soon), there I can get OTG port working.

But in that board a BG96 modem is connected to USB2 port on the board itself which gets enumerated during probe.

But it's not configured as OTG on this other board, right ?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#46 lore raw
In reply to Manivannan Sadhasivam
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 22 lines · Marek Vasut
Quoted 21 lines · Manivannan Sadhasivam
Quoted 1 line

Hi,

Hi,

Quoted 15 lines · Marek Vasut
Quoted 8 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96

Ethernet works fine with cold boot but after warm reboot it fails with below message,

[   18.192842] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   18.197539] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)
Quoted 8 lines
Quoted 2 lines

Try this patch:

[   17.270826] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   17.275519] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

It doesn't work. Sorry, I don't have much time to dig into this issue so I'll leave it up to you :)

I see, it does work on the new board, so I don't really know what to do here. Maybe we should just not support the old prototype board ?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#47 lore raw
Quoted 30 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 25 lines · Marek Vasut
Quoted 23 lines · Manivannan Sadhasivam
Quoted 1 line

Hi,

Hi,

Quoted 10 lines · Marek Vasut
Quoted 8 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96

Quoted 5 lines

Ethernet works fine with cold boot but after warm reboot it fails with below message,

[   18.192842] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   18.197539] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

Try this patch:

Quoted 8 lines
Quoted 5 lines
[   17.270826] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   17.275519] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

It doesn't work. Sorry, I don't have much time to dig into this issue so I'll leave it up to you :)

I see, it does work on the new board, so I don't really know what to do here. Maybe we should just not support the old prototype board ?

Sorry, it turned out to be a DT issue. My script was not updated when I switched to upstream bootloader. This patch works perfectly on both old and new boards.

Feel free to add,

Thanks,
Mani

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#32 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

In reply to Marek Vasut
Quoted 36 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 31 lines · Marek Vasut
Quoted 15 lines · Marek Vasut
Quoted 11 lines · Manivannan Sadhasivam
Quoted 7 lines · Marek Vasut
Quoted 3 lines

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

I think I see what doesn't work for you.

Quoted 8 lines

It seems the following works on next:
power on -> plug in USB stick (or any other USB device) -> unplug -> plug in usb host (e.g. PC)

But this does not:
power on -> plug in usb host (e.g. PC)
- the PC is not detected

Both doesn't work. I have the rndis gadget configured in userspace but plugging in the micro-b cable doesn't do anything.

Quoted 2 lines

Did that ^ ever work for you before ? I suspect this is a bug in the DWC2 driver. The OTG operation there is known to be flaky at best.

Quoted 8 lines
Quoted 6 lines

Not on this board. I don't recall what happended with vendor image. But I do have another STM32MP1 based 96Board (which will be submitted soon), there I can get OTG port working.

But in that board a BG96 modem is connected to USB2 port on the board itself which gets enumerated during probe.

But it's not configured as OTG on this other board, right ?

It is configured as a OTG port. But that board has a different issue which resets the board when we connect any OTG cable to act as a host. That's not related to DWC2 or this issue btw.

Anyway, I can't get OTG (device/host) to work on both old and new boards.

Thanks,
Mani

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#33 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

Quoted 41 lines · Manivannan Sadhasivam
Quoted 40 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 35 lines · Marek Vasut
Quoted 15 lines · Marek Vasut
Quoted 11 lines · Manivannan Sadhasivam
Quoted 7 lines · Marek Vasut
Quoted 3 lines

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

I think I see what doesn't work for you.

Quoted 8 lines

It seems the following works on next:
power on -> plug in USB stick (or any other USB device) -> unplug -> plug in usb host (e.g. PC)

But this does not:
power on -> plug in usb host (e.g. PC)
- the PC is not detected

Both doesn't work. I have the rndis gadget configured in userspace but plugging in the micro-b cable doesn't do anything.

Quoted 2 lines

Did that ^ ever work for you before ? I suspect this is a bug in the DWC2 driver. The OTG operation there is known to be flaky at best.

Not on this board. I don't recall what happended with vendor image. But I do have another STM32MP1 based 96Board (which will be submitted soon), there I can get OTG port working.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

But in that board a BG96 modem is connected to USB2 port on the board itself which gets enumerated during probe.

But it's not configured as OTG on this other board, right ?

It is configured as a OTG port. But that board has a different issue which resets the board when we connect any OTG cable to act as a host. That's not related to DWC2 or this issue btw.

Do I misunderstand the part where you claim there is a modem connected to the DWC2 ? That would mean it's in Host mode, no ?

Quoted 1 line

Anyway, I can't get OTG (device/host) to work on both old and new boards.

Do you have 588-200 now too ?

I think there is some fix in current linux-next which partly fixes the DWC2 role switching, so rebase this patchset on current linux-next and see what happens. But it's still not perfect. I also think that ST managed to side-step this issue by using the STUSB1600 chip, but I might be wrong.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#48 lore raw
In reply to Manivannan Sadhasivam
Quoted 40 lines · Manivannan Sadhasivam
Quoted 30 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 25 lines · Marek Vasut
Quoted 23 lines · Manivannan Sadhasivam
Quoted 1 line

Hi,

Hi,

Quoted 10 lines · Marek Vasut
Quoted 8 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96

Quoted 5 lines

Ethernet works fine with cold boot but after warm reboot it fails with below message,

[   18.192842] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   18.197539] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

Try this patch:

Quoted 8 lines
Quoted 5 lines
[   17.270826] stm32-dwmac 5800a000.ethernet eth0: no phy at addr -1
[   17.275519] stm32-dwmac 5800a000.ethernet eth0: stmmac_open: Cannot attach to PHY (err)

It doesn't work. Sorry, I don't have much time to dig into this issue so I'll leave it up to you :)

I see, it does work on the new board, so I don't really know what to do here. Maybe we should just not support the old prototype board ?

Quoted 6 lines

Sorry, it turned out to be a DT issue. My script was not updated when I switched to upstream bootloader. This patch works perfectly on both old and new boards.

Feel free to add,

OK, thanks. So that leaves only the DWC2 ?

I'll wait for ST to review this series before sending V5.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#34 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

In reply to Marek Vasut
Quoted 45 lines · Marek Vasut
Quoted 44 lines · Manivannan Sadhasivam
Quoted 43 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 37 lines · Marek Vasut
Quoted 15 lines · Marek Vasut
Quoted 11 lines · Manivannan Sadhasivam
Quoted 7 lines · Marek Vasut
Quoted 3 lines

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

I think I see what doesn't work for you.

Quoted 8 lines

It seems the following works on next:
power on -> plug in USB stick (or any other USB device) -> unplug -> plug in usb host (e.g. PC)

But this does not:
power on -> plug in usb host (e.g. PC)
- the PC is not detected

Both doesn't work. I have the rndis gadget configured in userspace but plugging in the micro-b cable doesn't do anything.

Quoted 2 lines

Did that ^ ever work for you before ? I suspect this is a bug in the DWC2 driver. The OTG operation there is known to be flaky at best.

Not on this board. I don't recall what happended with vendor image. But I do have another STM32MP1 based 96Board (which will be submitted soon), there I can get OTG port working.

But in that board a BG96 modem is connected to USB2 port on the board itself which gets enumerated during probe.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

But it's not configured as OTG on this other board, right ?

It is configured as a OTG port. But that board has a different issue which resets the board when we connect any OTG cable to act as a host. That's not related to DWC2 or this issue btw.

Do I misunderstand the part where you claim there is a modem connected to the DWC2 ? That would mean it's in Host mode, no ?

Let me make it clear. On that board, the USB connection is almost similar to Avenger96 except that there is only one host port used and it is connected to the BG96 modem onboard. The other OTG port is connected to micro-b connector.

There I can _only_ get the OTG port to work in device mode. I haven't figured out what is the exact issue yet. So in the meantime, I may use

dr_mode = "peripheral"

to avoid it being used as host. But on Avenger96 board, the host ports are working but the OTG port is neither working as host nor as device.

Quoted 4 lines
Quoted 1 line

Anyway, I can't get OTG (device/host) to work on both old and new boards.

Do you have 588-200 now too ?

I have both 588-100 and 588-200 now. I told you that at the time of initial upstreaming I had only 588-100 but later Arrow sent me the new board.

Quoted 5 lines

I think there is some fix in current linux-next which partly fixes the DWC2 role switching, so rebase this patchset on current linux-next and see what happens. But it's still not perfect. I also think that ST managed to side-step this issue by using the STUSB1600 chip, but I might be wrong.

Okay, I'll try for both Avenger96 and Stinger96 (yeah that's the name of the board I'm working on right now).

Thanks,
Mani

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#35 lore raw

Re: [PATCH V4 21/22] ARM: dts: stm32: Add bindings for USB on AV96

Quoted 52 lines · Manivannan Sadhasivam
Quoted 51 lines · Marek Vasut
Quoted 49 lines · Manivannan Sadhasivam
Quoted 36 lines · Marek Vasut
Quoted 1 line · Manivannan Sadhasivam

Hi,

Hi,

Quoted 31 lines · Marek Vasut
Quoted 15 lines · Marek Vasut
Quoted 11 lines · Manivannan Sadhasivam
Quoted 7 lines · Marek Vasut
Quoted 3 lines

Fill in the bindings for USB host and gadget on AV96.

I can't get the USB B-Micro OTG port to work with this patch. Do I need to enable any configs other than PHY and USB DWC2 drivers?

Only the DWC2 GADGET (and possibly host, for dual-role) and some gadget implementation (e.g. gadget zero).

I think I see what doesn't work for you.

Quoted 8 lines

It seems the following works on next:
power on -> plug in USB stick (or any other USB device) -> unplug -> plug in usb host (e.g. PC)

But this does not:
power on -> plug in usb host (e.g. PC)
- the PC is not detected

Both doesn't work. I have the rndis gadget configured in userspace but plugging in the micro-b cable doesn't do anything.

Quoted 2 lines

Did that ^ ever work for you before ? I suspect this is a bug in the DWC2 driver. The OTG operation there is known to be flaky at best.

Quoted 8 lines
Quoted 6 lines

Not on this board. I don't recall what happended with vendor image. But I do have another STM32MP1 based 96Board (which will be submitted soon), there I can get OTG port working.

But in that board a BG96 modem is connected to USB2 port on the board itself which gets enumerated during probe.

But it's not configured as OTG on this other board, right ?

It is configured as a OTG port. But that board has a different issue which resets the board when we connect any OTG cable to act as a host. That's not related to DWC2 or this issue btw.

Quoted 7 lines
Quoted 3 lines

Do I misunderstand the part where you claim there is a modem connected to the DWC2 ? That would mean it's in Host mode, no ?

Let me make it clear. On that board, the USB connection is almost similar to Avenger96 except that there is only one host port used and it is connected to the BG96 modem onboard. The other OTG port is connected to micro-b connector.

So the BG96 modem is irrelevant, since it's connected to EHCI HCD, different controller altogether.

Quoted 7 lines

There I can _only_ get the OTG port to work in device mode. I haven't figured out what is the exact issue yet. So in the meantime, I may use

dr_mode = "peripheral"

to avoid it being used as host. But on Avenger96 board, the host ports are working but the OTG port is neither working as host nor as device.

Is there any difference in the DT between the AV96 and your custom board ?

In particular, look at

&pwr_regulators {
         vdd-supply = <&vdd_io>;
         vdd_3v3_usbfs-supply = <&vdd_usb>;
};

&usbotg_hs {} node and all the other usb* nodes.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Anyway, I can't get OTG (device/host) to work on both old and new boards.

Do you have 588-200 now too ?

I have both 588-100 and 588-200 now. I told you that at the time of initial upstreaming I had only 588-100 but later Arrow sent me the new board.

OK good.

Quoted 8 lines
Quoted 5 lines

I think there is some fix in current linux-next which partly fixes the DWC2 role switching, so rebase this patchset on current linux-next and see what happens. But it's still not perfect. I also think that ST managed to side-step this issue by using the STUSB1600 chip, but I might be wrong.

Okay, I'll try for both Avenger96 and Stinger96 (yeah that's the name of the board I'm working on right now).

OK, so the OTG should be indeed almost identical.

Try the latest linux-next, the DWC2 behaves "better" in there. And try plugging in some USB device first (like a USB stick), see if that's detected.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#49 lore raw
In reply to Marek Vasut
Quoted 27 lines · Marek Vasut

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
ARM: dts: stm32: Repair SDMMC1 operation on AV96
ARM: dts: stm32: Repair PMIC configuration on AV96
ARM: dts: stm32: Repair PMIC interrupt on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
ARM: dts: stm32: Add QSPI NOR on AV96
ARM: dts: stm32: Add configuration EEPROM on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
ARM: dts: stm32: Enable WiFi on AV96
ARM: dts: stm32: Add alternate pinmux for USART2 pins
ARM: dts: stm32: Enable Bluetooth on AV96
ARM: dts: stm32: Add alternate pinmux for LTDC pins
ARM: dts: stm32: Add bindings for HDMI video on AV96
ARM: dts: stm32: Add alternate pinmux for SAI2 pins
ARM: dts: stm32: Add bindings for audio on AV96
ARM: dts: stm32: Add bindings for USB on AV96
ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

Quoted 3 lines
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++
 arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--
 2 files changed, 571 insertions(+), 33 deletions(-)

Alex, can you provide some review of this series ? It's been posted for three weeks now.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#50 lore raw

Hi Marek

Quoted 28 lines · Marek Vasut
Quoted 27 lines · Marek Vasut

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
ARM: dts: stm32: Repair ethernet operation on AV96
ARM: dts: stm32: Add missing ethernet PHY reset on AV96
ARM: dts: stm32: Add missing ethernet PHY skews on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
ARM: dts: stm32: Repair SDMMC1 operation on AV96
ARM: dts: stm32: Repair PMIC configuration on AV96
ARM: dts: stm32: Repair PMIC interrupt on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
ARM: dts: stm32: Add QSPI NOR on AV96
ARM: dts: stm32: Add configuration EEPROM on AV96
ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
ARM: dts: stm32: Enable WiFi on AV96
ARM: dts: stm32: Add alternate pinmux for USART2 pins
ARM: dts: stm32: Enable Bluetooth on AV96
ARM: dts: stm32: Add alternate pinmux for LTDC pins
ARM: dts: stm32: Add bindings for HDMI video on AV96
ARM: dts: stm32: Add alternate pinmux for SAI2 pins
ARM: dts: stm32: Add bindings for audio on AV96
ARM: dts: stm32: Add bindings for USB on AV96
ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

Quoted 7 lines
Quoted 3 lines
  arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++
  arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--
  2 files changed, 571 insertions(+), 33 deletions(-)

Alex, can you provide some review of this series ? It's been posted for three weeks now.

Yes, I was waiting for Mani's review first (and I was a bit busy sorry).

All patches looks good for me. Maybe I'll squash some pinctrl patches to decrease number of patches.

One remaining questions about patch 7 ("Repair PMIC configuration on AV96). I saw a discussion on u-boot thread with pascal P., explaining that 800mv is not the minimal voltage acceptable for vddcore. What is the status ?

regards
alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#51 lore raw
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 33 lines · Marek Vasut
Quoted 32 lines · Marek Vasut
Quoted 30 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
   ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
   ARM: dts: stm32: Repair ethernet operation on AV96
   ARM: dts: stm32: Add missing ethernet PHY reset on AV96
   ARM: dts: stm32: Add missing ethernet PHY skews on AV96
   ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
   ARM: dts: stm32: Repair SDMMC1 operation on AV96
   ARM: dts: stm32: Repair PMIC configuration on AV96
   ARM: dts: stm32: Repair PMIC interrupt on AV96
   ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
   ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
   ARM: dts: stm32: Add QSPI NOR on AV96
   ARM: dts: stm32: Add configuration EEPROM on AV96
   ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
   ARM: dts: stm32: Enable WiFi on AV96
   ARM: dts: stm32: Add alternate pinmux for USART2 pins
   ARM: dts: stm32: Enable Bluetooth on AV96
   ARM: dts: stm32: Add alternate pinmux for LTDC pins
   ARM: dts: stm32: Add bindings for HDMI video on AV96
   ARM: dts: stm32: Add alternate pinmux for SAI2 pins
   ARM: dts: stm32: Add bindings for audio on AV96
   ARM: dts: stm32: Add bindings for USB on AV96
   ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

  arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++ arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--

  2 files changed, 571 insertions(+), 33 deletions(-)
Quoted 5 lines
Quoted 3 lines

Alex, can you provide some review of this series ? It's been posted for three weeks now.

Yes, I was waiting for Mani's review first (and I was a bit busy sorry).

It seems most of the patches got that review.

Quoted 2 lines

All patches looks good for me. Maybe I'll squash some pinctrl patches to decrease number of patches.

One patch should do one thing and one thing only, no ?

Quoted 4 lines

One remaining questions about patch 7 ("Repair PMIC configuration on AV96). I saw a discussion on u-boot thread with pascal P., explaining that 800mv is not the minimal voltage acceptable for vddcore. What is the status ?

It should likely be set to 1V2, same as 791be94e2878 ("ARM: dts: stm32:
change default minimal buck1 value on stm32mp157") does. I'll add it into the list of fixes for V5.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#52 lore raw
Quoted 38 lines · Marek Vasut
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 33 lines · Marek Vasut
Quoted 32 lines · Marek Vasut
Quoted 30 lines

The AV96 board device tree is completely broken and does not match the hardware. This series fixes it up.

Marek Vasut (22):
   ARM: dts: stm32: Add alternate pinmux for ethernet RGMII
   ARM: dts: stm32: Repair ethernet operation on AV96
   ARM: dts: stm32: Add missing ethernet PHY reset on AV96
   ARM: dts: stm32: Add missing ethernet PHY skews on AV96
   ARM: dts: stm32: Add alternate pinmux for SDMMC1 direction pins
   ARM: dts: stm32: Repair SDMMC1 operation on AV96
   ARM: dts: stm32: Repair PMIC configuration on AV96
   ARM: dts: stm32: Repair PMIC interrupt on AV96
   ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7
   ARM: dts: stm32: Add eMMC attached to SDMMC2 on AV96
   ARM: dts: stm32: Add QSPI NOR on AV96
   ARM: dts: stm32: Add configuration EEPROM on AV96
   ARM: dts: stm32: Add alternate pinmux for SDMMC3 pins
   ARM: dts: stm32: Enable WiFi on AV96
   ARM: dts: stm32: Add alternate pinmux for USART2 pins
   ARM: dts: stm32: Enable Bluetooth on AV96
   ARM: dts: stm32: Add alternate pinmux for LTDC pins
   ARM: dts: stm32: Add bindings for HDMI video on AV96
   ARM: dts: stm32: Add alternate pinmux for SAI2 pins
   ARM: dts: stm32: Add bindings for audio on AV96
   ARM: dts: stm32: Add bindings for USB on AV96
   ARM: dts: stm32: Rename LEDs to match silkscreen on AV96

   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi    | 280 +++++++++++++++++
   arch/arm/boot/dts/stm32mp157a-avenger96.dts | 324 ++++++++++++++++++--
   2 files changed, 571 insertions(+), 33 deletions(-)
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Alex, can you provide some review of this series ? It's been posted for three weeks now.

Yes, I was waiting for Mani's review first (and I was a bit busy sorry).

It seems most of the patches got that review.

Yes.

Quoted 5 lines
Quoted 3 lines

All patches looks good for me. Maybe I'll squash some pinctrl patches to decrease number of patches.

One patch should do one thing and one thing only, no ?

Adding all SDMMC pingroups update in one patch could make sense for example.

Quoted 10 lines
Quoted 5 lines

One remaining questions about patch 7 ("Repair PMIC configuration on AV96). I saw a discussion on u-boot thread with pascal P., explaining that 800mv is not the minimal voltage acceptable for vddcore. What is the status ?

It should likely be set to 1V2, same as 791be94e2878 ("ARM: dts: stm32:
change default minimal buck1 value on stm32mp157") does. I'll add it into the list of fixes for V5.

ok, thanks.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel