gpio: turn of_pinctrl_get() into a static inline
Subsystems (2)
PATCH 1/1 gpio: turn of_pinctrl_get() into a static inline
This avoids the overheads of an EXPORTed function.
--- drivers/pinctrl/devicetree.c | 6 ------ include/linux/pinctrl/pinctrl.h | 9 +++------ 2 files changed, 3 insertions(+), 12 deletions(-)
This is not even build tested, but is this what you meant, Geert?
drivers/pinctrl/devicetree.c +0 -6
@@ -99,12 +99,6 @@ static int dt_remember_or_free_map(struct pinctrl *p, const char *statename,return -ENOMEM ; } -struct pinctrl_dev *of_pinctrl_get (struct device_node *np) -{ -return get_pinctrl_dev_from_of_node (np); -} -EXPORT_SYMBOL_GPL (of_pinctrl_get); - static int dt_to_map_one_config(struct pinctrl *p, struct pinctrl_dev *hog_pctldev, const char *statename,
include/linux/pinctrl/pinctrl.h +3 -6
@@ -186,15 +186,12 @@ extern int pinctrl_get_group_pins(struct pinctrl_dev *pctldev, const char *pin_group, const unsigned **pins, unsigned *num_pins); -#if IS_ENABLED (CONFIG_OF ) &&IS_ENABLED (CONFIG_PINCTRL ) -extern struct pinctrl_dev *of_pinctrl_get (struct device_node *np); -#else -static inline -struct pinctrl_dev *of_pinctrl_get (struct device_node *np) +static inline struct pinctrl_dev *of_pinctrl_get (struct device_node *np) { +if (IS_ENABLED (CONFIG_OF ) &&IS_ENABLED (CONFIG_PINCTRL )) +return get_pinctrl_dev_from_of_node (np);return NULL ; } -#endif /* CONFIG_OF */ extern const char *pinctrl_dev_get_name (struct pinctrl_dev *pctldev);extern const char *pinctrl_dev_get_devname (struct pinctrl_dev *pctldev);
Signature · 5 lines
2.26.0 -- Cheers, Stephen Rothwell
Hi all,
Quoted 11 lines · On Wed, 1 Apr 2020 19:08:10 +1100 Stephen Rothwell <[email protected]> wrote:
This avoids the overheads of an EXPORTed function.
Suggested-by Geert Uytterhoeven <[email protected]>Signed-off-by Stephen Rothwell <[email protected]>--- drivers/pinctrl/devicetree.c | 6 ------ include/linux/pinctrl/pinctrl.h | 9 +++------ 2 files changed, 3 insertions(+), 12 deletions(-)This is not even build tested, but is this what you meant, Geert?
Actually this won't work because get_pinctrl_dev_from_of_node() is declared in the private header file drivers/pinctrl/core.h :-(
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 11 lines · Stephen Rothwell
Quoted 10 lines · On Wed, 1 Apr 2020 19:08:10 +1100 Stephen Rothwell <[email protected]> wrote:
This avoids the overheads of an EXPORTed function.
Suggested-by Geert Uytterhoeven <[email protected]>Signed-off-by Stephen Rothwell <[email protected]>--- drivers/pinctrl/devicetree.c | 6 ------ include/linux/pinctrl/pinctrl.h | 9 +++------ 2 files changed, 3 insertions(+), 12 deletions(-)
Quoted 4 lines
Quoted 1 line
This is not even build tested, but is this what you meant, Geert?
Actually this won't work because
get_pinctrl_dev_from_of_node()is declared in the private header filedrivers/pinctrl/core.h:-(
No big deal. We keep your other fix for now.
Yours,
Linus Walleij
Hi Stephen,
Quoted 10 lines · Stephen Rothwell
Quoted 9 lines · On Wed, 1 Apr 2020 19:08:10 +1100 Stephen Rothwell <[email protected]> wrote:
This avoids the overheads of an EXPORTed function.
Suggested-by Geert Uytterhoeven <[email protected]>Signed-off-by Stephen Rothwell <[email protected]>--- drivers/pinctrl/devicetree.c | 6 ------ include/linux/pinctrl/pinctrl.h | 9 +++------ 2 files changed, 3 insertions(+), 12 deletions(-)
Quoted 4 lines
Quoted 1 line
This is not even build tested, but is this what you meant, Geert?
Actually this won't work because
get_pinctrl_dev_from_of_node()is declared in the private header filedrivers/pinctrl/core.h:-(
Indeed :-(
Just realized this myself, while reviewing your patch. Sorry for the bad suggestion.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert,
Quoted 3 lines · On Wed, 1 Apr 2020 10:26:58 +0200 Geert Uytterhoeven <[email protected]>…
Just realized this myself, while reviewing your patch. Sorry for the bad suggestion.
No worries.
Signature · 2 lines
Cheers, Stephen Rothwell