Skip to contentSkip to conversation

btrfs: ssd_metadata: storing metadata on SSD

RFC In review Goffredo Baroncelli 7 participants 11 messages Apr 1, 2020 – Apr 3, 2020 Btrfs file system

lore
Share & tools
lore
#0 lore raw

This is an RFC; I wrote this patch because I find the idea interesting even though it adds more complication to the chunk allocator.

The core idea is to store the metadata on the ssd and leave the data on the rotational disks. BTRFS looks at the rotational flags to understand the kind of disks.

This new mode is enabled passing the option ssd_metadata at mount time.
This policy of allocation is the "preferred" one. If this doesn't permit a chunk allocation, the "classic" one is used.

Some examples: (/dev/sd[abc] are ssd, and /dev/sd[ef] are rotational)

Non striped profile: metadata->raid1, data->raid1
The data is stored on /dev/sd[ef], metadata is stored on /dev/sd[abc]. When /dev/sd[ef] are full, then the data chunk is allocated also on /dev/sd[abc].

Striped profile: metadata->raid5, data->raid5
raid5 requires 3 disks at minimum, so /dev/sd[ef] are not enough for a data profile raid5. To allow a data chunk allocation, the data profile raid5 will be stored on all the disks /dev/sd[abcdef].
Instead the metadata profile raid5 will be allocated on /dev/sd[abc], because these are enough to host this chunk.

NOTE1: I don't touch the mkfs.btrfs program, so the new policy will be applied only to the next chunk allocation. If you want to allocate properly the chunk created by mkfs.btrfs, a btrfs balance is required.
NOTE1: I made only few tests. Don't use for valued data

BR
G.Baroncelli

#1 lore raw

PATCH 1/1 btrfs: add ssd_metadata mode

From: Goffredo Baroncelli <[email protected]>

When this mode is enabled, the allocation policy of the chunk is so modified:
- when a metadata chunk is allocated, priority is given to ssd disk.
- When a data chunk is allocated, priority is given to a rotational disk.

When a striped profile is involved (like RAID0,5,6), the logic is a bit more complex. If there are enough disks, the data profiles are stored on the rotational disks only; the metadata profiles are stored on the non rotational disk only.
If the disks are not enough, then the profiles is stored on all the disks.

Example: assuming that sda, sdb, sdc are ssd disks, and sde, sdf are rotational ones.
A data profile raid5, will be stored on sda, sdb, sdc, sde, sdf (sde and sdf are not enough to host a raid5 profile).
A metadata profile raid5, will be stored on sda, sdb, sdc (these are enough to host a raid5 profile).

To enable this mode pass -o ssd_metadata at mount time.

---
 fs/btrfs/ctree.h   |  1 +
 fs/btrfs/super.c   |  8 +++++
 fs/btrfs/volumes.c | 89 ++++++++++++++++++++++++++++++++++++++++++++--
 fs/btrfs/volumes.h |  1 +
 4 files changed, 97 insertions(+), 2 deletions(-)
fs/btrfs/ctree.h +1 -0
index 2e9f938508e9..0f3c09cc4863 100644
@@ -1187,6 +1187,7 @@ static inline u32 BTRFS_MAX_XATTR_SIZE(const struct btrfs_fs_info *info)
 #define BTRFS_MOUNT_FREE_SPACE_TREE	(1 << 26)
 #define BTRFS_MOUNT_NOLOGREPLAY		(1 << 27)
 #define BTRFS_MOUNT_REF_VERIFY		(1 << 28)
+#define BTRFS_MOUNT_SSD_METADATA	(1 << 29)
 
 #define BTRFS_DEFAULT_COMMIT_INTERVAL	(30)
 #define BTRFS_DEFAULT_MAX_INLINE	(2048)
fs/btrfs/super.c +8 -0
index c6557d44907a..d0a5cf496f90 100644
@@ -346,6 +346,7 @@ enum {
 #ifdef CONFIG_BTRFS_FS_REF_VERIFY
 	Opt_ref_verify,
 #endif
+	Opt_ssd_metadata,
 	Opt_err,
 };
 
@@ -416,6 +417,7 @@ static const match_table_t tokens = {
 #ifdef CONFIG_BTRFS_FS_REF_VERIFY
 	{Opt_ref_verify, "ref_verify"},
 #endif
+	{Opt_ssd_metadata, "ssd_metadata"},
 	{Opt_err, NULL},
 };
 
@@ -853,6 +855,10 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
 			btrfs_set_opt(info->mount_opt, REF_VERIFY);
 			break;
 #endif
+		case Opt_ssd_metadata:
+			btrfs_set_and_info(info, SSD_METADATA,
+					"enabling ssd_metadata");
+			break;
 		case Opt_err:
 			btrfs_info(info, "unrecognized mount option '%s'", p);
 			ret = -EINVAL;
@@ -1369,6 +1375,8 @@ static int btrfs_show_options(struct seq_file *seq, struct dentry *dentry)
 #endif
 	if (btrfs_test_opt(info, REF_VERIFY))
 		seq_puts(seq, ",ref_verify");
+	if (btrfs_test_opt(info, SSD_METADATA))
+		seq_puts(seq, ",ssd_metadata");
 	seq_printf(seq, ",subvolid=%llu",
 		  BTRFS_I(d_inode(dentry))->root->root_key.objectid);
 	seq_puts(seq, ",subvol=");
fs/btrfs/volumes.c +87 -2

119 lines not on this page · raw message

fs/btrfs/volumes.h +1 -0
index fc1b564b9cfe..bc1cfa0c27ea 100644
@@ -340,6 +340,7 @@ struct btrfs_device_info {
 	u64 dev_offset;
 	u64 max_avail;
 	u64 total_avail;
+	int rotational:1;
 };
 
 struct btrfs_raid_attr {
Signature · 1 line
2.26.0
#2 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

Quoted 16 lines · Goffredo Baroncelli

From: Goffredo Baroncelli <[email protected]>

When this mode is enabled, the allocation policy of the chunk is so modified:
- when a metadata chunk is allocated, priority is given to ssd disk.
- When a data chunk is allocated, priority is given to a rotational disk.

When a striped profile is involved (like RAID0,5,6), the logic is a bit more complex. If there are enough disks, the data profiles are stored on the rotational disks only; the metadata profiles are stored on the non rotational disk only.
If the disks are not enough, then the profiles is stored on all the disks.

Quoted 6 lines

Example: assuming that sda, sdb, sdc are ssd disks, and sde, sdf are rotational ones.
A data profile raid5, will be stored on sda, sdb, sdc, sde, sdf (sde and sdf are not enough to host a raid5 profile).
A metadata profile raid5, will be stored on sda, sdb, sdc (these are enough to host a raid5 profile).

The example is a bit wrong. Replace raid5 with raid6. However I hope that the sense is still understandable.

Quoted 168 lines

To enable this mode pass -o ssd_metadata at mount time.

---
  fs/btrfs/ctree.h   |  1 +
  fs/btrfs/super.c   |  8 +++++
  fs/btrfs/volumes.c | 89 ++++++++++++++++++++++++++++++++++++++++++++--
  fs/btrfs/volumes.h |  1 +
  4 files changed, 97 insertions(+), 2 deletions(-)
fs/btrfs/ctree.h +1 -0
index 2e9f938508e9..0f3c09cc4863 100644
@@ -1187,6 +1187,7 @@ static inline u32 BTRFS_MAX_XATTR_SIZE(const struct btrfs_fs_info *info)
  #define BTRFS_MOUNT_FREE_SPACE_TREE	(1 << 26)
  #define BTRFS_MOUNT_NOLOGREPLAY		(1 << 27)
  #define BTRFS_MOUNT_REF_VERIFY		(1 << 28)
+#define BTRFS_MOUNT_SSD_METADATA	(1 << 29)
 
  #define BTRFS_DEFAULT_COMMIT_INTERVAL	(30)
  #define BTRFS_DEFAULT_MAX_INLINE	(2048)
fs/btrfs/super.c +8 -0
index c6557d44907a..d0a5cf496f90 100644
@@ -346,6 +346,7 @@ enum {
  #ifdef CONFIG_BTRFS_FS_REF_VERIFY
  	Opt_ref_verify,
  #endif
+	Opt_ssd_metadata,
  	Opt_err,
  };
 
@@ -416,6 +417,7 @@ static const match_table_t tokens = {
  #ifdef CONFIG_BTRFS_FS_REF_VERIFY
  	{Opt_ref_verify, "ref_verify"},
  #endif
+	{Opt_ssd_metadata, "ssd_metadata"},
  	{Opt_err, NULL},
  };
 
@@ -853,6 +855,10 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
  			btrfs_set_opt(info->mount_opt, REF_VERIFY);
  			break;
  #endif
+		case Opt_ssd_metadata:
+			btrfs_set_and_info(info, SSD_METADATA,
+					"enabling ssd_metadata");
+			break;
  		case Opt_err:
  			btrfs_info(info, "unrecognized mount option '%s'", p);
  			ret = -EINVAL;
@@ -1369,6 +1375,8 @@ static int btrfs_show_options(struct seq_file *seq, struct dentry *dentry)
  #endif
  	if (btrfs_test_opt(info, REF_VERIFY))
  		seq_puts(seq, ",ref_verify");
+	if (btrfs_test_opt(info, SSD_METADATA))
+		seq_puts(seq, ",ssd_metadata");
  	seq_printf(seq, ",subvolid=%llu",
  		  BTRFS_I(d_inode(dentry))->root->root_key.objectid);
  	seq_puts(seq, ",subvol=");
fs/btrfs/volumes.c +68 -2
index a8b71ded4d21..678dc3366711 100644
@@ -4758,6 +4758,58 @@ static int btrfs_cmp_device_info(const void *a, const void *b)
  	return 0;
  }
 
+/*
+ * sort the devices in descending order by rotational,
+ * max_avail, total_avail
+ */
+static int btrfs_cmp_device_info_metadata(const void *a, const void *b)
+{
+	const struct btrfs_device_info *di_a = a;
+	const struct btrfs_device_info *di_b = b;
+
+	/* metadata -> non rotational first */
+	if (!di_a->rotational && di_b->rotational)
+		return -1;
+	if (di_a->rotational && !di_b->rotational)
+		return 1;
+	if (di_a->max_avail > di_b->max_avail)
+		return -1;
+	if (di_a->max_avail < di_b->max_avail)
+		return 1;
+	if (di_a->total_avail > di_b->total_avail)
+		return -1;
+	if (di_a->total_avail < di_b->total_avail)
+		return 1;
+	return 0;
+}
+
+/*
+ * sort the devices in descending order by !rotational,
+ * max_avail, total_avail
+ */
+static int btrfs_cmp_device_info_data(const void *a, const void *b)
+{
+	const struct btrfs_device_info *di_a = a;
+	const struct btrfs_device_info *di_b = b;
+
+	/* data -> non rotational last */
+	if (!di_a->rotational && di_b->rotational)
+		return 1;
+	if (di_a->rotational && !di_b->rotational)
+		return -1;
+	if (di_a->max_avail > di_b->max_avail)
+		return -1;
+	if (di_a->max_avail < di_b->max_avail)
+		return 1;
+	if (di_a->total_avail > di_b->total_avail)
+		return -1;
+	if (di_a->total_avail < di_b->total_avail)
+		return 1;
+	return 0;
+}
+
+
+
  static void check_raid56_incompat_flag(struct btrfs_fs_info *info, u64 type)
  {
  	if (!(type & BTRFS_BLOCK_GROUP_RAID56_MASK))
@@ -4805,6 +4857,7 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
  	int i;
  	int j;
  	int index;
+	int nr_rotational;
 
  	BUG_ON(!alloc_profile_is_valid(type, 0));
 
@@ -4860,6 +4913,7 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
  	 * about the available holes on each device.
  	 */
  	ndevs = 0;
+	nr_rotational = 0;
  	list_for_each_entry(device, &fs_devices->alloc_list, dev_alloc_list) {
  		u64 max_avail;
  		u64 dev_offset;
@@ -4911,14 +4965,45 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
  		devices_info[ndevs].max_avail = max_avail;
  		devices_info[ndevs].total_avail = total_avail;
  		devices_info[ndevs].dev = device;
+		devices_info[ndevs].rotational = !test_bit(QUEUE_FLAG_NONROT,
+				&(bdev_get_queue(device->bdev)->queue_flags));
+		if (devices_info[ndevs].rotational)
+			nr_rotational++;
  		++ndevs;
  	}
 
+	BUG_ON(nr_rotational > ndevs);
  	/*
  	 * now sort the devices by hole size / available space
  	 */
-	sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
-	     btrfs_cmp_device_info, NULL);
+	if (((type & BTRFS_BLOCK_GROUP_DATA) &&
+	     (type & BTRFS_BLOCK_GROUP_METADATA)) ||
+	    !btrfs_test_opt(info, SSD_METADATA)) {
+		/* mixed bg or SSD_METADATA not set */
+		sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
+			     btrfs_cmp_device_info, NULL);
+	} else {
+		/*
+		 * if SSD_METADATA is set, sort the device considering also the

fs/btrfs/volumes.c static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans, · line 4997

Quoted 10 lines
fs/btrfs/volumes.c +10 -0
+		 * kind (ssd or not). Limit the availables devices to the ones
+		 * of the same kind, to avoid that a striped profile like raid5
+		 * spans to all kind of devices (ssd and rotational).
+		 * It is allowed to span different kind of devices if the ones of
+		 * the same kind are not enough alone.
+		 */
+		if (type & BTRFS_BLOCK_GROUP_DATA) {
+			sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
+				     btrfs_cmp_device_info_data, NULL);
+			if (nr_rotational > devs_min)

It should be
if (nr_rotational >= devs_min)

fs/btrfs/volumes.c static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans, · line 5003

Quoted 6 lines
fs/btrfs/volumes.c +6 -0
+				ndevs = nr_rotational;
+		} else {
+			int nr_norot = ndevs - nr_rotational;
+			sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
+				     btrfs_cmp_device_info_metadata, NULL);
+			if (nr_norot > devs_min)

It should be
if (nr_nonrot >= devs_min)

Quoted 19 lines
fs/btrfs/volumes.c +3 -0
+				ndevs = nr_norot;
+		}
+	}
 
  	/*
  	 * Round down to number of usable stripes, devs_increment can be any
fs/btrfs/volumes.h +1 -0
index fc1b564b9cfe..bc1cfa0c27ea 100644
@@ -340,6 +340,7 @@ struct btrfs_device_info {
  	u64 dev_offset;
  	u64 max_avail;
  	u64 total_avail;
+	int rotational:1;
  };
 
  struct btrfs_raid_attr {
Signature · 2 lines
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5
#3 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

In reply to Goffredo Baroncelli
Quoted 23 lines · Goffredo Baroncelli

From: Goffredo Baroncelli <[email protected]>

When this mode is enabled, the allocation policy of the chunk is so modified:
- when a metadata chunk is allocated, priority is given to ssd disk.
- When a data chunk is allocated, priority is given to a rotational disk.

When a striped profile is involved (like RAID0,5,6), the logic is a bit more complex. If there are enough disks, the data profiles are stored on the rotational disks only; the metadata profiles are stored on the non rotational disk only.
If the disks are not enough, then the profiles is stored on all the disks.

Example: assuming that sda, sdb, sdc are ssd disks, and sde, sdf are rotational ones.
A data profile raid5, will be stored on sda, sdb, sdc, sde, sdf (sde and sdf are not enough to host a raid5 profile).
A metadata profile raid5, will be stored on sda, sdb, sdc (these are enough to host a raid5 profile).

Quoted 3 lines

To enable this mode pass -o ssd_metadata at mount time.

The idea of this sounds similar to what Anand has been working on with the readmirror patchset[1] which was originally designed to prefer reading from SSD devices in a RAID1 configuration but has evolved into allowing the read policy to be configured through sysfs, at least partly because detecting SSDs correctly is not an exact science. Also, there may be more considerations than just HDD or SSD: for example in my system I use a SATA SSD and an NVMe SSD in RAID1 where the NVMe device is twice the speed of the SSD.

I would therefore vote for configurability of this rather than always choosing SSD over HDD.

[1] https://patchwork.kernel.org/project/linux-btrfs/list/?series=245121

Signature · 1 line
Steven Davies
#4 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

Quoted 24 lines · Steven Davies
Quoted 23 lines · Goffredo Baroncelli

From: Goffredo Baroncelli <[email protected]>

When this mode is enabled, the allocation policy of the chunk is so modified:
- when a metadata chunk is allocated, priority is given to ssd disk.
- When a data chunk is allocated, priority is given to a rotational disk.

When a striped profile is involved (like RAID0,5,6), the logic is a bit more complex. If there are enough disks, the data profiles are stored on the rotational disks only; the metadata profiles are stored on the non rotational disk only.
If the disks are not enough, then the profiles is stored on all the disks.

Example: assuming that sda, sdb, sdc are ssd disks, and sde, sdf are rotational ones.
A data profile raid5, will be stored on sda, sdb, sdc, sde, sdf (sde and sdf are not enough to host a raid5 profile).
A metadata profile raid5, will be stored on sda, sdb, sdc (these are enough to host a raid5 profile).

Quoted 5 lines
Quoted 3 lines

To enable this mode pass -o ssd_metadata at mount time.

The idea of this sounds similar to what Anand has been working on with the readmirror patchset[1] which was originally designed to prefer reading from SSD devices in a RAID1 configuration but has evolved into allowing the read policy to be configured through sysfs,

The work done by Anand is very different. He is working to developing better policy about which mirror has to be select during the reading.

I am investigating the possibility to store (reading and *writing*) the metadata in SSD and the data in rotational disk.

Quoted 1 line

at least partly because detecting SSDs correctly is not an exact science. Also, there may be more considerations than just HDD or SSD: for example in my system I use a SATA SSD and an NVMe SSD in RAID1 where the NVMe device is twice the speed of the SSD.

There is the "rotational" attribute, which can be set or by the kernel or by appropriate udev rules.

Quoted 2 lines

I would therefore vote for configurability of this rather than always choosing SSD over HDD.

As state above, there are two completely different patch set, which address two different problem.

Quoted 3 lines

[1] https://patchwork.kernel.org/project/linux-btrfs/list/?series=245121

Signature · 2 lines
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5
#5 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

In reply to Steven Davies

02.04.2020 12:33, Steven Davies пишет:

Quoted 24 lines · Goffredo Baroncelli
Quoted 23 lines

From: Goffredo Baroncelli <[email protected]>

When this mode is enabled, the allocation policy of the chunk is so modified:
- when a metadata chunk is allocated, priority is given to ssd disk.
- When a data chunk is allocated, priority is given to a rotational disk.

When a striped profile is involved (like RAID0,5,6), the logic is a bit more complex. If there are enough disks, the data profiles are stored on the rotational disks only; the metadata profiles are stored on the non rotational disk only.
If the disks are not enough, then the profiles is stored on all the disks.

Example: assuming that sda, sdb, sdc are ssd disks, and sde, sdf are rotational ones.
A data profile raid5, will be stored on sda, sdb, sdc, sde, sdf (sde and sdf are not enough to host a raid5 profile).
A metadata profile raid5, will be stored on sda, sdb, sdc (these are enough to host a raid5 profile).

Quoted 5 lines
Quoted 3 lines

To enable this mode pass -o ssd_metadata at mount time.

The idea of this sounds similar to what Anand has been working on with the readmirror patchset[1] which was originally designed to prefer reading from SSD devices in a RAID1 configuration but has evolved into allowing the read policy to be configured through sysfs, at least partly because detecting SSDs correctly is not an exact science. Also, there may be more considerations than just HDD or SSD: for example in my system I use a SATA SSD and an NVMe SSD in RAID1 where the NVMe device is twice the speed of the SSD.

May be something like -o metadata_preferred_devices=device_id,[device_id,[device_id]]... ?

Quoted 5 lines

I would therefore vote for configurability of this rather than always choosing SSD over HDD.

[1] https://patchwork.kernel.org/project/linux-btrfs/list/?series=245121

Signature · 2 lines
С уважением, Михаил
067-786-11-75
#6 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

Quoted 25 lines · Michael

02.04.2020 12:33, Steven Davies пишет:

Quoted 24 lines · Goffredo Baroncelli
Quoted 23 lines

From: Goffredo Baroncelli <[email protected]>

When this mode is enabled, the allocation policy of the chunk is so modified:
- when a metadata chunk is allocated, priority is given to ssd disk.
- When a data chunk is allocated, priority is given to a rotational disk.

When a striped profile is involved (like RAID0,5,6), the logic is a bit more complex. If there are enough disks, the data profiles are stored on the rotational disks only; the metadata profiles are stored on the non rotational disk only.
If the disks are not enough, then the profiles is stored on all the disks.

Example: assuming that sda, sdb, sdc are ssd disks, and sde, sdf are rotational ones.
A data profile raid5, will be stored on sda, sdb, sdc, sde, sdf (sde and sdf are not enough to host a raid5 profile).
A metadata profile raid5, will be stored on sda, sdb, sdc (these are enough to host a raid5 profile).

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

To enable this mode pass -o ssd_metadata at mount time.

The idea of this sounds similar to what Anand has been working on with the readmirror patchset[1] which was originally designed to prefer reading from SSD devices in a RAID1 configuration but has evolved into allowing the read policy to be configured through sysfs, at least partly because detecting SSDs correctly is not an exact science. Also, there may be more considerations than just HDD or SSD: for example in my system I use a SATA SSD and an NVMe SSD in RAID1 where the NVMe device is twice the speed of the SSD.

May be something like -o metadata_preferred_devices=device_id,[device_id,[device_id]]... ?

Yes, that's what I was thinking of.

Signature · 1 line
Steven Davies
#7 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

In reply to Michael
Quoted 3 lines · Michael

02.04.2020 12:33, Steven Davies пишет:

Quoted 2 lines · Goffredo Baroncelli
Quoted 1 line

From: Goffredo Baroncelli <[email protected]>

[...]

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

To enable this mode pass -o ssd_metadata at mount time.

The idea of this sounds similar to what Anand has been working on with the readmirror patchset[1] which was originally designed to prefer reading from SSD devices in a RAID1 configuration but has evolved into allowing the read policy to be configured through sysfs, at least partly because detecting SSDs correctly is not an exact science. Also, there may be more considerations than just HDD or SSD: for example in my system I use a SATA SSD and an NVMe SSD in RAID1 where the NVMe device is twice the speed of the SSD.

May be something like -o metadata_preferred_devices=device_id,[device_id,[device_id]]... ?

I think that it should be a device property instead of a device list passed at mount time. Looking at the btrfs_dev_item structure (which is embedded in the super block), there are several promising fields:
- seek_speed
- bandwidth
- dev_group

currently these fields are unused. Se we are free to use as we wish. For example, if we use 2 bit of dev_group as marker for "not for metadata" and "not for date" we can have the following combination:
- 0 (default) -> the disk is suitable for both data and metadata
- "not for metadata" -> the disk has an high priority for "data"
- "not for data" -> the disk has an high priority for "metadata"
- "not for data" and "not for metadata" -> invalid

As kernel<->user space interface, I like the idea to export these bits via sysfs.. unfortunately there is no a directory for the devices.... :-(

Quoted 6 lines
Quoted 5 lines

I would therefore vote for configurability of this rather than always choosing SSD over HDD.

[1] https://patchwork.kernel.org/project/linux-btrfs/list/?series=245121

Signature · 2 lines
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5
#8 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

Quoted 12 lines · Goffredo Baroncelli
Quoted 3 lines · Michael

02.04.2020 12:33, Steven Davies пишет:

Quoted 2 lines · Goffredo Baroncelli
Quoted 1 line

From: Goffredo Baroncelli <[email protected]>

[...]

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

To enable this mode pass -o ssd_metadata at mount time.

The idea of this sounds similar to what Anand has been working on with the readmirror patchset[1] which was originally designed to prefer reading from SSD devices in a RAID1 configuration but has evolved into allowing the read policy to be configured through sysfs, at least partly because detecting SSDs correctly is not an exact science. Also, there may be more considerations than just HDD or SSD: for example in my system I use a SATA SSD and an NVMe SSD in RAID1 where the NVMe device is twice the speed of the SSD.

May be something like -o metadata_preferred_devices=device_id,[device_id,[device_id]]... ?

Quoted 7 lines

I think that it should be a device property instead of a device list passed at mount time. Looking at the btrfs_dev_item structure (which is embedded in the super block), there are several promising fields:
- seek_speed
- bandwidth
- dev_group

currently these fields are unused.

The first two of these at least were left over from the last
attempt at this which got anywhere near code.

If you're going to do this kind of thing, please read (at least) my
(sadly code-less; sorry) proposal from a few years ago:

https://www.mail-archive.com/[email protected]/msg33632.html

Essentially, allowing for multiple policies for chunk allocation,
of which this case is a small subset.

I'd envisaged putting the relevant config data into properties, but
since we didn't actually have them in any sense at the time, I got bogged down in that part of it.

Quoted 18 lines

Se we are free to use as we wish. For example, if we use 2 bit of dev_group as marker for "not for metadata" and "not for date" we can have the following combination:
- 0 (default) -> the disk is suitable for both data and metadata
- "not for metadata" -> the disk has an high priority for "data"
- "not for data" -> the disk has an high priority for "metadata"
- "not for data" and "not for metadata" -> invalid

As kernel<->user space interface, I like the idea to export these bits via sysfs.. unfortunately there is no a directory for the devices.... :-(

Quoted 6 lines
Quoted 5 lines

I would therefore vote for configurability of this rather than always choosing SSD over HDD.

[1] https://patchwork.kernel.org/project/linux-btrfs/list/?series=245121

Signature · 4 lines
Hugo Mills             | Some days, it's just not worth gnawing through the
hugo@... carfax.org.uk | straps
http://carfax.org.uk/  |
PGP: E2AB1DE4          |
#9 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

Quoted 27 lines · Hugo Mills
Quoted 12 lines · Goffredo Baroncelli
Quoted 3 lines · Michael

02.04.2020 12:33, Steven Davies пишет:

Quoted 2 lines · Goffredo Baroncelli
Quoted 1 line

From: Goffredo Baroncelli <[email protected]>

[...]

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

To enable this mode pass -o ssd_metadata at mount time.

The idea of this sounds similar to what Anand has been working on with the readmirror patchset[1] which was originally designed to prefer reading from SSD devices in a RAID1 configuration but has evolved into allowing the read policy to be configured through sysfs, at least partly because detecting SSDs correctly is not an exact science. Also, there may be more considerations than just HDD or SSD: for example in my system I use a SATA SSD and an NVMe SSD in RAID1 where the NVMe device is twice the speed of the SSD.

May be something like -o metadata_preferred_devices=device_id,[device_id,[device_id]]... ?

Quoted 7 lines

I think that it should be a device property instead of a device list passed at mount time. Looking at the btrfs_dev_item structure (which is embedded in the super block), there are several promising fields:
- seek_speed
- bandwidth
- dev_group

currently these fields are unused.

The first two of these at least were left over from the last
attempt at this which got anywhere near code.

If you're going to do this kind of thing, please read (at least) my
(sadly code-less; sorry) proposal from a few years ago:

Quoted 8 lines

https://www.mail-archive.com/[email protected]/msg33632.html

Essentially, allowing for multiple policies for chunk allocation,
of which this case is a small subset.

I'd envisaged putting the relevant config data into properties, but
since we didn't actually have them in any sense at the time, I got bogged down in that part of it.

Ideas about properties:

https://github.com/kdave/drafts/blob/master/btrfs/properties.txt

Quoted 19 lines
Quoted 18 lines

Se we are free to use as we wish. For example, if we use 2 bit of dev_group as marker for "not for metadata" and "not for date" we can have the following combination:
- 0 (default) -> the disk is suitable for both data and metadata
- "not for metadata" -> the disk has an high priority for "data"
- "not for data" -> the disk has an high priority for "metadata"
- "not for data" and "not for metadata" -> invalid

As kernel<->user space interface, I like the idea to export these bits via sysfs.. unfortunately there is no a directory for the devices.... :-(

Quoted 6 lines
Quoted 5 lines

I would therefore vote for configurability of this rather than always choosing SSD over HDD.

[1] https://patchwork.kernel.org/project/linux-btrfs/list/?series=245121

#10 lore raw

Re: [PATCH] btrfs: add ssd_metadata mode

In reply to Goffredo Baroncelli

Hi Goffredo,

we're using similar in-house patch on our backup servers for years and the performance impact is HUGE. Or backup workload includes rsyncs of mailservers/webservers and image-based CBT vSphere backups, we've hundreds of millions of files and thousands of daily snapshots on every backup server. Nothing of this would be possible without dedicated metadata SSDs. A typical btrfs backup server has two 500 GB NVMe SSDs in btrfs RAID1 and twelve 10TB SATA drives in hardware RAID6.

Our chunk allocation logic is fairly simple: if btrfs contains both rotational and non-rotational drives and there's a metadata chunk allocation request, ignore rotational drives in __btrfs_alloc_chunk(); in the same way, ignore non-rotational drives when allocating a data chunk. If the allocation request cannot be satisfied, fallback to the standard __btrfs_alloc_chunk() implementation which uses all available drives.

Martin

Dne 1.4.2020 v 22:03 Goffredo Baroncelli napsal(a):

Quoted 224 lines

From: Goffredo Baroncelli <[email protected]>

When this mode is enabled, the allocation policy of the chunk is so modified:
- when a metadata chunk is allocated, priority is given to ssd disk.
- When a data chunk is allocated, priority is given to a rotational disk.

When a striped profile is involved (like RAID0,5,6), the logic is a bit more complex. If there are enough disks, the data profiles are stored on the rotational disks only; the metadata profiles are stored on the non rotational disk only.
If the disks are not enough, then the profiles is stored on all the disks.

Example: assuming that sda, sdb, sdc are ssd disks, and sde, sdf are rotational ones.
A data profile raid5, will be stored on sda, sdb, sdc, sde, sdf (sde and sdf are not enough to host a raid5 profile).
A metadata profile raid5, will be stored on sda, sdb, sdc (these are enough to host a raid5 profile).

To enable this mode pass -o ssd_metadata at mount time.

---
 fs/btrfs/ctree.h   |  1 +
 fs/btrfs/super.c   |  8 +++++
 fs/btrfs/volumes.c | 89 ++++++++++++++++++++++++++++++++++++++++++++--
 fs/btrfs/volumes.h |  1 +
 4 files changed, 97 insertions(+), 2 deletions(-)
fs/btrfs/ctree.h +1 -0
index 2e9f938508e9..0f3c09cc4863 100644
@@ -1187,6 +1187,7 @@ static inline u32 BTRFS_MAX_XATTR_SIZE(const struct btrfs_fs_info *info)
 #define BTRFS_MOUNT_FREE_SPACE_TREE	(1 << 26)
 #define BTRFS_MOUNT_NOLOGREPLAY		(1 << 27)
 #define BTRFS_MOUNT_REF_VERIFY		(1 << 28)
+#define BTRFS_MOUNT_SSD_METADATA	(1 << 29)
 
 #define BTRFS_DEFAULT_COMMIT_INTERVAL	(30)
 #define BTRFS_DEFAULT_MAX_INLINE	(2048)
fs/btrfs/super.c +8 -0
index c6557d44907a..d0a5cf496f90 100644
@@ -346,6 +346,7 @@ enum {
 #ifdef CONFIG_BTRFS_FS_REF_VERIFY
 	Opt_ref_verify,
 #endif
+	Opt_ssd_metadata,
 	Opt_err,
 };
 
@@ -416,6 +417,7 @@ static const match_table_t tokens = {
 #ifdef CONFIG_BTRFS_FS_REF_VERIFY
 	{Opt_ref_verify, "ref_verify"},
 #endif
+	{Opt_ssd_metadata, "ssd_metadata"},
 	{Opt_err, NULL},
 };
 
@@ -853,6 +855,10 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
 			btrfs_set_opt(info->mount_opt, REF_VERIFY);
 			break;
 #endif
+		case Opt_ssd_metadata:
+			btrfs_set_and_info(info, SSD_METADATA,
+					"enabling ssd_metadata");
+			break;
 		case Opt_err:
 			btrfs_info(info, "unrecognized mount option '%s'", p);
 			ret = -EINVAL;
@@ -1369,6 +1375,8 @@ static int btrfs_show_options(struct seq_file *seq, struct dentry *dentry)
 #endif
 	if (btrfs_test_opt(info, REF_VERIFY))
 		seq_puts(seq, ",ref_verify");
+	if (btrfs_test_opt(info, SSD_METADATA))
+		seq_puts(seq, ",ssd_metadata");
 	seq_printf(seq, ",subvolid=%llu",
 		  BTRFS_I(d_inode(dentry))->root->root_key.objectid);
 	seq_puts(seq, ",subvol=");
fs/btrfs/volumes.c +87 -2
index a8b71ded4d21..678dc3366711 100644
@@ -4758,6 +4758,58 @@ static int btrfs_cmp_device_info(const void *a, const void *b)
 	return 0;
 }
 
+/*
+ * sort the devices in descending order by rotational,
+ * max_avail, total_avail
+ */
+static int btrfs_cmp_device_info_metadata(const void *a, const void *b)
+{
+	const struct btrfs_device_info *di_a = a;
+	const struct btrfs_device_info *di_b = b;
+
+	/* metadata -> non rotational first */
+	if (!di_a->rotational && di_b->rotational)
+		return -1;
+	if (di_a->rotational && !di_b->rotational)
+		return 1;
+	if (di_a->max_avail > di_b->max_avail)
+		return -1;
+	if (di_a->max_avail < di_b->max_avail)
+		return 1;
+	if (di_a->total_avail > di_b->total_avail)
+		return -1;
+	if (di_a->total_avail < di_b->total_avail)
+		return 1;
+	return 0;
+}
+
+/*
+ * sort the devices in descending order by !rotational,
+ * max_avail, total_avail
+ */
+static int btrfs_cmp_device_info_data(const void *a, const void *b)
+{
+	const struct btrfs_device_info *di_a = a;
+	const struct btrfs_device_info *di_b = b;
+
+	/* data -> non rotational last */
+	if (!di_a->rotational && di_b->rotational)
+		return 1;
+	if (di_a->rotational && !di_b->rotational)
+		return -1;
+	if (di_a->max_avail > di_b->max_avail)
+		return -1;
+	if (di_a->max_avail < di_b->max_avail)
+		return 1;
+	if (di_a->total_avail > di_b->total_avail)
+		return -1;
+	if (di_a->total_avail < di_b->total_avail)
+		return 1;
+	return 0;
+}
+
+
+
 static void check_raid56_incompat_flag(struct btrfs_fs_info *info, u64 type)
 {
 	if (!(type & BTRFS_BLOCK_GROUP_RAID56_MASK))
@@ -4805,6 +4857,7 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
 	int i;
 	int j;
 	int index;
+	int nr_rotational;
 
 	BUG_ON(!alloc_profile_is_valid(type, 0));
 
@@ -4860,6 +4913,7 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
 	 * about the available holes on each device.
 	 */
 	ndevs = 0;
+	nr_rotational = 0;
 	list_for_each_entry(device, &fs_devices->alloc_list, dev_alloc_list) {
 		u64 max_avail;
 		u64 dev_offset;
@@ -4911,14 +4965,45 @@ static int __btrfs_alloc_chunk(struct btrfs_trans_handle *trans,
 		devices_info[ndevs].max_avail = max_avail;
 		devices_info[ndevs].total_avail = total_avail;
 		devices_info[ndevs].dev = device;
+		devices_info[ndevs].rotational = !test_bit(QUEUE_FLAG_NONROT,
+				&(bdev_get_queue(device->bdev)->queue_flags));
+		if (devices_info[ndevs].rotational)
+			nr_rotational++;
 		++ndevs;
 	}
 
+	BUG_ON(nr_rotational > ndevs);
 	/*
 	 * now sort the devices by hole size / available space
 	 */
-	sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
-	     btrfs_cmp_device_info, NULL);
+	if (((type & BTRFS_BLOCK_GROUP_DATA) &&
+	     (type & BTRFS_BLOCK_GROUP_METADATA)) ||
+	    !btrfs_test_opt(info, SSD_METADATA)) {
+		/* mixed bg or SSD_METADATA not set */
+		sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
+			     btrfs_cmp_device_info, NULL);
+	} else {
+		/*
+		 * if SSD_METADATA is set, sort the device considering also the
+		 * kind (ssd or not). Limit the availables devices to the ones
+		 * of the same kind, to avoid that a striped profile like raid5
+		 * spans to all kind of devices (ssd and rotational).
+		 * It is allowed to span different kind of devices if the ones of
+		 * the same kind are not enough alone.
+		 */
+		if (type & BTRFS_BLOCK_GROUP_DATA) {
+			sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
+				     btrfs_cmp_device_info_data, NULL);
+			if (nr_rotational > devs_min)
+				ndevs = nr_rotational;
+		} else {
+			int nr_norot = ndevs - nr_rotational;
+			sort(devices_info, ndevs, sizeof(struct btrfs_device_info),
+				     btrfs_cmp_device_info_metadata, NULL);
+			if (nr_norot > devs_min)
+				ndevs = nr_norot;
+		}
+	}
 
 	/*
 	 * Round down to number of usable stripes, devs_increment can be any
fs/btrfs/volumes.h +1 -0
index fc1b564b9cfe..bc1cfa0c27ea 100644
@@ -340,6 +340,7 @@ struct btrfs_device_info {
 	u64 dev_offset;
 	u64 max_avail;
 	u64 total_avail;
+	int rotational:1;
 };
 
 struct btrfs_raid_attr {