Skip to contentSkip to conversation

ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT

PATCH New Marek Vasut 3 participants 3 messages Apr 2, 2020 – Apr 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT

The card-detect GPIO and any other GPIO access currently doesn't work in U-Boot SPL on any STM32 platform and crashes the SPL. To work around this problem on AV96 right before release, remove the cd-gpios from DT. This patch must be reverted right after release, once the proper fix for the GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied.

Cc Manivannan Sadhasivam <[email protected]>
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Tom Rini <[email protected]>

---
NOTE: I think it's OK if Tom picks this one directly to reduce load on
the ST people, since this is isolated to a single board.

---
 arch/arm/dts/stm32mp157a-avenger96.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/dts/stm32mp157a-avenger96.dts +0 -1
index 1f32395e71..b23fa6dee0 100644
@@ -353,7 +353,6 @@
 	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;
 	pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>;
 	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>;
-	cd-gpios = <&gpioi 8 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	st,sig-dir;
 	st,neg-edge;
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT

Quoted 7 lines · Marek Vasut

The card-detect GPIO and any other GPIO access currently doesn't work in U-Boot SPL on any STM32 platform and crashes the SPL. To work around this problem on AV96 right before release, remove the cd-gpios from DT. This patch must be reverted right after release, once the proper fix for the GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied.

Thanks,
Mani

Quoted 26 lines
Cc Manivannan Sadhasivam <[email protected]>
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Tom Rini <[email protected]>

---
NOTE: I think it's OK if Tom picks this one directly to reduce load on
the ST people, since this is isolated to a single board.

---
 arch/arm/dts/stm32mp157a-avenger96.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/dts/stm32mp157a-avenger96.dts +0 -1
index 1f32395e71..b23fa6dee0 100644
@@ -353,7 +353,6 @@
 	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_dir_pins_b>;
 	pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_dir_pins_b>;
 	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a &sdmmc1_dir_sleep_pins_b>;
-	cd-gpios = <&gpioi 8 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	st,sig-dir;
 	st,neg-edge;
Signature · 1 line
2.25.1
#2 lore raw

PATCH 1/1 ARM: dts: stm32: Temporarily drop cd-gpios from AV96 DT

In reply to Marek Vasut
Quoted 6 lines · Marek Vasut

The card-detect GPIO and any other GPIO access currently doesn't work in U-Boot SPL on any STM32 platform and crashes the SPL. To work around this problem on AV96 right before release, remove the cd-gpios from DT. This patch must be reverted right after release, once the proper fix for the GPIO driver, "gpio: stm32: support gpio ops in SPL", is applied.

Quoted 6 lines
Cc Manivannan Sadhasivam <[email protected]>
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200406/38828296/attachment.sig>